Re: Bug: swap discard issue with zram caused by "block: don't deal with discard limit in blkdev_issue_discard()"

2018-10-25 Thread Ming Lei
On Thu, Oct 25, 2018 at 05:09:32PM +0100, Rui Salvaterra wrote: > Hi, > > After commit 744889b7cbb56a64f957e65ade7cb65fe3f35714, I started > getting this (-EIO, it seems) on my dmesg: > > swapon: discard_swap(c275f02d): -5 > > This is an 8 GB zram swap device. It's configured like this:

[PATCH 3/3] block: make sure writesame bio is aligned with logical block size

2018-10-25 Thread Ming Lei
Obviously the created writesame bio has to be aligned with logical block size. Fixes: b49a0871be31a745b2ef ("block: remove split code in blkdev_issue_{discard,write_same}") Cc: Rui Salvaterra Cc: sta...@vger.kernel.org Cc: Mike Snitzer Cc: Christoph Hellwig Cc: Xiao Ni Cc: Mariusz Dabrowski

[PATCH 0/3] block: make sure discard/writesame bio is aligned with logical block size

2018-10-25 Thread Ming Lei
Hi, The 1st & 3rd patch fixes bio size alignment issue. The 2nd patch cleans up __blkdev_issue_discard() a bit. Thanks, Ming Lei (3): block: make sure discard bio is aligned with logical block size block: cleanup __blkdev_issue_discard() block: make sure writesame bio is aligned with log

[PATCH 2/3] block: cleanup __blkdev_issue_discard()

2018-10-25 Thread Ming Lei
Cleanup __blkdev_issue_discard(). Cc: Rui Salvaterra Cc: Mike Snitzer Cc: Christoph Hellwig Cc: Xiao Ni Cc: Mariusz Dabrowski Signed-off-by: Ming Lei --- block/blk-lib.c | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/block/blk-lib.c b/block/blk-

[PATCH 1/3] block: make sure discard bio is aligned with logical block size

2018-10-25 Thread Ming Lei
Obviously the created discard bio has to be aligned with logical block size. Fixes: 744889b7cbb56a6 ("block: don't deal with discard limit in blkdev_issue_discard()") Reported-by: Rui Salvaterra Cc: Rui Salvaterra Cc: sta...@vger.kernel.org Cc: Mike Snitzer Cc: Christoph Hellwig Cc: Xiao Ni

Re: Bug: swap discard issue with zram caused by "block: don't deal with discard limit in blkdev_issue_discard()"

2018-10-25 Thread Ming Lei
On Thu, Oct 25, 2018 at 05:09:32PM +0100, Rui Salvaterra wrote: > Hi, > > After commit 744889b7cbb56a64f957e65ade7cb65fe3f35714, I started > getting this (-EIO, it seems) on my dmesg: > > swapon: discard_swap(c275f02d): -5 > > This is an 8 GB zram swap device. It's configured like this:

Re: [PATCH] blk-mq: ensure hctx to be ran on mapped cpu when issue directly

2018-10-25 Thread Jens Axboe
On 10/25/18 7:38 PM, jianchao.wang wrote: > Hi Jens > > On 10/26/18 12:25 AM, Jens Axboe wrote: >> On 10/24/18 9:20 AM, Jianchao Wang wrote: >>> When issue request directly and the task is migrated out of the >>> original cpu where it allocates request, hctx could be ran on >>> the cpu where it is

Re: [PATCH] blk-mq: ensure hctx to be ran on mapped cpu when issue directly

2018-10-25 Thread jianchao.wang
Hi Jens On 10/26/18 12:25 AM, Jens Axboe wrote: > On 10/24/18 9:20 AM, Jianchao Wang wrote: >> When issue request directly and the task is migrated out of the >> original cpu where it allocates request, hctx could be ran on >> the cpu where it is not mapped. To fix this, insert the request >> if B

[PATCH v2] lightnvm: pblk: ignore the smeta oob area scan

2018-10-25 Thread Zhoujie Wu
The smeta area l2p mapping is empty, and actually the recovery procedure only need to restore data sector's l2p mapping. So ignore the smeta oob scan. Signed-off-by: Zhoujie Wu --- v2: Modified based on suggestion from Hans. The smeta may not start from paddr 0 if the first block is bad. Use pblk

Re: [PATCH v8] virtio_blk: add discard and write zeroes support

2018-10-25 Thread Paolo Bonzini
On 15/10/2018 11:27, Christoph Hellwig wrote: > There is some issues in this spec. For one using the multiple ranges > also for write zeroes is rather inefficient. Write zeroes really should > use the same format as read and write. What makes it inefficient? > Second the unmap flag isn't proper

Re: [EXT] Re: [PATCH] lightnvm: pblk: ignore the smeta oob area scan

2018-10-25 Thread Zhoujie Wu
On 10/25/2018 04:16 AM, Hans Holmberg wrote: External Email -- On Thu, Oct 25, 2018 at 2:44 AM Zhoujie Wu wrote: The smeta area l2p mapping is empty, and actually the recovery procedure only need to restore data sector's l2

Re: [PATCHSET 0/28] blk-mq driver conversions and legacy path removal

2018-10-25 Thread Jens Axboe
On 10/25/18 5:09 PM, Bart Van Assche wrote: > On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: >> The first round of this went into 4.20-rc, but we've still some of >> them pending. This patch series converts the remaining drivers to >> blk-mq. The ones that support dual paths (like SCSI and DM

Re: [PATCHSET 0/28] blk-mq driver conversions and legacy path removal

2018-10-25 Thread Bart Van Assche
On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: > The first round of this went into 4.20-rc, but we've still some of > them pending. This patch series converts the remaining drivers to > blk-mq. The ones that support dual paths (like SCSI and DM) have > the non-mq path removed. At the end, leg

Re: [PATCH 08/28] scsi: kill off the legacy IO path

2018-10-25 Thread Madhani, Himanshu
> On Oct 25, 2018, at 4:00 PM, Jens Axboe wrote: > > External Email > > On 10/25/18 4:44 PM, Madhani, Himanshu wrote: >> Jens, >> >>> On Oct 25, 2018, at 3:18 PM, Jens Axboe wrote: >>> >>> External Email >>> >>> On 10/25/18 3:36 PM, Bart Van Assche wrote: On Thu, 2018-10-25 at 15:10 -

Re: [PATCH 11/14] irq: add support for allocating (and affinitizing) sets of IRQs

2018-10-25 Thread Jens Axboe
On 10/25/18 3:52 PM, Keith Busch wrote: > On Thu, Oct 25, 2018 at 03:16:23PM -0600, Jens Axboe wrote: >> A driver may have a need to allocate multiple sets of MSI/MSI-X >> interrupts, and have them appropriately affinitized. Add support for >> defining a number of sets in the irq_affinity structure

Re: [PATCH 08/28] scsi: kill off the legacy IO path

2018-10-25 Thread Jens Axboe
On 10/25/18 4:44 PM, Madhani, Himanshu wrote: > Jens, > >> On Oct 25, 2018, at 3:18 PM, Jens Axboe wrote: >> >> External Email >> >> On 10/25/18 3:36 PM, Bart Van Assche wrote: >>> On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: @@ -3265,25 +3261,17 @@ qla2x00_probe_one(struct pci_dev

Re: [PATCH 08/28] scsi: kill off the legacy IO path

2018-10-25 Thread Madhani, Himanshu
Jens, > On Oct 25, 2018, at 3:18 PM, Jens Axboe wrote: > > External Email > > On 10/25/18 3:36 PM, Bart Van Assche wrote: >> On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: >>> @@ -3265,25 +3261,17 @@ qla2x00_probe_one(struct pci_dev *pdev, const >>> struct pci_device_id *id) >>>

Re: [PATCH 23/28] block: kill lld busy

2018-10-25 Thread Jens Axboe
On 10/25/18 3:42 PM, Bart Van Assche wrote: > On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: >> Nobody sets the helper, so we always return 0. Kill it. > > How about changing the description of this patch into something > like "Now that the blk_lld_busy() and blk_queue_lld_busy() callers > h

Re: [PATCH 08/28] scsi: kill off the legacy IO path

2018-10-25 Thread Jens Axboe
On 10/25/18 3:36 PM, Bart Van Assche wrote: > On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: >> @@ -3265,25 +3261,17 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct >> pci_device_id *id) >> base_vha->mgmt_svr_loop_id, host->sg_tablesize); >> >> if (ha->mqenable) { >>

Re: [PATCH 11/14] irq: add support for allocating (and affinitizing) sets of IRQs

2018-10-25 Thread Keith Busch
On Thu, Oct 25, 2018 at 03:16:23PM -0600, Jens Axboe wrote: > A driver may have a need to allocate multiple sets of MSI/MSI-X > interrupts, and have them appropriately affinitized. Add support for > defining a number of sets in the irq_affinity structure, of varying > sizes, and get each set affini

Re: [PATCH 23/28] block: kill lld busy

2018-10-25 Thread Bart Van Assche
On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: > Nobody sets the helper, so we always return 0. Kill it. How about changing the description of this patch into something like "Now that the blk_lld_busy() and blk_queue_lld_busy() callers have been removed, also remove the implementations of th

Re: [PATCH 08/28] scsi: kill off the legacy IO path

2018-10-25 Thread Bart Van Assche
On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: > @@ -3265,25 +3261,17 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct > pci_device_id *id) > base_vha->mgmt_svr_loop_id, host->sg_tablesize); > > if (ha->mqenable) { > - bool mq = false; > boo

Re: [PATCH 05/28] IB/srp: remove old request_fn_active check

2018-10-25 Thread Jens Axboe
On 10/25/18 3:23 PM, Bart Van Assche wrote: > On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: >> This check is only viable for non scsi-mq. Since that is going away, >> kill this legacy check. >> >> Cc: Bart Van Assche >> Cc: Parav Pandit >> Cc: linux-s...@vger.kernel.org >> Signed-off-by: J

Re: [PATCH 05/28] IB/srp: remove old request_fn_active check

2018-10-25 Thread Bart Van Assche
On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: > This check is only viable for non scsi-mq. Since that is going away, > kill this legacy check. > > Cc: Bart Van Assche > Cc: Parav Pandit > Cc: linux-s...@vger.kernel.org > Signed-off-by: Jens Axboe > --- > drivers/infiniband/ulp/srp/ib_sr

Re: [PATCH 0/2] blktests: New loop tests

2018-10-25 Thread Omar Sandoval
On Thu, Oct 18, 2018 at 12:31:45PM +0200, Jan Kara wrote: > > Hello, > > these two patches create two new tests for blktests as regression tests > for my recently posted loopback device fixes. More details in individual > patches. Thanks, Jan, I applied 007 renamed to 006.

[PATCH 10/14] blk-mq: initial support for multiple queue maps

2018-10-25 Thread Jens Axboe
Add a queue offset to the tag map. This enables users to map iteratively, for each queue map type they support. Bump maximum number of supported maps to 2, we're now fully able to support more than 1 map. Signed-off-by: Jens Axboe --- block/blk-mq-cpumap.c | 9 + block/blk-mq-pci.c

[PATCH 09/14] blk-mq: ensure that plug lists don't straddle hardware queues

2018-10-25 Thread Jens Axboe
Since we insert per hardware queue, we have to ensure that every request on the plug list being inserted belongs to the same hardware queue. Signed-off-by: Jens Axboe --- block/blk-mq.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/block/blk-mq.

[PATCH 08/14] blk-mq: separate number of hardware queues from nr_cpu_ids

2018-10-25 Thread Jens Axboe
With multiple maps, nr_cpu_ids is no longer the maximum number of hardware queues we support on a given devices. The initializer of the tag_set can have set ->nr_hw_queues larger than the available number of CPUs, since we can exceed that with multiple queue maps. Signed-off-by: Jens Axboe --- b

[PATCH 06/14] blk-mq: add 'type' attribute to the sysfs hctx directory

2018-10-25 Thread Jens Axboe
It can be useful for a user to verify what type a given hardware queue is, expose this information in sysfs. Signed-off-by: Jens Axboe --- block/blk-mq-sysfs.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/blk-mq-sysfs.c b/block/blk-mq-sysfs.c index aafb44224c89..2d737f9e

[PATCH 13/14] block: add REQ_HIPRI and inherit it from IOCB_HIPRI

2018-10-25 Thread Jens Axboe
We use IOCB_HIPRI to poll for IO in the caller instead of scheduling. This information is not available for (or after) IO submission. The driver may make different queue choices based on the type of IO, so make the fact that we will poll for this IO known to the lower layers as well. Signed-off-by

[PATCH 07/14] blk-mq: support multiple hctx maps

2018-10-25 Thread Jens Axboe
Add support for the tag set carrying multiple queue maps, and for the driver to inform blk-mq how many it wishes to support through setting set->nr_maps. This adds an mq_ops helper for drivers that support more than 1 map, mq_ops->flags_to_type(). The function takes request/bio flags and CPU, and

[PATCH 11/14] irq: add support for allocating (and affinitizing) sets of IRQs

2018-10-25 Thread Jens Axboe
A driver may have a need to allocate multiple sets of MSI/MSI-X interrupts, and have them appropriately affinitized. Add support for defining a number of sets in the irq_affinity structure, of varying sizes, and get each set affinitized correctly across the machine. Cc: Thomas Gleixner Cc: linux-

[PATCH 14/14] nvme: add separate poll queue map

2018-10-25 Thread Jens Axboe
Adds support for defining a variable number of poll queues, currently configurable with the 'poll_queues' module parameter. Defaults to a single poll queue. And now we finally have poll support without triggering interrupts! Signed-off-by: Jens Axboe --- drivers/nvme/host/pci.c | 103 ++

[PATCH 12/14] nvme: utilize two queue maps, one for reads and one for writes

2018-10-25 Thread Jens Axboe
NVMe does round-robin between queues by default, which means that sharing a queue map for both reads and writes can be problematic in terms of read servicing. It's much easier to flood the queue with writes and reduce the read servicing. Implement two queue maps, one for reads and one for writes.

[PATCH 03/14] blk-mq: provide dummy blk_mq_map_queue_type() helper

2018-10-25 Thread Jens Axboe
Doesn't do anything right now, but it's needed as a prep patch to get the interfaces right. Signed-off-by: Jens Axboe --- block/blk-mq.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/blk-mq.h b/block/blk-mq.h index 889f0069dd80..79c300faa7ce 100644 --- a/block/blk-mq.h +++ b/bl

[PATCH 02/14] blk-mq: abstract out queue map

2018-10-25 Thread Jens Axboe
This is in preparation for allowing multiple sets of maps per queue, if so desired. Signed-off-by: Jens Axboe --- block/blk-mq-cpumap.c | 10 block/blk-mq-pci.c| 10 block/blk-mq-rdma.c | 4 ++-- block/blk-mq-virtio.c

[PATCH 05/14] blk-mq: allow software queue to map to multiple hardware queues

2018-10-25 Thread Jens Axboe
The mapping used to be dependent on just the CPU location, but now it's a tuple of { type, cpu} instead. This is a prep patch for allowing a single software queue to map to multiple hardware queues. No functional changes in this patch. Signed-off-by: Jens Axboe --- block/blk-mq-sched.c | 2 +-

[PATCH 04/14] blk-mq: pass in request/bio flags to queue mapping

2018-10-25 Thread Jens Axboe
Prep patch for being able to place request based not just on CPU location, but also on the type of request. Signed-off-by: Jens Axboe --- block/blk-flush.c | 7 +++--- block/blk-mq-debugfs.c | 4 +++- block/blk-mq-sched.c | 16 ++ block/blk-mq-tag.c | 5 +++-- block/blk

[PATCH 01/14] blk-mq: kill q->mq_map

2018-10-25 Thread Jens Axboe
It's just a pointer to set->mq_map, use that instead. Signed-off-by: Jens Axboe --- block/blk-mq.c | 13 - block/blk-mq.h | 4 +++- include/linux/blkdev.h | 2 -- 3 files changed, 7 insertions(+), 12 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 2

[PATCHSET 0/14] Add support for multiple queue maps

2018-10-25 Thread Jens Axboe
This series adds support for multiple queue maps for blk-mq. Since blk-mq was introduced, it's only support a single queue map. This means you can have 1 set of queues, and the mapping purely depends on what CPU an IO originated from. With this patch set, drivers can implement mappings that depend

[PATCH 24/28] block: remove request_list code

2018-10-25 Thread Jens Axboe
It's now dead code, nobody uses it. Signed-off-by: Jens Axboe --- block/blk-cgroup.c | 47 block/blk-core.c | 75 -- block/blk-mq.c | 4 -- block/blk.h| 3 -- include/linux/blk-cgroup.h | 108 ---

[PATCH 21/28] block: remove __blk_put_request()

2018-10-25 Thread Jens Axboe
Now there's no difference between blk_put_request() and __blk_put_request() anymore, get rid of the underscore version and convert the few callers. Signed-off-by: Jens Axboe --- block/blk-core.c | 9 - block/blk-merge.c | 2 +- drivers/scsi/osd/osd_init

[PATCH 22/28] block: kill legacy parts of timeout handling

2018-10-25 Thread Jens Axboe
The only user of legacy timing now is BSG, which is invoked from the mq timeout handler. Kill the legacy code, and rename the q->rq_timed_out_fn to q->bsg_job_timeout_fn. Signed-off-by: Jens Axboe --- block/blk-core.c | 1 - block/blk-settings.c | 7 --- block/blk-timeout.c| 99 +++

[PATCH 25/28] block: kill request slab cache

2018-10-25 Thread Jens Axboe
Signed-off-by: Jens Axboe --- block/blk-core.c | 8 block/blk.h | 1 - 2 files changed, 9 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index e8f60ed456a2..6074bf2ee2e7 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -57,11 +57,6 @@ EXPORT_TRACEPOINT_SYMBOL_

[PATCH 23/28] block: kill lld busy

2018-10-25 Thread Jens Axboe
Nobody sets the helper, so we always return 0. Kill it. Signed-off-by: Jens Axboe --- block/blk-core.c | 28 block/blk-settings.c | 6 -- drivers/md/dm-mpath.c | 4 +--- include/linux/blkdev.h | 4 4 files changed, 1 insertion(+), 41 deletions(-)

[PATCH 26/28] block: remove req_no_special_merge() from merging code

2018-10-25 Thread Jens Axboe
It'll always be false at this point, just remove it. Signed-off-by: Jens Axboe --- block/blk-merge.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/block/blk-merge.c b/block/blk-merge.c index 7fedc0391610..3561dcce2260 100644 --- a/block/blk-merge.

[PATCH 27/28] blk-merge: kill dead queue lock held check

2018-10-25 Thread Jens Axboe
This is dead code, any queue reaching this part has mq_ops attached. Signed-off-by: Jens Axboe --- block/blk-merge.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/blk-merge.c b/block/blk-merge.c index 3561dcce2260..0128284bded4 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c

[PATCH 28/28] block: get rid of blk_queued_rq()

2018-10-25 Thread Jens Axboe
No point in hiding what this does, just open code it in the one spot where we are still using it. Signed-off-by: Jens Axboe --- block/blk-mq.c | 2 +- include/linux/blkdev.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index d43c92

[PATCH 11/28] bsg: pass in desired timeout handler

2018-10-25 Thread Jens Axboe
This will ease in the conversion to blk-mq, where we can't set a timeout handler after queue init. Cc: Johannes Thumshirn Cc: Benjamin Block Cc: linux-s...@vger.kernel.org Signed-off-by: Jens Axboe --- block/bsg-lib.c | 3 ++- drivers/scsi/scsi_transport_fc.c| 7 +++

[PATCH 12/28] bsg: provide bsg_remove_queue() helper

2018-10-25 Thread Jens Axboe
All drivers do unregister + cleanup, provide a helper for that. Cc: Johannes Thumshirn Cc: Benjamin Block Cc: linux-s...@vger.kernel.org Signed-off-by: Jens Axboe --- block/bsg-lib.c | 7 +++ drivers/scsi/scsi_transport_fc.c| 6 ++ drivers/scsi/scsi_transport_is

[PATCH 17/28] block: remove legacy rq tagging

2018-10-25 Thread Jens Axboe
It's now unused, kill it. Signed-off-by: Jens Axboe --- Documentation/block/biodoc.txt | 88 block/Makefile | 2 +- block/blk-core.c | 6 - block/blk-mq-debugfs.c | 2 - block/blk-mq-tag.c | 6 +- block/blk-sysfs.c

[PATCH 14/28] block: remove blk_complete_request()

2018-10-25 Thread Jens Axboe
It's now unused. Signed-off-by: Jens Axboe --- block/blk-softirq.c| 20 include/linux/blkdev.h | 1 - 2 files changed, 21 deletions(-) diff --git a/block/blk-softirq.c b/block/blk-softirq.c index e47a2f751884..8ca0f6caf174 100644 --- a/block/blk-softirq.c +++ b/block/b

[PATCH 18/28] block: remove non mq parts from the flush code

2018-10-25 Thread Jens Axboe
Signed-off-by: Jens Axboe --- block/blk-flush.c | 154 +- block/blk.h | 4 +- 2 files changed, 31 insertions(+), 127 deletions(-) diff --git a/block/blk-flush.c b/block/blk-flush.c index 8b44b86779da..9baa9a119447 100644 --- a/block/blk-flush.c

[PATCH 09/28] dm: remove legacy IO path

2018-10-25 Thread Jens Axboe
dm supports both, and since we're killing off the legacy path in general, get rid of it in dm as well. Signed-off-by: Jens Axboe --- drivers/md/Kconfig| 11 -- drivers/md/dm-core.h | 10 -- drivers/md/dm-mpath.c | 14 +- drivers/md/dm-rq.c| 293 ---

[PATCH 03/28] mspro_block: convert to blk-mq

2018-10-25 Thread Jens Axboe
Straight forward conversion, there's room for improvement. Signed-off-by: Jens Axboe --- drivers/memstick/core/mspro_block.c | 121 +++- 1 file changed, 66 insertions(+), 55 deletions(-) diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_bloc

[PATCH 13/28] bsg: convert to use blk-mq

2018-10-25 Thread Jens Axboe
Requires a few changes to the FC transport class as well. Cc: Johannes Thumshirn Cc: Benjamin Block Cc: linux-s...@vger.kernel.org Signed-off-by: Jens Axboe --- block/bsg-lib.c | 123 +++ drivers/scsi/scsi_transport_fc.c | 59 +-- 2 fil

[PATCH 16/28] blk-cgroup: remove legacy queue bypassing

2018-10-25 Thread Jens Axboe
We only support mq devices now. Signed-off-by: Jens Axboe --- block/blk-cgroup.c | 8 1 file changed, 8 deletions(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 992da5592c6e..5f10d755ec52 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1446,8 +1446,6 @@ int

[PATCH 15/28] blk-wbt: kill check for legacy queue type

2018-10-25 Thread Jens Axboe
Everything is blk-mq at this point, so it doesn't make any sense to have this option available as it does nothing. Signed-off-by: Jens Axboe --- block/Kconfig | 6 -- block/blk-wbt.c | 3 +-- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/block/Kconfig b/block/Kconfig index

Re: [PATCH v2] blktest: remove instances of null_blk queue_mode=1

2018-10-25 Thread Jens Axboe
On 10/25/18 3:08 PM, Omar Sandoval wrote: > On Thu, Oct 25, 2018 at 03:03:30PM -0600, Jens Axboe wrote: >> This is no longer supported in recent kernels, get rid of >> any testing of queue_mode=1. queue_mode=1 tested the legacy >> IO path, which is going away completely. As such, there's >> no poin

[PATCH 02/28] ms_block: convert to blk-mq

2018-10-25 Thread Jens Axboe
Straight forward conversion, room for optimization in how everything is punted to a work queue. Also looks plenty racy all over the map, with the state changes. I fixed a bunch of them up while doing the conversion, but there are surely more. Cc: Maxim Levitsky Signed-off-by: Jens Axboe --- dri

[PATCH 04/28] ide: convert to blk-mq

2018-10-25 Thread Jens Axboe
ide-disk and ide-cd tested as working just fine, ide-tape and ide-floppy haven't. But the latter don't require changes, so they should work without issue. Add helper function to insert a request from a work queue, since we cannot invoke the blk-mq request insertion from IRQ context. Cc: David Mil

[PATCH 10/28] dasd: remove dead code

2018-10-25 Thread Jens Axboe
Since e443343e509a we haven't had a request_fn attached to this driver, hence any code inside an if (q->request_fn) is unreachable. Fixes: e443343e509a ("s390/dasd: blk-mq conversion") [sth: Keep and fix the dasd_info->chanq_len counter.] Reviewed-by: Jan Hoeppner Signed-off-by: Stefan Haberland

[PATCH 05/28] IB/srp: remove old request_fn_active check

2018-10-25 Thread Jens Axboe
This check is only viable for non scsi-mq. Since that is going away, kill this legacy check. Cc: Bart Van Assche Cc: Parav Pandit Cc: linux-s...@vger.kernel.org Signed-off-by: Jens Axboe --- drivers/infiniband/ulp/srp/ib_srp.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/i

[PATCH 01/28] sunvdc: convert to blk-mq

2018-10-25 Thread Jens Axboe
Convert from the old request_fn style driver to blk-mq. Cc: David Miller Signed-off-by: Jens Axboe --- drivers/block/sunvdc.c | 149 +++-- 1 file changed, 98 insertions(+), 51 deletions(-) diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c index b5

[PATCH 06/28] blk-mq: remove the request_list usage

2018-10-25 Thread Jens Axboe
We don't do anything with it, that's just the legacy path. Signed-off-by: Jens Axboe --- block/blk-mq.c | 5 - 1 file changed, 5 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 3f91c6e5b17a..4c82dc44d4d8 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -510,9 +510,6 @@ vo

[PATCH 08/28] scsi: kill off the legacy IO path

2018-10-25 Thread Jens Axboe
Cc: linux-s...@vger.kernel.org Signed-off-by: Jens Axboe --- Documentation/scsi/scsi-parameters.txt | 5 - drivers/scsi/Kconfig | 12 - drivers/scsi/cxlflash/main.c | 6 - drivers/scsi/hosts.c | 29 +- drivers/scsi/lpfc/lpfc_scsi.c |

[PATCH 07/28] blk-mq: remove legacy check in queue blk_freeze_queue()

2018-10-25 Thread Jens Axboe
Signed-off-by: Jens Axboe --- block/blk-mq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 4c82dc44d4d8..a58d2d953876 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -177,8 +177,6 @@ void blk_freeze_queue(struct request_queue *q) * exporte

[PATCHSET 0/28] blk-mq driver conversions and legacy path removal

2018-10-25 Thread Jens Axboe
The first round of this went into 4.20-rc, but we've still some of them pending. This patch series converts the remaining drivers to blk-mq. The ones that support dual paths (like SCSI and DM) have the non-mq path removed. At the end, legacy IO code and schedulers are killed off. This patch series

Re: [PATCH v2] blktest: remove instances of null_blk queue_mode=1

2018-10-25 Thread Omar Sandoval
On Thu, Oct 25, 2018 at 03:03:30PM -0600, Jens Axboe wrote: > This is no longer supported in recent kernels, get rid of > any testing of queue_mode=1. queue_mode=1 tested the legacy > IO path, which is going away completely. As such, there's > no point in doing anymore testing with it. > > Signed-

[PATCH v2] blktest: remove instances of null_blk queue_mode=1

2018-10-25 Thread Jens Axboe
This is no longer supported in recent kernels, get rid of any testing of queue_mode=1. queue_mode=1 tested the legacy IO path, which is going away completely. As such, there's no point in doing anymore testing with it. Signed-off-by: Jens Axboe --- Replaces the two previous patches - covers 024

[PATCH] blktest: remove instances of null_blk queue_mode=1

2018-10-25 Thread Jens Axboe
This is no longer supported in recent kernels, get rid of any testing of queue_mode=1. Signed-off-by: Jens Axboe diff --git a/tests/block/017 b/tests/block/017 index 715c4e59c514..cea29beaf062 100755 --- a/tests/block/017 +++ b/tests/block/017 @@ -26,27 +26,23 @@ show_inflight() { test() {

[PATCH] blktests: remove legacy IO path timeout test

2018-10-25 Thread Jens Axboe
This feature is gone from null_blk in the current Linux kernels. It doesn't make sense to keep testing this on older kernels either, as the legacy IO path is going away. Signed-off-by: Jens Axboe diff --git a/tests/block/022 b/tests/block/022 deleted file mode 100755 index 91946cfab6bf..

Re: [PATCH] blk-mq: ensure hctx to be ran on mapped cpu when issue directly

2018-10-25 Thread Jens Axboe
On 10/24/18 9:20 AM, Jianchao Wang wrote: > When issue request directly and the task is migrated out of the > original cpu where it allocates request, hctx could be ran on > the cpu where it is not mapped. To fix this, insert the request > if BLK_MQ_F_BLOCKING is set, check whether the current is m

Bug: swap discard issue with zram caused by "block: don't deal with discard limit in blkdev_issue_discard()"

2018-10-25 Thread Rui Salvaterra
Hi, After commit 744889b7cbb56a64f957e65ade7cb65fe3f35714, I started getting this (-EIO, it seems) on my dmesg: swapon: discard_swap(c275f02d): -5 This is an 8 GB zram swap device. It's configured like this: modprobe zram echo zstd > /sys/block/zram0/comp_algorithm echo 8297508864 > /sy

Re: [PATCH BUGFIX] block, bfq: fix asymmetric scenarios detection

2018-10-25 Thread Jens Axboe
On 10/24/18 11:13 AM, Paolo Valente wrote: > From: Federico Motta > > Since commit 2d29c9f89fcd ("block, bfq: improve asymmetric scenarios > detection"), a scenario is defined asymmetric when one of the > following conditions holds: > - active bfq_queues have different weights > - one or more gro

Re: [PATCH v4 00/11] Zoned block device support improvements

2018-10-25 Thread Jens Axboe
On 10/24/18 10:04 AM, Bart Van Assche wrote: > On Wed, 2018-10-24 at 11:37 -0400, Martin K. Petersen wrote: >> Mike, >> You keep mentioning this, but I don't recall ever seeing anything to that effect. The rest of the kernel appears to be either arbitrary ordering or favoring author

Re: [PATCH] lightnvm: pblk: ignore the smeta oob area scan

2018-10-25 Thread Hans Holmberg
On Thu, Oct 25, 2018 at 2:44 AM Zhoujie Wu wrote: > > The smeta area l2p mapping is empty, and actually the > recovery procedure only need to restore data sector's l2p > mapping. So ignore the smeta oob scan. > > Signed-off-by: Zhoujie Wu > --- > drivers/lightnvm/pblk-recovery.c | 5 +++-- > 1 f

Submit Proposals to the 2019 Linux Storage and Filesystems Conference!

2018-10-25 Thread Christoph Hellwig
After a one-year hiatus, the Linux Storage and Filesystems Conference (Vault) returns in 2019, under the sponsorship and organization of the USENIX Association. Vault brings together practitioners, implementers, users, and researchers working on storage in open source and related projects. We w

Re: [PATCH BUGFIX] block, bfq: fix asymmetric scenarios detection

2018-10-25 Thread Oleksandr Natalenko
Hi. On 24.10.2018 19:13, Paolo Valente wrote: From: Federico Motta Since commit 2d29c9f89fcd ("block, bfq: improve asymmetric scenarios detection"), a scenario is defined asymmetric when one of the following conditions holds: - active bfq_queues have different weights - one or more group of en