From: Ming Lei
[ Upstream commit 153fcd5f6d93b8e1e4040b1337f564a10f8d93af ]
brd_free() may be called in failure path on one brd instance which
disk isn't added yet, so release handler of gendisk may free the
associated request_queue early and causes the following use-after-free[1].
This patch f
From: Ming Lei
[ Upstream commit 153fcd5f6d93b8e1e4040b1337f564a10f8d93af ]
brd_free() may be called in failure path on one brd instance which
disk isn't added yet, so release handler of gendisk may free the
associated request_queue early and causes the following use-after-free[1].
This patch f
Hi Jens
On 11/13/18 11:22 AM, Jens Axboe wrote:
> On 11/12/18 2:23 AM, Jianchao Wang wrote:
>> Merge blk_mq_try_issue_directly and __blk_mq_try_issue_directly
>> into one interface to unify the interfaces to issue requests
>> directly. The merged interface takes over the requests totally,
>> it co
On 11/12/18 2:23 AM, Jianchao Wang wrote:
> Merge blk_mq_try_issue_directly and __blk_mq_try_issue_directly
> into one interface to unify the interfaces to issue requests
> directly. The merged interface takes over the requests totally,
> it could insert, end or do nothing based on the return value
Hi Jens
On 11/13/18 1:10 AM, Jens Axboe wrote:
> On 11/12/18 2:23 AM, Jianchao Wang wrote:
>> Make __blk_mq_issue_directly be able to accept a NULL cookie pointer
>> and remove the dummy unused_cookie in blk_mq_request_issue_directly.
>
> What's the reasoning behind this? Seems faster to store th
Hi Jens
On 11/13/18 12:26 AM, Jens Axboe wrote:
> On 11/12/18 2:35 AM, jianchao.wang wrote:
>> Hi Jens
>>
>> On 11/10/18 11:13 PM, Jens Axboe wrote:
>>> We only really need the barrier if we're going to be sleeping,
>>> if we're just polling we're fine with the __set_current_state()
>>> variant.
>
On Mon, Nov 12, 2018 at 04:28:40AM -0800, Greg Kroah-Hartman wrote:
> On Mon, Nov 12, 2018 at 10:56:21AM +0100, Paolo Valente wrote:
> > From: Angelo Ruocco
> >
> > The kernfs pseudo file system doesn't export any function to only find
> > a node by name, without also getting a reference on it.
>
On Tue, Nov 13, 2018 at 08:22:26AM +0800, Ming Lei wrote:
> On Mon, Nov 12, 2018 at 12:02:36PM -0800, Greg Kroah-Hartman wrote:
> > On Mon, Nov 12, 2018 at 08:48:48AM -0800, Guenter Roeck wrote:
> > > On Mon, Nov 12, 2018 at 05:44:07PM +0800, Ming Lei wrote:
> > > > On Mon, Nov 12, 2018 at 05:20:51
On Mon, Nov 12, 2018 at 12:02:36PM -0800, Greg Kroah-Hartman wrote:
> On Mon, Nov 12, 2018 at 08:48:48AM -0800, Guenter Roeck wrote:
> > On Mon, Nov 12, 2018 at 05:44:07PM +0800, Ming Lei wrote:
> > > On Mon, Nov 12, 2018 at 05:20:51PM +0800, Ming Lei wrote:
> > > > On Fri, Nov 09, 2018 at 12:35:18
On Mon, Nov 12, 2018 at 08:48:48AM -0800, Guenter Roeck wrote:
> On Mon, Nov 12, 2018 at 05:44:07PM +0800, Ming Lei wrote:
> > On Mon, Nov 12, 2018 at 05:20:51PM +0800, Ming Lei wrote:
> > > On Fri, Nov 09, 2018 at 12:35:18PM -0800, Guenter Roeck wrote:
> > > > Hi,
> > > >
> > > > Images with CONF
On 11/12/18 2:29 AM, Jean Delvare wrote:
> From: Hannes Reinecke
>
> We need to copy the io priority, too; otherwise the clone will run
> with a different priority than the original one.
Applied, thanks.
--
Jens Axboe
On 11/12/18 2:23 AM, Jianchao Wang wrote:
> Make __blk_mq_issue_directly be able to accept a NULL cookie pointer
> and remove the dummy unused_cookie in blk_mq_request_issue_directly.
What's the reasoning behind this? Seems faster to store the cookie
always, instead of introducing a branch to the
On Mon, Nov 12, 2018 at 05:44:07PM +0800, Ming Lei wrote:
> On Mon, Nov 12, 2018 at 05:20:51PM +0800, Ming Lei wrote:
> > On Fri, Nov 09, 2018 at 12:35:18PM -0800, Guenter Roeck wrote:
> > > Hi,
> > >
> > > Images with CONFIG_DEBUG_KOBJECT=y, CONFIG_DEBUG_KOBJECT_RELEASE=y
> > > enabled report kob
On 11/12/18 2:35 AM, jianchao.wang wrote:
> Hi Jens
>
> On 11/10/18 11:13 PM, Jens Axboe wrote:
>> We only really need the barrier if we're going to be sleeping,
>> if we're just polling we're fine with the __set_current_state()
>> variant.
>>
>> Signed-off-by: Jens Axboe
>> ---
>> fs/block_dev.
On Mon, Nov 12, 2018 at 05:20:52PM +0800, Ming Lei wrote:
> On Fri, Nov 09, 2018 at 12:35:18PM -0800, Guenter Roeck wrote:
> > Hi,
> >
> > Images with CONFIG_DEBUG_KOBJECT=y, CONFIG_DEBUG_KOBJECT_RELEASE=y
> > enabled report kobject lifetime issues when booting an image in qemu
> > using virtio-sc
On 11/12/18 8:54 AM, Josef Bacik wrote:
> On Mon, Nov 12, 2018 at 08:48:35AM -0700, Jens Axboe wrote:
>> On 11/12/18 8:45 AM, Paolo Valente wrote:
>>> BTW, since this patch series is probably even more useful for older
>>> than for future kernels, might it make sense to also propose it for
>>> stab
On Mon, Nov 12, 2018 at 08:48:35AM -0700, Jens Axboe wrote:
> On 11/12/18 8:45 AM, Paolo Valente wrote:
> > BTW, since this patch series is probably even more useful for older
> > than for future kernels, might it make sense to also propose it for
> > stable/longterm kernels (provided that such a p
On 11/12/18 8:45 AM, Paolo Valente wrote:
> BTW, since this patch series is probably even more useful for older
> than for future kernels, might it make sense to also propose it for
> stable/longterm kernels (provided that such a possibility exists)?
That just not how things work, we don't put dif
> Il giorno 12 nov 2018, alle ore 16:35, Jens Axboe ha
> scritto:
>
> On 11/12/18 3:17 AM, Paolo Valente wrote:
>>
>>
>>> Il giorno 12 nov 2018, alle ore 11:00, Oleksandr Natalenko
>>> ha scritto:
>>>
>>> On 12.11.2018 10:56, Paolo Valente wrote:
Hi Jens, Tejun, all,
about nine
On 11/12/18 3:17 AM, Paolo Valente wrote:
>
>
>> Il giorno 12 nov 2018, alle ore 11:00, Oleksandr Natalenko
>> ha scritto:
>>
>> On 12.11.2018 10:56, Paolo Valente wrote:
>>> Hi Jens, Tejun, all,
>>> about nine months ago, we agreed on a solution for unifying the
>>> interface of the proportion
On 11/12/18 1:08 AM, Omar Sandoval wrote:
> From: Omar Sandoval
>
> When copying to the latency type, we should be passing LATENCY_TYPE_LEN,
> not DOMAIN_LEN (this isn't a problem in practice because we only pass
> "total" or "I/O"). Fix it by changing all of the strlcpy() calls to use
> sizeof()
On Monday, November 12, 2018 9:08 AM, Omar Sandoval wrote:
> From: Omar Sandoval osan...@fb.com
>
> When copying to the latency type, we should be passing LATENCY_TYPE_LEN,
> not DOMAIN_LEN (this isn't a problem in practice because we only pass
> "total" or "I/O"). Fix it by changing all of the s
On Mon, Nov 12, 2018 at 10:56:21AM +0100, Paolo Valente wrote:
> From: Angelo Ruocco
>
> The kernfs pseudo file system doesn't export any function to only find
> a node by name, without also getting a reference on it.
> But in some cases it is useful to just locate a kernfs node, while
> using it
On 11/12/2018 02:13 PM, Hans Verkuil wrote:
> On 11/12/2018 03:41 AM, Anshuman Khandual wrote:
>> At present there are multiple places where invalid node number is encoded
>> as -1. Even though implicitly understood it is always better to have macros
>> in there. Replace these open encodings for
On Sat 10-11-18 17:09:09, Tetsuo Handa wrote:
> From 4b9e5556fada37dff1eff13665a229b69e1f7dd8 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa
> Date: Sat, 10 Nov 2018 17:04:40 +0900
> Subject: [PATCH] loop: Fix double mutex_unlock(&loop_ctl_mutex) in
> loop_control_ioctl().
>
> Commit 0a42e99b58a2
> Il giorno 12 nov 2018, alle ore 11:00, Oleksandr Natalenko
> ha scritto:
>
> On 12.11.2018 10:56, Paolo Valente wrote:
>> Hi Jens, Tejun, all,
>> about nine months ago, we agreed on a solution for unifying the
>> interface of the proportional-share policy in blkio/io [1]. Angelo
>> and I f
On Thu 08-11-18 16:28:11, Theodore Y. Ts'o wrote:
> On Thu, Nov 08, 2018 at 02:01:00PM +0100, Jan Kara wrote:
> > Hi,
> >
> > this patch series fixes oops and possible deadlocks as reported by syzbot
> > [1]
> > [2]. The second patch in the series (from Tetsuo) fixes the oops, the
> > remaining
On 12.11.2018 11:00, Oleksandr Natalenko wrote:
I thought all the legacy stuff including CFS et al. is going to be
removed in v4.21 completely…
Paolo, [1] and [2].
[1] http://git.kernel.dk/cgit/linux-block/log/?h=for-4.21/block
[2]
http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.21/bloc
On 12.11.2018 10:56, Paolo Valente wrote:
Hi Jens, Tejun, all,
about nine months ago, we agreed on a solution for unifying the
interface of the proportional-share policy in blkio/io [1]. Angelo
and I finally completed it. Let me briefly recall the problem and the
solution.
The current implemen
From: Angelo Ruocco
The kernfs pseudo file system doesn't export any function to only find
a node by name, without also getting a reference on it.
But in some cases it is useful to just locate a kernfs node, while
using it or not depends on some other condition.
This commit adds a function to ju
From: Angelo Ruocco
The I/O schedulers bfq and cfq expose a cgroup attribute with the same
meaning: weight.
This commit changes bfq default and min weights to match the ones set
by cfq.
Signed-off-by: Angelo Ruocco
Signed-off-by: Paolo Valente
---
block/bfq-iosched.h | 4 ++--
1 file changed
From: Angelo Ruocco
When two or more policies share a file their respective cftypes are
linked together. The allowed operations on those files are: open,
release, write and show, mapped to the functions defined in the
cftypes.
This commit makes the cgroup core invoke, whenever one of those
opera
Forgot to CC Lennart, sorry.
> Il giorno 12 nov 2018, alle ore 10:56, Paolo Valente
> ha scritto:
>
> Hi Jens, Tejun, all,
> about nine months ago, we agreed on a solution for unifying the
> interface of the proportional-share policy in blkio/io [1]. Angelo
> and I finally completed it. Let m
From: Angelo Ruocco
The piece of information "who created a certain cftype" is not stored
anywhere, thus a cftype is not able to know who is its owner.
This commit addresses this problem by adding a new field in the cftype
structure that enables the name of its owner to be explicitly set.
Signe
Hi Jens, Tejun, all,
about nine months ago, we agreed on a solution for unifying the
interface of the proportional-share policy in blkio/io [1]. Angelo
and I finally completed it. Let me briefly recall the problem and the
solution.
The current implementation of cgroups doesn't allow two or more
From: Angelo Ruocco
Some of the files exposed in a cgroup by cfq have the same meaning as
the files exposed by bfq and throttle.
This commit allows these files to be shared.
Signed-off-by: Angelo Ruocco
Signed-off-by: Paolo Valente
---
block/cfq-iosched.c | 49 +++
Some of the files exposed in a cgroup by bfq, for the proportional
share policy, have the same meaning as the files owned by cfq.
The old implementation of the cgroup interface didn't allow different
entities to create cgroup files with the same name (in the same
subsystem). So, for bfq, we had to
BFQ now shares interface files with CFQ, for the proportional-share
policy. Make documentation consistent with that.
Signed-off-by: Paolo Valente
---
Documentation/block/bfq-iosched.txt | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/Documentation/
The current implementation of the seq_show hook in the cftype struct
has only, as parameters, the seq_file to write to and the arguments
passed by the command line. Thus, the only way to retrieve the cftype
that owns an instance of such hook function is by using the accessor
in the seq_file itself.
This commit fixes a few clerical errors in
Documentation/block/bfq-iosched.txt.
Signed-off-by: Paolo Valente
---
Documentation/block/bfq-iosched.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/block/bfq-iosched.txt
b/Documentation/block/bfq-iosched.tx
Some seq_show functions need to access the cftype they belong to, for
retrieving the data to show. These functions get their cftype by using
the seq_cft accessor for the seq_file. This solution is no longer
viable in case a seq_file is shared among more than one cftype,
because the accessor always
From: Angelo Ruocco
Some of the cgroup files defined in the throttle policy have the same
meaning as those defined in the proportional share policy.
This commit uses the new file sharing interface in cgroup to share
these files.
Signed-off-by: Angelo Ruocco
Signed-off-by: Paolo Valente
---
b
From: Angelo Ruocco
When a cgroup policy is activated, it creates its files in its
subsystem directory. Two policies are not able to create a file with
the same name: if a policy tries to create a file that has the same
name as a file created by another policy, the cgroup core stops it,
warns the
On Mon, Nov 12, 2018 at 05:20:51PM +0800, Ming Lei wrote:
> On Fri, Nov 09, 2018 at 12:35:18PM -0800, Guenter Roeck wrote:
> > Hi,
> >
> > Images with CONFIG_DEBUG_KOBJECT=y, CONFIG_DEBUG_KOBJECT_RELEASE=y
> > enabled report kobject lifetime issues when booting an image in qemu
> > using virtio-sc
Hi,friend,
This is Daniel Murray and i am from Sinara Group Co.Ltd Group Co.,LTD in Russia.
We are glad to know about your company from the web and we are interested in
your products.
Could you kindly send us your Latest catalog and price list for our trial order.
Best Regards,
Daniel Murray
Hi Jens
On 11/10/18 11:13 PM, Jens Axboe wrote:
> We only really need the barrier if we're going to be sleeping,
> if we're just polling we're fine with the __set_current_state()
> variant.
>
> Signed-off-by: Jens Axboe
> ---
> fs/block_dev.c | 25 +
> 1 file changed, 21
From: Hannes Reinecke
We need to copy the io priority, too; otherwise the clone will run
with a different priority than the original one.
Fixes: 43b62ce3ff0a ("block: move bio io prio to a new field")
Signed-off-by: Hannes Reinecke
Signed-off-by: Jean Delvare
---
Changes since v2:
* Rebased o
When try to issue request directly, if the queue is stopped or
quiesced, 'bypass' will be ignored and return BLK_STS_OK to caller
to avoid it dispatch request again. Then the request will be
inserted with blk_mq_sched_insert_request. This is not correct
for dm-rq case where we should avoid to pass
Merge blk_mq_try_issue_directly and __blk_mq_try_issue_directly
into one interface to unify the interfaces to issue requests
directly. The merged interface takes over the requests totally,
it could insert, end or do nothing based on the return value of
.queue_rq and 'bypass' parameter. Then caller
Replace blk_mq_request_issue_directly with blk_mq_try_issue_directly
in blk_insert_cloned_request and remove blk_mq_request_issue_directly
as nobody uses it.
Signed-off-by: Jianchao Wang
---
block/blk-core.c | 2 +-
block/blk-mq.c | 7 +--
block/blk-mq.h | 6 --
3 files changed, 6 in
Make __blk_mq_issue_directly be able to accept a NULL cookie pointer
and remove the dummy unused_cookie in blk_mq_request_issue_directly.
Signed-off-by: Jianchao Wang
---
block/blk-mq.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-m
When issue request directly and the task is migrated out of the
original cpu where it allocates request, hctx could be ran on
the cpu where it is not mapped.
To fix this,
- insert the request forcibly if BLK_MQ_F_BLOCKING is set.
- check whether the current is mapped to the hctx, if not, insert
It is not necessary to issue request directly with bypass 'true'
in blk_mq_sched_insert_requests and insert the non-issued requests
itself. Just set bypass to 'false' and let blk_mq_try_issue_directly
handle them totally.
Signed-off-by: Jianchao Wang
---
block/blk-mq-sched.c | 8 +++-
block
Hi Jens
Please consider this patchset for 4.21.
It refactors the code of issue request directly to unify the interface
and make the code clearer and more readable, and also fixes two defects
there.
The 1st patch make __blk_mq_issue_directly be able to accept NULL cookie
pointer then we needn't th
On Fri, Nov 09, 2018 at 12:35:18PM -0800, Guenter Roeck wrote:
> Hi,
>
> Images with CONFIG_DEBUG_KOBJECT=y, CONFIG_DEBUG_KOBJECT_RELEASE=y
> enabled report kobject lifetime issues when booting an image in qemu
> using virtio-scsi-pci.
>
> Bisect points to two different commits, depending on the
On 11/12/2018 03:41 AM, Anshuman Khandual wrote:
> At present there are multiple places where invalid node number is encoded
> as -1. Even though implicitly understood it is always better to have macros
> in there. Replace these open encodings for an invalid node number with the
> global macro NUMA
From: Omar Sandoval
When copying to the latency type, we should be passing LATENCY_TYPE_LEN,
not DOMAIN_LEN (this isn't a problem in practice because we only pass
"total" or "I/O"). Fix it by changing all of the strlcpy() calls to use
sizeof().
Fixes: 6c3b7af1c975 ("kyber: add tracepoints")
Repo
Hi,
the following command line
sudo fio --loops=20 --name=seqreader -rw=read --size=500M --numjobs=1
--filename=/dev/md0 & iostat -tmd /dev/md0 2 & sleep 15 ; killall iostat
generates a sequence of lines like this one:
--
8.11.2018 14:08:351)][15.4%][r=444MiB/s][r=114k IOPS][et
58 matches
Mail list logo
