Re: [PATCH] bfq: Fix bfq linkage error

2019-09-15 Thread Fam Zheng
On Sat, 09/14 11:32, Jens Axboe wrote: > On 9/14/19 11:31 AM, Pavel Begunkov (Silence) wrote: > > From: Pavel Begunkov > > > > Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses > > blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it > > causes linkage err

Re: [PATCH v4 15/25] ibnbd: private headers with IBNBD protocol structs and helpers

2019-09-15 Thread Leon Romanovsky
On Sun, Sep 15, 2019 at 04:30:04PM +0200, Jinpu Wang wrote: > Thanks Bart for detailed review, reply inline. > > On Sat, Sep 14, 2019 at 12:10 AM Bart Van Assche wrote: > > > > On 6/20/19 8:03 AM, Jack Wang wrote: > > > +#define ibnbd_log(fn, dev, fmt, ...) ({ \ > > >

Re: [PATCH] block: fix null pointer dereference in blk_mq_rq_timed_out()

2019-09-15 Thread Yufen Yu
On 2019/9/12 18:07, Ming Lei wrote: On Thu, Sep 12, 2019 at 04:49:15PM +0800, Yufen Yu wrote: On 2019/9/12 12:16, Ming Lei wrote: On Thu, Sep 12, 2019 at 11:29:18AM +0800, Yufen Yu wrote: On 2019/9/12 10:46, Ming Lei wrote: On Sat, Sep 07, 2019 at 06:24:50PM +0800, Yufen Yu wrote: There

[PATCHv2 1/2] blk-mq: Avoid memory reclaim when allocating request map

2019-09-15 Thread xiubli
From: Xiubo Li For some storage drivers, such as the nbd, when there has new socket connections added, it will update the hardware queue number by calling blk_mq_update_nr_hw_queues(), in which it will freeze all the queues first. And then tries to do the hardware queue updating stuff. But int b

[PATCHv2 0/2] blk-mq: Avoid memory reclaim when allocating request map

2019-09-15 Thread xiubli
From: Xiubo Li To make the patch more readable and cleaner I just split them into 2 small ones to address the issue from @Ming Lei, thanks very much. Changed in V2: - Addressed the comment from Ming Lei, thanks. Xiubo Li (2): blk-mq: Avoid memory reclaim when allocating request map blk-mq:

[PATCHv2 2/2] blk-mq: use BLK_MQ_GFP_FLAGS macro instead

2019-09-15 Thread xiubli
From: Xiubo Li There at least 6 places are using the same combined GFP flags, switch them to one macro instead to make the code get cleaner. Signed-off-by: Xiubo Li Reviewed-by: Ming Lei --- block/blk-mq.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/bl

Re: [PATCH 0/5] block: loop: add file format subsystem and QCOW2 file format driver

2019-09-15 Thread Ming Lei
On Fri, Sep 13, 2019 at 01:57:33PM +0200, Manuel Bentele wrote: > Hi Ming, > > On 9/12/19 4:24 AM, Ming Lei wrote: > > On Sat, Aug 24, 2019 at 12:56:14AM +0200, developm...@manuel-bentele.de > > wrote: > >> From: Manuel Bentele > >> > >> Hi > >> > >> Regarding to the following discussion [1] on

Re: [RFC PATCH] blk-mq: Avoid memory reclaim when allocating request map

2019-09-15 Thread Xiubo Li
On 2019/9/16 9:49, Ming Lei wrote: On Sun, Sep 15, 2019 at 05:56:56PM +0530, xiu...@redhat.com wrote: From: Xiubo Li For some storage drivers, such as the nbd, when there has new socket connections added, it will update the hardware queue number by calling blk_mq_update_nr_hw_queues(), in whic

Re: [RFC PATCH] blk-mq: Avoid memory reclaim when allocating request map

2019-09-15 Thread Ming Lei
On Sun, Sep 15, 2019 at 05:56:56PM +0530, xiu...@redhat.com wrote: > From: Xiubo Li > > For some storage drivers, such as the nbd, when there has new socket > connections added, it will update the hardware queue number by calling > blk_mq_update_nr_hw_queues(), in which it will freeze all the que

[GIT PULL] libata changes for 5.4

2019-09-15 Thread Jens Axboe
Hi Linus, Here are the libata changes for 5.4. This pull request contains: - Kill unused export (Andy) - Use dma_set_mask_and_coherent() throughout (Christoph) - Drop PCS quirk on Denverton, which has different register layout (Dan) - Support non-boot time detection for pata_buddha (Max) Plea

[GIT PULL] io_uring changes for 5.4

2019-09-15 Thread Jens Axboe
Hi Linus, Here are the changes for io_uring for 5.4. This pull request contains: - Allocate SQ/CQ ring together, more efficient. Expose this through a feature flag as well, so we can reduce the number of mmaps by 1. (Hristo and me. - Fix for sequence logic with SQ thread (Jackie). - Add sup

Re: [PATCH 0/2] fixes for block stats

2019-09-15 Thread Jens Axboe
On 5/24/19 11:12 PM, Hou Tao wrote: > ping ? Applied, thanks. -- Jens Axboe

Re: [PATCH 1/2] block: make rq sector size accessible for block stats

2019-09-15 Thread Pavel Begunkov
Hi, Works well for me Tested-by: Pavel Begunkov Yet, take a look at the comment below. By the way, Fixes: 795fe54c2a828099e ("block: move blk_stat_add() to __blk_mq_end_request()") On 21/05/2019 10:59, Hou Tao wrote: > +++ b/include/linux/blkdev.h > @@ -202,9 +202,12 @@ struct request { > #i

Re: [PATCH v4 15/25] ibnbd: private headers with IBNBD protocol structs and helpers

2019-09-15 Thread Jinpu Wang
Thanks Bart for detailed review, reply inline. On Sat, Sep 14, 2019 at 12:10 AM Bart Van Assche wrote: > > On 6/20/19 8:03 AM, Jack Wang wrote: > > +#define ibnbd_log(fn, dev, fmt, ...) ({ \ > > + __builtin_choose_expr( \ >

[RFC PATCH] blk-mq: Avoid memory reclaim when allocating request map

2019-09-15 Thread xiubli
From: Xiubo Li For some storage drivers, such as the nbd, when there has new socket connections added, it will update the hardware queue number by calling blk_mq_update_nr_hw_queues(), in which it will freeze all the queues first. And then tries to do the hardware queue updating stuff. But int b