On Mon, 08 Jul 2024 09:16:46 +, John Garry wrote:
> This series adds validation of the logical block size in
> blk_validate_limits().
>
> Some drivers had already been validating this themselves. As such, we can
> mostly drop that driver validation.
>
> nbd is problematic, as we cannot only
On 7/8/24 18:16, John Garry wrote:
> The block queue limits validation does this for us now.
>
> The loop_configure() -> WARN_ON_ONCE() call is dropped, as an invalid
> block size would trigger this now. We don't want userspace to be able to
> directly trigger WARNs.
>
> Reviewed-by: Christoph He
On 7/8/24 18:16, John Garry wrote:
> The block queue limits validation does this for us now.
>
> Reviewed-by: Christoph Hellwig
> Acked-by: Michael S. Tsirkin
> Reviewed-by: Stefan Hajnoczi
> Signed-off-by: John Garry
> ---
> drivers/block/virtio_blk.c | 11 +--
> 1 file changed, 1 in
On 7/8/24 18:16, John Garry wrote:
> The block queue limits validation does this for us now.
>
> Reviewed-by: Christoph Hellwig
> Signed-off-by: John Garry
Reviewed-by: Damien Le Moal
--
Damien Le Moal
Western Digital Research
On 7/8/24 18:16, John Garry wrote:
> Some drivers validate that their own logical block size. It is no harm to
> always do this, so validate in blk_validate_limits().
>
> This allows us to remove the validation in most of those drivers.
>
> Add a comment to blk_validate_block_size() to inform use
在 2024/7/8 11:16, John Garry 写道:
The block queue limits validation does this for us now.
Reviewed-by: Christoph Hellwig
Signed-off-by: John Garry
---
drivers/block/null_blk/main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/ma
The block queue limits validation does this for us now.
The loop_configure() -> WARN_ON_ONCE() call is dropped, as an invalid
block size would trigger this now. We don't want userspace to be able to
directly trigger WARNs.
Reviewed-by: Christoph Hellwig
Signed-off-by: John Garry
---
drivers/bl
The block queue limits validation does this for us now.
Reviewed-by: Christoph Hellwig
Acked-by: Michael S. Tsirkin
Reviewed-by: Stefan Hajnoczi
Signed-off-by: John Garry
---
drivers/block/virtio_blk.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/blo
The block queue limits validation does this for us now.
Reviewed-by: Christoph Hellwig
Signed-off-by: John Garry
---
drivers/block/null_blk/main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index 9d0f6da77601..2f0431e42c49
Some drivers validate that their own logical block size. It is no harm to
always do this, so validate in blk_validate_limits().
This allows us to remove the validation in most of those drivers.
Add a comment to blk_validate_block_size() to inform users that self-
validation of LBS is usually unne
If we fail to read a logical block size in virtblk_read_limits() ->
virtio_cread_feature(), then we default to what is in
lim->logical_block_size, but that would be 0.
We can deal with lim->logical_block_size = 0 later in the
blk_mq_alloc_disk(), but the code in virtblk_read_limits() needs a prope
This series adds validation of the logical block size in
blk_validate_limits().
Some drivers had already been validating this themselves. As such, we can
mostly drop that driver validation.
nbd is problematic, as we cannot only change to just stop calling
blk_validate_limits(). This is because th
On Fri, Jul 05, 2024 at 11:51:26AM +, John Garry wrote:
> The block queue limits validation does this for us now.
>
> Signed-off-by: John Garry
> ---
> drivers/block/virtio_blk.c | 11 +--
> 1 file changed, 1 insertion(+), 10 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.as
On Fri, Jul 05, 2024 at 11:51:23AM +, John Garry wrote:
> If we fail to read a logical block size in virtblk_read_limits() ->
> virtio_cread_feature(), then we default to what is in
> lim->logical_block_size, but that would be 0.
>
> We can deal with lim->logical_block_size = 0 later in the
>
14 matches
Mail list logo
