this patch does not change any functionality.
Signed-off-by: Bart Van Assche
Reviewed-by: Martin K. Petersen
Acked-by: Martin K. Petersen
Cc: Martin K. Petersen
Cc: Mike Snitzer
Cc: Shaohua Li
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
---
block/bsg
This patch helps to avoid that new code gets introduced in block drivers
that manipulates queue flags without holding the queue lock when that
lock should be held.
Signed-off-by: Bart Van Assche
Reviewed-by: Johannes Thumshirn
Reviewed-by: Martin K. Petersen
Cc: Christoph Hellwig
Cc: Hannes
Introduce functions that modify the queue flags and that protect
these modifications with the request queue lock. Except for moving
one wake_up_all() call from inside to outside a critical section,
this patch does not change any functionality.
Signed-off-by: Bart Van Assche
Reviewed-by: Johannes
Since it is not safe to use queue_flag_(set|clear)_unlocked()
without holding the queue lock after the sysfs entries for a
queue have been created, complain if this happens.
Signed-off-by: Bart Van Assche
Reviewed-by: Johannes Thumshirn
Reviewed-by: Martin K. Petersen
Cc: Mike Snitzer
Cc
Use the blk_queue_flag_{set,clear}() functions instead of open-coding
these.
Signed-off-by: Bart Van Assche
Reviewed-by: Michael Lyle
Reviewed-by: Johannes Thumshirn
Reviewed-by: Martin K. Petersen
Cc: Kent Overstreet
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Ming Lei
---
drivers/md
Use the blk_queue_flag_*() functions instead of open-coding these.
Signed-off-by: Bart Van Assche
Reviewed-by: Johannes Thumshirn
Reviewed-by: Martin K. Petersen
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Ming Lei
---
drivers/block/mtip32xx/mtip32xx.c | 8
1 file changed, 4
Except for changing the atomic queue flag manipulations that are
protected by the queue lock into non-atomic manipulations, this
patch does not change any functionality.
Signed-off-by: Bart Van Assche
Reviewed-by: Johannes Thumshirn
Reviewed-by: Martin K. Petersen
Cc: Christoph Hellwig
Cc
Since the queue flags may be changed concurrently from multiple
contexts after a queue becomes visible in sysfs, make these changes
safe by protecting these with the queue lock.
Signed-off-by: Bart Van Assche
Reviewed-by: Martin K. Petersen
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc
Use blk_queue_flag_set() instead of open-coding this function.
Signed-off-by: Bart Van Assche
Reviewed-by: Johannes Thumshirn
Reviewed-by: Martin K. Petersen
Cc: Nicholas A. Bellinger
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Ming Lei
---
drivers/target/loopback/tcm_loop.c | 2 +-
1
On Fri, 2018-03-02 at 18:09 -0500, Martin K. Petersen wrote:
> s/manipulaton/manipulation/ in Subject. Otherwise OK.
Will fix that typo. Thanks for the reviewing work!
Bart.
On Mon, 2018-03-05 at 10:44 +0100, Jean-Louis Dupond wrote:
> Maby a long shot, but could it be fixed by
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/drivers/block/loop.c?h=v4.9.86&id=56bc086358cac1a2949783646eabd57447b9d672
>
> ?
> Or shouldn't that fix such
On Sat, 2018-03-03 at 10:24 +0800, Ming Lei wrote:
> struct nullb_page {
> struct page *page;
> - unsigned long bitmap;
> + unsigned long bitmap[DIV_ROUND_UP(MAP_SZ, sizeof(unsigned long) * 8)];
> };
Could DECLARE_BITMAP() have been used here?
Thanks,
Bart.
On Sun, 2018-03-04 at 20:01 +0100, Jean-Louis Dupond wrote:
> I'm running indeed CentOS 6 with the Virt SIG kernels. Already updated
> to 4.9.75, but recently hit the problem again.
>
> The first PID that was in D-state (root 27157 0.0 0.0 127664 5196
> ?D06:19 0:00 \_ vgdi
On Wed, 2018-02-28 at 14:17 +0800, chenxiang (M) wrote:
> It seems the patch is for block mq, but the issue i encount is under
> block legacy as CONFIG_SCSI_MQ_DEFAULT is not enabled.
Since the call traces refer to the ATA code I hope that an ATA expert will
have the time to help you further.
Ba
Avoid that building with W=1 causes the kernel-doc tool to complain
about undocumented function arguments for the blk-zoned.c source file.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Damien Le Moal
---
block/blk-zoned.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
On Thu, 2018-03-01 at 09:51 +0100, Johannes Thumshirn wrote:
> On Wed, Feb 28, 2018 at 11:28:16AM -0800, Bart Van Assche wrote:
> > static bool blk_poll_stats_enable(struct request_queue *q)
> > {
> > - if (test_bit(QUEUE_FLAG_POLL_STATS, &q->queue_flags) ||
On Fri, 2018-02-16 at 08:39 +0100, Paolo Valente wrote:
> after enabling the listing options in your list, and a few other
> related options, such iblock support, I get this:
>
> $ sudo ./run_tests -c -d -r 10 -t 02-mq -e bfq
> Unloaded the ib_srpt kernel module
> Unloaded the rdma_rxe kernel modu
Use the blk_queue_flag_*() functions instead of open-coding these.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
---
drivers/block/mtip32xx/mtip32xx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
kernel v4.17.
Note: it may be a good idea to postpone patch 11 until after the kernel v4.17
merge window to avoid merge conflicts.
Thanks,
Bart.
Bart Van Assche (11):
block: Reorder the queue flag manipulaton function definitions
block: Use the queue_flag_*() functions instead of open-coding
Since the queue flags may be changed concurrently from multiple
contexts after a queue becomes visible in sysfs, make these changes
safe by protecting these with the queue lock.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
Move the definition of queue_flag_clear_unlocked() up and move the
definition of queue_in_flight() down such that all queue flag
manipulation function definitions become contiguous.
This patch does not change any functionality.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Hannes
Except for changing the atomic queue flag manipulations that are
protected by the queue lock into non-atomic manipulations, this
patch does not change any functionality.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
---
block
Introduce functions that modify the queue flags and that protect
these modifications with the request queue lock. Except for moving
one wake_up_all() call from inside to outside a critical section,
this patch does not change any functionality.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Since it is not safe to use queue_flag_(set|clear)_unlocked()
without holding the queue lock after the sysfs entries for a
queue have been created, complain if this happens.
Signed-off-by: Bart Van Assche
Cc: Mike Snitzer
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc
Use blk_queue_flag_set() instead of open-coding this function.
Signed-off-by: Bart Van Assche
Cc: Nicholas A. Bellinger
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
---
drivers/target/loopback/tcm_loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
This patch helps to avoid that new code gets introduced in block drivers
that manipulates queue flags without holding the queue lock when that
lock should be held.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
---
block/blk.h
Use the blk_queue_flag_{set,clear}() functions instead of open-coding
these.
Signed-off-by: Bart Van Assche
Cc: Michael Lyle
Cc: Kent Overstreet
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
---
drivers/md/bcache/super.c | 6 +++---
1 file changed, 3
this patch does not change any functionality.
Signed-off-by: Bart Van Assche
Cc: Martin K. Petersen
Cc: Mike Snitzer
Cc: Shaohua Li
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
---
block/bsg-lib.c | 4 ++--
drivers/block/drbd
Use blk_queue_flag_set() instead of open-coding this function.
Signed-off-by: Bart Van Assche
Cc: Martin K. Petersen
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
---
drivers/scsi/iscsi_tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, 2018-02-28 at 11:19 -0700, Jens Axboe wrote:
> Didn't Ming ack the first three?
Hello Jens,
This morning I did what I usually do before I repost a patch series, namely to
look at the replies to individual patches for reviewed-by tags. That's how I
overlooked the following (see also
https
blkcg code and queue
cleanup.
Changes between v1 and v2:
- Split a single patch into two patches.
- Dropped blk_alloc_queue_node2() and modified all block drivers that call
blk_alloc_queue_node().
Bart Van Assche (6):
block/loop: Delete gendisk before cleaning up the request queue
md: Delete
This patch does not change any functionality.
Signed-off-by: Bart Van Assche
Reviewed-by: Joseph Qi
Cc: Christoph Hellwig
Cc: Philipp Reisner
Cc: Ulf Hansson
Cc: Kees Cook
---
block/blk-core.c | 7 ---
block/blk-mq.c| 2 +-
drivers/block/null_blk.c | 3
lock earlier if necessary.
Reported-by: Joseph Qi
Signed-off-by: Bart Van Assche
Reviewed-by: Joseph Qi
Cc: Christoph Hellwig
Cc: Philipp Reisner
Cc: Ulf Hansson
Cc: Kees Cook
---
block/blk-core.c | 24
drivers/block/drbd/drbd_main.c | 3 +--
drivers/bl
reference on a request queue after having called blk_cleanup_queue().
Neither driver accesses any of the removed data structures between its
blk_cleanup_queue() and blk_put_queue() calls.
Reported-by: Joseph Qi
Signed-off-by: Bart Van Assche
Reviewed-by: Joseph Qi
Cc: Jan Kara
---
Remove the disk, partition and bdi sysfs attributes before cleaning up
the request queue associated with the disk.
Signed-off-by: Bart Van Assche
Reviewed-by: Johannes Thumshirn
Reviewed-by: Joseph Qi
Cc: Minchan Kim
Cc: Nitin Gupta
Cc: Sergey Senozhatsky
---
drivers/block/zram/zram_drv.c
Remove the disk, partition and bdi sysfs attributes before cleaning up
the request queue associated with the disk.
Signed-off-by: Bart Van Assche
Reviewed-by: Johannes Thumshirn
Reviewed-by: Joseph Qi
Cc: Josef Bacik
Cc: Shaohua Li
Cc: Omar Sandoval
Cc: Hannes Reinecke
Cc: Ming Lei
Remove the disk, partition and bdi sysfs attributes before cleaning up
the request queue associated with the disk.
Signed-off-by: Bart Van Assche
Reviewed-by: Johannes Thumshirn
Reviewed-by: Joseph Qi
Cc: Shaohua Li
---
drivers/md/md.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
pport")
Signed-off-by: Damien Le Moal
Signed-off-by: Bart Van Assche
[ bvanassche: edited patch description ]
Cc: Hannes Reinecke
Cc: Ming Lei
---
block/mq-deadline.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/block/mq-deadline.c b/block/mq-deadli
this patch series. Please consider this patch series for kernel v4.17.
Thanks,
Bart.
Bart Van Assche (2):
blk-mq-debugfs: Reorder queue show and store methods
blk-mq-debugfs: Show zone locking information
block/blk-mq-debugfs.c | 134 +++--
1 file
Make sure that the queue show and store methods are contiguous and
also that these appear in alphabetical order.
Signed-off-by: Bart Van Assche
Cc: Omar Sandoval
Cc: Damien Le Moal
Cc: Ming Lei
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
---
block/blk-mq-debugfs.c | 130
When debugging the ZBC code in the mq-deadline scheduler it is very
important to know which zones are locked and which zones are not
locked. Hence this patch that exports the zone locking information
through debugfs.
Signed-off-by: Bart Van Assche
Cc: Omar Sandoval
Cc: Damien Le Moal
Cc: Ming
applies to remains locked forever and no further
writes are accepted for that zone.
Fixes: 5700f69178e9 ("mq-deadline: Introduce zone locking support")
Signed-off-by: Damien Le Moal
Signed-off-by: Bart Van Assche
Cc: Hannes Reinecke
Cc: Ming Lei
---
block/mq-deadline.c | 8 ++--
1 fi
On Sat, 2018-02-24 at 20:44 +0800, Ming Lei wrote:
> On Thu, Feb 22, 2018 at 05:08:02PM -0800, Bart Van Assche wrote:
> > Hello Jens,
> >
> > Recently Joseph Qi identified races between the block cgroup code and
> > request
> > queue initialization and cleanup
On Thu, 2018-02-22 at 17:08 -0800, Bart Van Assche wrote:
> Recently Joseph Qi identified races between the block cgroup code and request
> queue initialization and cleanup. This patch series address these races.
> Please
> consider these patches for kernel v4.17.
Hello Jens,
Ca
on to the testing arsenal to ensure that we are handling
> requeue conditions correctly.
>
> This works for queue mode 1 (legacy request_fn based path) and 2 (blk-mq
> path), as there's no good way to do requeue with a bio based driver.
> This is similar to the timeout path.
Reviewed-by: Bart Van Assche
On Tue, 2018-02-27 at 15:09 +0800, chenxiang (M) wrote:
> 在 2018/2/26 23:25, Bart Van Assche 写道:
> > On Mon, 2018-02-26 at 17:37 +0800, chenxiang (M) wrote:
> > > When i have a test on kernel 4.16-rc1, find a issue: running IO on SATA
> > > disk, then disable t
On Mon, 2018-02-26 at 20:04 +0800, Jiufei Xue wrote:
> The vm counters is counted in sectors, so we should do the conversation
> in submit_bio.
>
> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and
> partitions index")
>
> Signed-off-by: Jiufei Xue
> ---
> block/blk-core.c
yway, if you add the following to this patch:
Fixes: bd166ef183c2 ("blk-mq-sched: add framework for MQ capable IO schedulers")
Cc: sta...@vger.kernel.org
then you can also add:
Reviewed-by: Bart Van Assche
On Sat, 2018-02-10 at 08:46 +0800, Ming Lei wrote:
> The 'lend' parameter of truncate_inode_pages_range is required to be
> inclusive, so follow the rule.
>
> This patch fixes one memory corruption triggered by discard.
Reviewed-by: Bart Van Assche
On Sat, 2018-02-24 at 00:26 +0800, Ming Lei wrote:
> The following 2 patch fixes one IO hang on kyber in my test on USB, could
> you test it and see if your case can be fixed?
>
> https://marc.info/?l=linux-block&m=151940022831994&w=2
These two patches are sufficient to make my test pass.
stable" tag to this patch.
Anyway:
Reviewed-by: Bart Van Assche
On Fri, 2018-02-23 at 09:26 +0100, Johannes Thumshirn wrote:
> how about "block: Add 'lock' as third argument to
> blk_alloc_queue_node()"?
>
> So one actually sees early enough what the thrird argument will be?
Hello Johannes,
If I have to repost this patch series I will make that change.
Than
On Fri, 2018-02-23 at 11:58 +0200, Jaco Kroon wrote:
> On 22/02/2018 18:46, Bart Van Assche wrote:
> > (cd /sys/kernel/debug/block && find . -type f -exec grep -aH . {} \;)
>
> I don't have a /sys/kernel/debug folder - I've enabled CONFIG_DEBUG_FS
> and BL
Remove the disk, partition and bdi sysfs attributes before cleaning up
the request queue associated with the disk.
Signed-off-by: Bart Van Assche
Cc: Josef Bacik
Cc: Shaohua Li
Cc: Omar Sandoval
Cc: Hannes Reinecke
Cc: Ming Lei
---
drivers/block/loop.c | 2 +-
1 file changed, 1 insertion
Remove the disk, partition and bdi sysfs attributes before cleaning up
the request queue associated with the disk.
Signed-off-by: Bart Van Assche
Cc: Shaohua Li
---
drivers/md/md.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index
modified all block drivers that call
blk_alloc_queue_node().
Bart Van Assche (6):
block/loop: Delete gendisk before cleaning up the request queue
md: Delete gendisk before cleaning up the request queue
zram: Delete gendisk before cleaning up the request queue
block: Add a third argument to
lock earlier if necessary.
Reported-by: Joseph Qi
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Joseph Qi
Cc: Philipp Reisner
Cc: Ulf Hansson
Cc: Kees Cook
---
block/blk-core.c | 24
drivers/block/drbd/drbd_main.c | 3 +--
drivers/bl
This patch does not change any functionality.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Joseph Qi
Cc: Philipp Reisner
Cc: Ulf Hansson
Cc: Kees Cook
---
block/blk-core.c | 7 ---
block/blk-mq.c| 2 +-
drivers/block/null_blk.c | 3
Remove the disk, partition and bdi sysfs attributes before cleaning up
the request queue associated with the disk.
Signed-off-by: Bart Van Assche
Cc: Minchan Kim
Cc: Nitin Gupta
Cc: Sergey Senozhatsky
---
drivers/block/zram/zram_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
reference on a request queue after having called blk_cleanup_queue().
Neither driver accesses any of the removed data structures between its
blk_cleanup_queue() and blk_put_queue() calls.
Reported-by: Joseph Qi
Signed-off-by: Bart Van Assche
Cc: Jan Kara
---
On Thu, 2018-02-22 at 14:42 -0800, Omar Sandoval wrote:
> On Thu, Feb 22, 2018 at 09:10:23PM +0000, Bart Van Assche wrote:
> > I/O hangs if I run the following command on top of kernel v4.16-rc2 + the
> > ib_srpt patch that adds RDMA/CM support:
> >
> > srp-test/run_te
Hello Omar,
I/O hangs if I run the following command on top of kernel v4.16-rc2 + the
ib_srpt patch that adds RDMA/CM support:
srp-test/run_tests -c -d -r 10 -t 02-mq -e kyber
This does not happen with the deadline scheduler nor without a scheduler.
This test passed a few months ago. I have atta
On Thu, 2018-02-22 at 10:25 +0800, Joseph Qi wrote:
> I notice that several devices such as loop and zram will call
> blk_cleanup_queue before del_gendisk, so it will hit this warning. Is
> this normal?
Hello Joseph,
Since the disk object has a reference to the queue I agree with Ming that it's
w
On 02/22/18 02:58, Jaco Kroon wrote:
We've been seeing sporadic IO lockups on recent kernels.
Are you using the legacy I/O stack or blk-mq? If you are not yet using
blk-mq, can you switch to blk-mq + scsi-mq + dm-mq? If the lockup is
reproducible with blk-mq, can you share the output of the f
On Wed, 2018-02-21 at 11:21 -0800, t...@kernel.org wrote:
> Hello, Bart.
>
> On Wed, Feb 21, 2018 at 06:53:05PM +0000, Bart Van Assche wrote:
> > On Sun, 2018-02-18 at 05:11 -0800, t...@kernel.org wrote:
> > > On Wed, Feb 14, 2018 at 04:58:56PM +, Bart Van Assche
On 02/09/18 10:44, Bart Van Assche wrote:
Recently Joseph Qi identified races between the block cgroup code and request
queue initialization and cleanup. This patch series address these races. Please
consider these patches for kernel v4.17.
Hello Joseph,
Can you add your Tested-by or Reviewed
On Sun, 2018-02-18 at 05:11 -0800, t...@kernel.org wrote:
> On Wed, Feb 14, 2018 at 04:58:56PM +0000, Bart Van Assche wrote:
> > With this patch applied the tests I ran so far pass.
>
> Ah, great to hear. Thanks a lot for testing. Can you please verify
> the following? It&#
ECTOR_SIZE
redefinition.
Note: the SECTOR_SIZE / SECTOR_SHIFT / SECTOR_BITS definitions have
not been removed from uapi header files nor from NAND drivers in
which these constants are used for another purpose than converting
block layer offsets and sizes into a number of sectors.
Signed-off-by: Bart
On Fri, 2018-02-16 at 08:39 +0100, Paolo Valente wrote:
> after enabling the listing options in your list, and a few other
> related options, such iblock support, I get this:
>
> $ sudo ./run_tests -c -d -r 10 -t 02-mq -e bfq
> Unloaded the ib_srpt kernel module
> Unloaded the rdma_rxe kernel modu
On 02/14/18 09:55, Paolo Valente wrote:
After following all of them (and taking some other step needed), I
invoked:
sudo ./run_tests -c -d -r 10 -t 02-mq -e bfq
But I got the following:
./lib/functions: riga 34: /sys/class/block/ram0/size: No such file or directory
./lib/functions: riga 34: * 51
On Tue, 2018-02-13 at 13:20 -0800, t...@kernel.org wrote:
> On Thu, Feb 08, 2018 at 04:31:43PM +0000, Bart Van Assche wrote:
> > The crash is reported at address scsi_times_out+0x17 == scsi_times_out+23.
> > The
> > instruction at that address tries to dereference s
On Tue, 2018-02-13 at 19:38 +0100, Paolo Valente wrote:
> as a first attempt, I've followed your steps, but got:
> Error: could not find sg_reset
Please install the sg3_utils package. Every Linux distro I know of supports that
package. And in case you would like to install it from source, the sour
On Tue, 2018-02-13 at 17:54 +0900, Sergey Senozhatsky wrote:
> On (02/12/18 11:05), Bart Van Assche wrote:
> [..]
> > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> > index ac4740cf74be..cf17626604c2 100644
> > --- a/include/linux/blkdev.h
> >
On Tue, 2018-02-13 at 09:43 +0100, Johannes Thumshirn wrote:
> On Mon, 2018-02-12 at 11:05 -0800, Bart Van Assche wrote:
> > +/*
> > + * Variables of type sector_t represent an offset or size that is a
> > multiple of
> > + * 2**9 bytes. Hence these two const
ECTOR_SIZE / SECTOR_SHIFT / SECTOR_BITS definitions have
not been removed from uapi header files nor from NAND drivers in
which these constants are used for another purpose than converting
block layer offsets and sizes into a number of sectors.
Signed-off-by: Bart Van Assche
Cc: David S. Miller
Cc
Move the definition of queue_flag_clear_unlocked() up and move the
definition of queue_in_flight() down such that all queue flag
manipulation function definitions become contiguous.
This patch does not change any functionality.
Signed-off-by: Bart Van Assche
---
include/linux/blkdev.h | 22
ow_rq() NULL
pointer dereference").
Signed-off-by: Bart Van Assche
Cc: Ming Lei
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Martin K. Petersen
---
block/blk-mq-debugfs.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/block/blk-mq-d
On 02/05/18 08:01, Jean-Louis Dupond wrote:
We've got some "strange" issue on a Xen hypervisor with CentOS 6 and
4.9.63-29.el6.x86_6 kernel.
Hello Jean-Louis,
Since this behavior was observed with a distro kernel I think a support
request should be submitted to the vendor of that kernel. That
On 02/11/18 23:35, Paolo Valente wrote:
Also this smells a little bit like some spurious elevator call.
Unfortunately I have no clue on the cause. To go on, I need at least
to reproduce it. In this respect: Bart, could you please tell me how
to setup the offending configuration, and to cause th
On 05/29/83 20:21, Nitesh Shetty wrote:
[ ... ]
Hello Nitesh,
Can you check the clock of the system you used to send this e-mail? In
the header of your e-mail I found the following:
Date: Sun, 30 May 2083 09:51:06 +0530
Thanks,
Bart.
On 02/09/18 10:58, Jens Axboe wrote:
On 2/9/18 11:54 AM, Bart Van Assche wrote:
Hello Paolo,
If I enable the BFQ scheduler for a dm-mpath device then a kernel oops
appears (see also below). This happens systematically with Linus' tree from
this morning (commit 54ce685cae30) merged with
Hello Paolo,
If I enable the BFQ scheduler for a dm-mpath device then a kernel oops
appears (see also below). This happens systematically with Linus' tree from
this morning (commit 54ce685cae30) merged with Jens' for-linus branch (commit
a78773906147 ("block, bfq: add requeue-request hook")) and f
lock earlier if necessary.
Reported-by: Joseph Qi
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Joseph Qi
Cc: Philipp Reisner
Cc: Ulf Hansson
Cc: Kees Cook
---
block/blk-core.c | 24
drivers/block/drbd/drbd_main.c | 3 +--
drivers/bl
This patch does not change any functionality.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Joseph Qi
Cc: Philipp Reisner
Cc: Ulf Hansson
Cc: Kees Cook
---
block/blk-core.c | 7 ---
block/blk-mq.c| 2 +-
drivers/block/null_blk.c | 3
between the blkcg code and queue
cleanup.
Changes between v1 and v2:
- Split a single patch into two patches.
- Dropped blk_alloc_queue_node2() and modified all block drivers that call
blk_alloc_queue_node().
Bart Van Assche (3):
block: Add a third argument to blk_alloc_queue_node()
block
reference on a request queue after having called blk_cleanup_queue().
Neither driver accesses any of the removed data structures between its
blk_cleanup_queue() and blk_put_queue() calls.
Reported-by: Joseph Qi
Signed-off-by: Bart Van Assche
Cc: Jan Kara
---
On Fri, 2018-02-09 at 22:15 +0800, Ming Lei wrote:
> The 'lend' parameter of truncate_inode_pages_range is required to be
> inclusive, so follow the rule.
>
> This patch fixes one memory corruption triggered by discard.
>
> Fixes: 351499a172c0 ("block: Invalidate cache on discard v2")
Since this
On Thu, 2018-02-08 at 18:38 +0100, Danil Kipnis wrote:
> thanks for the link to the article. To the best of my understanding,
> the guys suggest to authenticate the devices first and only then
> authenticate the users who use the devices in order to get access to a
> corporate service. They also me
On Thu, 2018-02-08 at 09:40 -0800, t...@kernel.org wrote:
> Heh, sorry about not being clear. What I'm trying to say is that
> scmd->device != NULL && device->host == NULL. Or was this what you
> were saying all along?
What I agree with is that the request pointer (req argument) is stored in %rd
On Thu, 2018-02-08 at 09:19 -0800, t...@kernel.org wrote:
> Hello, Bart.
>
> On Thu, Feb 08, 2018 at 05:10:45PM +0000, Bart Van Assche wrote:
> > I think "dereferencing a pointer" means reading the memory location that
> > pointer points
> > at? Anyway, I thi
On Sat, 2018-02-03 at 12:21 +0800, Ming Lei wrote:
> diff --git a/block/blk-mq-tag.h b/block/blk-mq-tag.h
> index 61deab0b5a5a..a68323fa0c02 100644
> --- a/block/blk-mq-tag.h
> +++ b/block/blk-mq-tag.h
> @@ -11,10 +11,14 @@ struct blk_mq_tags {
> unsigned int nr_tags;
> unsigned int nr_
On Thu, 2018-02-08 at 09:00 -0800, t...@kernel.org wrote:
> On Thu, Feb 08, 2018 at 04:31:43PM +0000, Bart Van Assche wrote:
> > The crash is reported at address scsi_times_out+0x17 == scsi_times_out+23.
> > The
> > instruction at that address tries to dereference s
On Thu, 2018-02-08 at 07:39 -0800, t...@kernel.org wrote:
> On Thu, Feb 08, 2018 at 01:09:57AM +0000, Bart Van Assche wrote:
> > On Wed, 2018-02-07 at 23:48 +0000, Bart Van Assche wrote:
> > > With this patch applied I see requests for which it seems like the
> > > ti
On Mon, 2018-02-05 at 23:20 +0800, Ming Lei wrote:
> diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
> index 55c0a745b427..385bbec73804 100644
> --- a/block/blk-mq-sched.c
> +++ b/block/blk-mq-sched.c
> @@ -81,6 +81,17 @@ static bool blk_mq_sched_restart_hctx(struct blk_mq_hw_ctx
> *hctx)
On Tue, 2018-02-06 at 00:03 +0200, Sagi Grimberg wrote:
> +void irq_poll_init_am(struct irq_poll *iop, unsigned int nr_events,
> +unsigned short nr_levels, unsigned short start_level, irq_poll_am_fn
> *amfn)
> +{
> + iop->amfn = amfn;
> + irq_am_init(&iop->am, nr_events, nr_levels,
On Tue, 2018-02-06 at 00:03 +0200, Sagi Grimberg wrote:
> +static int irq_am_register_debugfs(struct irq_am *am)
> +{
> + char name[20];
> +
> + snprintf(name, sizeof(name), "am%u", am->id);
> + am->debugfs_dir = debugfs_create_dir(name,
> + irq_am_debugfs_ro
On Wed, 2018-02-07 at 23:48 +, Bart Van Assche wrote:
> With this patch applied I see requests for which it seems like the timeout
> handler
> did not get invoked: [ ... ]
I just noticed the following in the system log, which is probably the reason
why some
requests got stuck:
Feb
On Wed, 2018-02-07 at 12:07 -0800, t...@kernel.org wrote:
> Ah, you're right. u64_stat_sync doesn't imply barriers, so we want
> something like the following.
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index df93102..d6edf3b 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -593,7
On Wed, 2018-02-07 at 12:09 -0800, t...@kernel.org wrote:
> Hello,
>
> On Wed, Feb 07, 2018 at 07:03:56PM +0000, Bart Van Assche wrote:
> > I tried the above patch but already during the first iteration of the test I
> > noticed that the test hung, probably due to the follo
On Wed, 2018-02-07 at 09:06 -0800, Tejun Heo wrote:
> Can you see whether by any chance the following patch fixes the issue?
> If not, can you share the repro case?
>
> Thanks.
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index df93102..651d18c 100644
> --- a/block/blk-mq.c
> +++ b/block/bl
1001 - 1100 of 2722 matches
Mail list logo
