[PATCH] block: remove duplicate initialization

2018-08-16 Thread Chaitanya Kulkarni
This patch removes the duplicate initialization of q->queue_head in the blk_alloc_queue_node(). This removes the 2nd initialization so that we preserve the initialization order same as declaration present in struct request_queue. Signed-off-by: Chaitanya Kulkarni --- block/blk-core.c | 1 -

Re: [PATCH 0/2] blktests: test ANA base support

2018-07-25 Thread Chaitanya Kulkarni
Chaitanya From: Omar Sandoval Sent: Wednesday, July 25, 2018 2:00 PM To: Chaitanya Kulkarni Cc: Hannes Reinecke; Omar Sandoval; Christoph Hellwig; Sagi Grimberg; Keith Busch; linux-n...@lists.infradead.org; linux-block@vger.kernel.org Subject: Re: [PATCH 0/2] blktests: test ANA base support   On We

Re: [PATCH 0/2] blktests: test ANA base support

2018-07-25 Thread Chaitanya Kulkarni
Thanks, Omar. From: Omar Sandoval Sent: Wednesday, July 25, 2018 12:17 PM To: Chaitanya Kulkarni Cc: Hannes Reinecke; Omar Sandoval; Christoph Hellwig; Sagi Grimberg; Keith Busch; linux-n...@lists.infradead.org; linux-block@vger.kernel.org Subject: Re: [PATCH 0/2] blktests: test ANA base

Re: [PATCH 2/2] blktests: add test for ANA state transition

2018-07-21 Thread Chaitanya Kulkarni
From: linux-block-ow...@vger.kernel.org on behalf of Hannes Reinecke Sent: Tuesday, July 17, 2018 6:31 AM To: Omar Sandoval Cc: Christoph Hellwig; Sagi Grimberg; Keith Busch; linux-n...@lists.infradead.org; linux-block@vger.kernel.org; Hannes Reinecke; Hannes Reinecke Subject: [PATCH 2/2]

Re: [PATCH 0/2] blktests: test ANA base support

2018-07-21 Thread Chaitanya Kulkarni
Hi Hannes, Thanks for the test, this is really helpful, please see my inline comments to individual patches. Also, the test number should be I guess 18, 14-17 testcases are still in the queue. Omar, can you please let us know when can you merge the remaining testcases for NVMeOF from the

[PATCH blktests] blktests: use consistent helper returns

2018-05-22 Thread Chaitanya Kulkarni
This is a cleanup patch which uses consistent return values for helper functions. Signed-off-by: Chaitanya Kulkarni <chaitanya.kulka...@wdc.com> --- common/rc | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/common/rc b/common/rc index e59ae0b..936b21d

Re: [BUG v4.10-rc1] fzero returns EIO on DAX mount

2017-01-07 Thread Chaitanya Kulkarni
me some time to debug more and come up with the solution. Regards, -Chaitanya From: Eryu Guan <eg...@redhat.com> Sent: Friday, January 6, 2017 2:32:39 AM To: linux-block@vger.kernel.org Cc: Chaitanya Kulkarni; linux-...@vger.kernel.org; linux-e...@vger.kernel.org Subject: [BUG v4.10-rc1] fzero

[PATCH V2 4/5] nvme: add support for the Write Zeroes command

2016-11-30 Thread Chaitanya Kulkarni
definition. Signed-off-by: Chaitanya Kulkarni <chaitanya.kulka...@hgst.com> --- drivers/nvme/host/core.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 44f8a53..16a315d 100644 --- a/drivers/nvme/host/core.c

[PATCH V2 3/5] nvme.h: add Write Zeroes definitions

2016-11-30 Thread Chaitanya Kulkarni
Add the command structure, optional command set support (ONCS) bit and a new error code for the Write Zeroes command. Signed-off-by: Chaitanya Kulkarni <chaitanya.kulka...@hgst.com> --- include/linux/nvme.h | 20 1 file changed, 20 insertions(+) diff --git a/include

[PATCH V2 5/5] nvmet: add support for the Write Zeroes command

2016-11-30 Thread Chaitanya Kulkarni
Add support for handling write zeroes command on target. Call into __blkdev_issue_zeroout, which the block layer expands into the best suitable variant of zeroing the LBAs. Allow write zeroes operation to deallocate the LBAs when calling __blkdev_issue_zeroout. Signed-off-by: Chaitanya Kulkarni

[PATCH v2 2/5] block: add support for REQ_OP_WRITE_ZEROES

2016-11-17 Thread Chaitanya Kulkarni
From: Chaitanya Kulkarni <chaitanya.kulka...@hgst.com> This adds a new block layer operation to zero out a range of LBAs. This allows to implement zeroing for devices that don't use either discard with a predictable zero pattern or WRITE SAME of zeroes. The prominent example of that i

[PATCHSET] Add support for write zeroes operation in Block layer and NVMe Driver.

2016-11-15 Thread Chaitanya Kulkarni
1. Block layer implementation details :- a. Introducing __blkdev_issue_zeroout variant of exiting code. b. Introducing new request operation flag REQ_OP_WRITE_ZEROES to represent write zeroes operation. c. Mechanism to issue bios without payload with the help of

[PATCH 2/5] block: add support for REQ_OP_WRITE_ZEROES

2016-11-15 Thread Chaitanya Kulkarni
also help with improving the way zeroing discards work. Signed-off-by: Chaitanya Kulkarni <chaitanya.kulka...@hgst.com> --- block/bio.c | 1 + block/blk-core.c | 4 block/blk-lib.c | 58 +-- block/blk-m

[PATCH 5/5] nvmet: add support for the Write Zeroes command

2016-11-15 Thread Chaitanya Kulkarni
Add support for handling write zeroes command on target. Call into __blkdev_issue_zeroout, which the block layer expands into the best suitable variant of zeroing the LBAs. Signed-off-by: Chaitanya Kulkarni <chaitanya.kulka...@hgst.com> --- drivers/nvme/target/admin-cmd.c | 3 ++- driver

[PATCH 1/5] block: add async variant of blkdev_issue_zeroout

2016-11-15 Thread Chaitanya Kulkarni
Similar to __blkdev_issue_discard this variant allows submitting the final bio asynchronously and chaining multiple ranges into a single completion. Signed-off-by: Chaitanya Kulkarni <chaitanya.kulka...@hgst.com> --- block/blk-lib.c

[PATCH] Unittest framework based on nvme-cli.

2016-11-01 Thread Chaitanya Kulkarni
From: Chaitanya Kulkarni <ckulkarnili...@gmail.com> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulka...@hgst.com> --- Makefile| 5 +- tests/Makefile | 48 + tests/README| 84