Re: [PATCH v4 11/25] ibtrs: server: statistics functions

2019-10-02 Thread Leon Romanovsky
On Wed, Oct 02, 2019 at 05:45:04PM +0200, Jinpu Wang wrote: > On Wed, Oct 2, 2019 at 5:42 PM Leon Romanovsky wrote: > > > > On Wed, Oct 02, 2019 at 05:15:10PM +0200, Jinpu Wang wrote: > > > On Tue, Sep 24, 2019 at 1:56 AM Bart Van Assche > > > wrote: > &g

Re: [PATCH v4 11/25] ibtrs: server: statistics functions

2019-10-02 Thread Leon Romanovsky
On Wed, Oct 02, 2019 at 05:15:10PM +0200, Jinpu Wang wrote: > On Tue, Sep 24, 2019 at 1:56 AM Bart Van Assche wrote: > > > > On 6/20/19 8:03 AM, Jack Wang wrote: > > > +ssize_t ibtrs_srv_stats_rdma_to_str(struct ibtrs_srv_stats *stats, > > > + char *page, size_t len

Re: [PATCH v4 15/25] ibnbd: private headers with IBNBD protocol structs and helpers

2019-09-17 Thread Leon Romanovsky
On Mon, Sep 16, 2019 at 06:45:17AM -0700, Bart Van Assche wrote: > On 9/15/19 10:27 PM, Leon Romanovsky wrote: > > On Sun, Sep 15, 2019 at 04:30:04PM +0200, Jinpu Wang wrote: > > > On Sat, Sep 14, 2019 at 12:10 AM Bart Van Assche > > > wrote: > > >

Re: [PATCH v4 15/25] ibnbd: private headers with IBNBD protocol structs and helpers

2019-09-15 Thread Leon Romanovsky
On Sun, Sep 15, 2019 at 04:30:04PM +0200, Jinpu Wang wrote: > Thanks Bart for detailed review, reply inline. > > On Sat, Sep 14, 2019 at 12:10 AM Bart Van Assche wrote: > > > > On 6/20/19 8:03 AM, Jack Wang wrote: > > > +#define ibnbd_log(fn, dev, fmt, ...) ({ \ > > >

Re: [PATCH v4 25/25] MAINTAINERS: Add maintainer for IBNBD/IBTRS modules

2019-07-09 Thread Leon Romanovsky
On Tue, Jul 09, 2019 at 05:18:37PM +0200, Jinpu Wang wrote: > On Tue, Jul 9, 2019 at 5:10 PM Leon Romanovsky wrote: > > > > On Thu, Jun 20, 2019 at 05:03:37PM +0200, Jack Wang wrote: > > > From: Roman Pen > > > > > > Signed-off-by: Da

Re: [PATCH v4 25/25] MAINTAINERS: Add maintainer for IBNBD/IBTRS modules

2019-07-09 Thread Leon Romanovsky
On Thu, Jun 20, 2019 at 05:03:37PM +0200, Jack Wang wrote: > From: Roman Pen > > Signed-off-by: Danil Kipnis > Signed-off-by: Jack Wang > --- > MAINTAINERS | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index a6954776a37e..0b7fd93f738d 10064

Re: [PATCH v4 00/25] InfiniBand Transport (IBTRS) and Network Block Device (IBNBD)

2019-07-09 Thread Leon Romanovsky
On Tue, Jul 09, 2019 at 01:17:37PM +0200, Greg KH wrote: > On Tue, Jul 09, 2019 at 02:00:36PM +0300, Leon Romanovsky wrote: > > On Tue, Jul 09, 2019 at 11:55:03AM +0200, Danil Kipnis wrote: > > > Hallo Doug, Hallo Jason, Hallo Jens, Hallo Greg, > > > > > > Could

Re: [PATCH v4 00/25] InfiniBand Transport (IBTRS) and Network Block Device (IBNBD)

2019-07-09 Thread Leon Romanovsky
On Tue, Jul 09, 2019 at 11:55:03AM +0200, Danil Kipnis wrote: > Hallo Doug, Hallo Jason, Hallo Jens, Hallo Greg, > > Could you please provide some feedback to the IBNBD driver and the > IBTRS library? > So far we addressed all the requests provided by the community and > continue to maintain our co

Re: [RFC/PATCH net-next 0/9] net/dim: Support for multiple implementations

2019-03-24 Thread Leon Romanovsky
On Wed, Mar 20, 2019 at 11:34:27AM -0700, Sagi Grimberg wrote: > > > It doesn't sound reasonable that we have per-ULP feature (DIM is > > per-ULP) to be configured globally. Especially given the fact that > > users can find themselves running different workloads with different > > requirements on t

Re: [RFC/PATCH net-next 0/9] net/dim: Support for multiple implementations

2019-03-20 Thread Leon Romanovsky
On Wed, Mar 20, 2019 at 11:17:36AM +0200, Max Gurtovoy wrote: > > On 3/18/2019 11:34 PM, Sagi Grimberg wrote: > > > > > As we discussed, let's check with RDMA maintainers if it's better to > > > extend alloc_cq API or create alloc_cq_dim API function. > > > > > > Sagi/Christoph, > > > > > > how abo

Re: [PATCH v2 14/26] ibtrs: include client and server modules into kernel compilation

2018-05-22 Thread Leon Romanovsky
On Tue, May 22, 2018 at 11:27:21AM +0200, Roman Penyaev wrote: > On Tue, May 22, 2018 at 7:05 AM, Leon Romanovsky wrote: > > On Fri, May 18, 2018 at 03:04:01PM +0200, Roman Pen wrote: > >> Add IBTRS Makefile, Kconfig and also corresponding lines into upper > >>

Re: [PATCH v2 14/26] ibtrs: include client and server modules into kernel compilation

2018-05-21 Thread Leon Romanovsky
On Fri, May 18, 2018 at 03:04:01PM +0200, Roman Pen wrote: > Add IBTRS Makefile, Kconfig and also corresponding lines into upper > layer infiniband/ulp files. > > Signed-off-by: Roman Pen > Signed-off-by: Danil Kipnis > Cc: Jack Wang > --- > drivers/infiniband/Kconfig| 1 + > drive

Re: [PATCH v2 4/6] mlx5: support ->get_vector_affinity

2017-04-06 Thread Leon Romanovsky
On Thu, Apr 06, 2017 at 01:36:36PM +0300, Sagi Grimberg wrote: > Simply refer to the generic affinity mask helper. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Sagi Grimberg > --- Thanks, Acked-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH v2 2/6] mlx5: move affinity hints assignments to generic code

2017-04-06 Thread Leon Romanovsky
as we have generic helpers > to get cpumask and node given a irq vector, so use them > directly. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Sagi Grimberg > --- Thanks, Acked-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH v2 1/6] mlx5: convert to generic pci_alloc_irq_vectors

2017-04-06 Thread Leon Romanovsky
Christoph Hellwig > Signed-off-by: Sagi Grimberg > --- Thanks, Acked-by: Leon Romanovsky signature.asc Description: PGP signature