This argument was not being used since the legacy IO path was removed,
when blk-mq was enabled by default. So removed it from the kernel
parameters documentation.
Signed-off-by: Marcos Paulo de Souza
Reviewed-by: Hannes Reinecke
---
Documentation/admin-guide/kernel-parameters.txt | 6 --
1
Since the inclusion of blk-mq, elevator argument was not being
considered anymore, and it's utility died long with the legacy IO path,
now removed too.
Signed-off-by: Marcos Paulo de Souza
Reviewed-by: Hannes Reinecke
Reviewed-by: Bob Liu
---
block/elevator.c | 14 --
1
This argument was not being considered since blk-mq was set by default,
so removed this documentation to avoid confusion.
Signed-off-by: Marcos Paulo de Souza
Reviewed-by: Hannes Reinecke
---
Documentation/admin-guide/kernel-per-CPU-kthreads.rst | 8 +++-
1 file changed, 3 insertions(+), 5
This argument was ignored since blk-mq was set as default, so remove it
from documentation.
Signed-off-by: Marcos Paulo de Souza
Reviewed-by: Hannes Reinecke
---
Documentation/block/switching-sched.rst | 4
1 file changed, 4 deletions(-)
diff --git a/Documentation/block/switching
l.org/lkml/2019/8/27/1648
[2]: https://lkml.org/lkml/2019/7/12/1008
[3]: https://lkml.org/lkml/2019/7/13/232
Marcos Paulo de Souza (4):
block: elevator.c: Remove now unused elevator= argument
kernel-parameters.txt: Remove elevator argument
Documenation: switching-sched: Remove notes abo
This argument was ignored since blk-mq was set as default, so remove it
from documentation.
Signed-off-by: Marcos Paulo de Souza
Reviewed-by: Hannes Reinecke
---
Documentation/block/switching-sched.txt | 4
1 file changed, 4 deletions(-)
diff --git a/Documentation/block/switching
This argument was not being considered since blk-mq was set by default,
so removed this documentation to avoid confusion.
Signed-off-by: Marcos Paulo de Souza
Reviewed-by: Hannes Reinecke
---
Documentation/kernel-per-CPU-kthreads.txt | 8 +++-
1 file changed, 3 insertions(+), 5 deletions
it is not
being used since blk-mq was set by default.
Along with elevator code, some documentation was also updated to remove elevator
references.
[1]: https://lkml.org/lkml/2019/7/12/1008
[2]: https://lkml.org/lkml/2019/7/13/232
Marcos Paulo de Souza (4):
block: elevator.c: Remove now unused
Since the inclusion of blk-mq, elevator argument was not being
considered anymore, and it's utility died long with the legacy IO path,
now removed too.
Signed-off-by: Marcos Paulo de Souza
Reviewed-by: Hannes Reinecke
Reviewed-by: Bob Liu
---
block/elevator.c | 14 --
1
This argument was not being used since the legacy IO path was removed,
when blk-mq was enabled by default. So removed it from the kernel
parameters documentation.
Signed-off-by: Marcos Paulo de Souza
Reviewed-by: Hannes Reinecke
---
Documentation/admin-guide/kernel-parameters.txt | 6 --
1
On Sun, Aug 11, 2019 at 07:47:17AM -0600, Jens Axboe wrote:
> On 8/9/19 3:54 AM, Marcos Paulo de Souza wrote:
> > After checking the request_queue argument of funtion blk_execute_rq_nowait,
> > I
> > now added three more patches, one to remove the same argument from
> &g
The only user of the request_queue argument was removed in commit
552cef2b8b03 ("block: Remove request_queue argument from
blk_execute_rq_nowait"), so now we can safely removed the same argument
from blk_execute_rq and all places that calls this function.
Signed-off-by: Marcos Paul
Suggested-by: Christoph Hellwig
Signed-off-by: Marcos Paulo de Souza
---
block/blk-exec.c | 2 +-
block/scsi_ioctl.c | 8
drivers/block/paride/pd.c| 2 +-
drivers/block/pktcdvd.c | 2 +-
drivers/cdrom/cdrom.c| 2 +-
drivers/ide/ide-atapi.c
Suggested-by: Christoph Hellwig
Signed-off-by: Marcos Paulo de Souza
---
block/blk-exec.c | 2 +-
drivers/nvme/host/core.c | 12 ++--
drivers/nvme/host/lightnvm.c | 2 +-
drivers/nvme/host/nvme.h | 2 +-
drivers/nvme/host/pci.c | 2 +-
drivers/scsi
ned-off-by: Marcos Paulo de Souza
---
block/blk-exec.c | 8 +++-
drivers/block/sx8.c| 4 ++--
drivers/nvme/host/core.c | 4 ++--
drivers/nvme/host/lightnvm.c | 2 +-
drivers/nvme/host/pci.c| 7 +++
drivers/scsi/scsi_error.c
this patch gets merged, my plan is to analyse the usage the gendisk
argument, is being set as NULL but the majority of callers.
[1]: https://lkml.org/lkml/2019/8/6/31
Marcos Paulo de Souza (4):
block: Remove request_queue argument from blk_execute_rq_nowait
fs/block/drivers: Remove
On Fri, Aug 09, 2019 at 05:18:16PM +0800, Shaokun Zhang wrote:
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> drivers/lightnvm/pblk-read.c: In function ‘pblk_submit_read_gc’:
> drivers/lightnvm/pblk-read.c:421:18: warning: unused variable ‘geo’
On Tue, Aug 06, 2019 at 07:19:11AM +0200, Christoph Hellwig wrote:
> On Mon, Aug 05, 2019 at 10:17:51PM -0300, Marcos Paulo de Souza wrote:
> > +void blk_execute_rq_nowait(struct gendisk *bd_disk, struct request *rq,
> > + int at_head, rq_end_io_fn *done)
ned-off-by: Marcos Paulo de Souza
---
block/blk-exec.c | 7 +++
drivers/block/sx8.c| 4 ++--
drivers/nvme/host/core.c | 4 ++--
drivers/nvme/host/lightnvm.c | 2 +-
drivers/nvme/host/pci.c| 7 +++
drivers/scsi/scsi_error.c
Hi Jens,
there are two reviewers for this patchset, can you take a look?
Thanks,
Marcos
On Sun, Jul 14, 2019 at 02:34:49AM -0300, Marcos Paulo de Souza wrote:
> After the first patch sent[1], together with some background from Jens[2],
> this
> patchset aims to remove completely
blk_mq_sched_completed_request is a function that checks if the elevator
related to the request has started_request implemented, but currently, none of
the available IO schedulers implement started_request, so remove both.
Signed-off-by: Marcos Paulo de Souza
---
Changes from v1:
This was
This function checks if the elevator related to the request has
started_request implemented, but currently, none of the available IO
schedulers implement started_request.
Signed-off-by: Marcos Paulo de Souza
---
block/blk-mq-sched.h | 9 -
block/blk-mq.c | 2 --
2 files changed
emove blk_mq_sched_started_request along with started_request, which
is member of the elevator_mq_ops struct.
Marcos Paulo de Souza (2):
block: blk-mq: Remove blk_mq_sched_started_request function
include: elevator.h: Remove started_request from elevator_mq_ops
block/blk-mq-sched.h | 9 -
bloc
This function is not implemented by any available IO scheduler, so
remove it.
Signed-off-by: Marcos Paulo de Souza
---
include/linux/elevator.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/elevator.h b/include/linux/elevator.h
index 17cd0078377c..1dd014c9c87b 100644
--- a
This argument was not being used since the legacy IO path was removed,
when blk-mq was enabled by default. So removed it from the kernel
parameters documentation.
Signed-off-by: Marcos Paulo de Souza
---
Documentation/admin-guide/kernel-parameters.txt | 6 --
1 file changed, 6 deletions
This argument was ignored since blk-mq was set as default, so remove it
from documentation.
Signed-off-by: Marcos Paulo de Souza
---
Documentation/block/switching-sched.txt | 4
1 file changed, 4 deletions(-)
diff --git a/Documentation/block/switching-sched.txt
b/Documentation/block
This argument was not being considered since blk-mq was set by default,
so removed this documentation to avoid confusion.
Signed-off-by: Marcos Paulo de Souza
---
Documentation/kernel-per-CPU-kthreads.txt | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/Documentation
.
Please review, thanks.
[1]: https://lkml.org/lkml/2019/7/12/1008
[2]: https://lkml.org/lkml/2019/7/13/232
Marcos Paulo de Souza (4):
block: elevator.c: Remove now unused elevator= argument
kernel-parameters.txt: Remove elevator argument
Documenation: switching-sched: Remove notes about
Since the inclusion of blk-mq, elevator argument was not being
considered anymore, and it's utility died long with the legacy IO path,
now removed too.
Signed-off-by: Marcos Paulo de Souza
---
block/elevator.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/block/elevato
ping?
On Tue, Jul 02, 2019 at 07:55:21PM -0300, Marcos Paulo de Souza wrote:
> ping?
>
> On Mon, Jun 24, 2019 at 01:09:33PM -0300, Marcos Paulo de Souza wrote:
> > set_capacity expects the disk size in sectors of 512 bytes, and changing
> > the magic number 9 to SECTOR
On Sat, Jul 13, 2019 at 03:53:28PM -0600, Jens Axboe wrote:
> On 7/12/19 9:52 PM, Marcos Paulo de Souza wrote:
> > Since the inclusion of blk-mq, elevator= kernel argument was not being
> > considered anymore, making it impossible to specify a specific elevator
> > at boo
. Without this patch,
mq-deadline is the only elevator that is can be used at boot time.
Signed-off-by: Marcos Paulo de Souza
---
I found this issue while inspecting why noop scheduler was gone, and so I found
that was now impossible to use a scheduler different from mq-deadeline.
Am I missing
q_align; /* ditto */
> struct elv_fs_entry *elevator_attrs;
> - char elevator_name[ELV_NAME_MAX];
> + const char *elevator_name;
> const char *elevator_alias;
> struct module *elevator_owner;
> #ifdef CONFIG_BLK_DEBUG_FS
Acked-by: Marcos Paulo de Souza
> --
> 2.21.0
>
SORT_MERGE 6
>
> -/*
> - * return values from elevator_may_queue_fn
> - */
> -enum {
> - ELV_MQUEUE_MAY,
> - ELV_MQUEUE_NO,
> - ELV_MQUEUE_MUST,
> -};
Acked-by: Marcos Paulo de Souza
> -
> #define rq_end_sector(rq)(blk_rq_pos(rq) + blk_rq_sectors(rq))
> #define rb_entry_rq(node)rb_entry((node), struct request, rb_node)
>
> --
> 2.21.0
>
Agreed, much better than a magic number.
Acked-by: Marcos Paulo de Souza
ping?
On Mon, Jun 24, 2019 at 01:09:33PM -0300, Marcos Paulo de Souza wrote:
> set_capacity expects the disk size in sectors of 512 bytes, and changing
> the magic number 9 to SECTOR_SHIFT clarifies this intent.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> drivers/block
set_capacity expects the disk size in sectors of 512 bytes, and changing
the magic number 9 to SECTOR_SHIFT clarifies this intent.
Signed-off-by: Marcos Paulo de Souza
---
drivers/block/nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block
function called
bytes_to_sectors, adding a proper comment explaining why this is needed.
null_blk was changed to use this new function.
Thanks,
Marco
Marcos Paulo de Souza (2):
blkdev.h: Introduce bytes_to_sectors helper function
null_blk: Make use of bytes_to_sectors helper
drive
_sectors, adding a proper comment explaining why this is needed.
null_blk was changed to use this new function.
Thanks,
Marco
Marcos Paulo de Souza (2):
blkdev.h: Introduce size_to_sectors hlper function
null_blk: Make use of size_to_sectors helper
drivers/block/null_blk_mai
Hello Yufen,
On 2/27/19 3:21 AM, Yufen Yu wrote:
For q->poll_nsec == -1, means using classic poll, not hybrid poll.
We introduce a new flag BLK_POLL_DELAY_INVALID to replace -1, which
may make code much easier to read.
In the commit message you say BLK_POLL_DELAY_INVALID, but the code and
the
The Notes section of the comment was removed, because now
blk_release_queue can only be executed from blk_cleanup_queue (being
called when the q->kobj reaches zero), and also blk_init_queue was removed
in a1ce35fa4985.
Signed-off-by: Marcos Paulo de Souza
---
Changes from v1:
* Ty
Ping :)
On 1/30/19 11:11 PM, Marcos Paulo de Souza wrote:
> The Notes section of the comment was removed, because now
> blk_release_queue can only be executed from blk_cleanup_queue (being
> called when the q->kobj reaches zero), and also blk_init_queue was removed
> in a1ce35fa49
Ping :)
On 1/25/19 1:50 AM, Bart Van Assche wrote:
> On 1/24/19 6:01 PM, Marcos Paulo de Souza wrote:
>> Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to
>> a newly created function called blk_exit_queue, including the call of
>> blkcg_exit_
The Notes section of the comment was removed, because now
blk_release_queue can only be executed from blk_cleanup_queue (being
called when the q->kobj reaches zero), and also blk_init_queue was removed
in a1ce35fa4985.
Signed-off-by: Marcos Paulo de Souza
---
This is basically a v2 of ht
Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to
a newly created function called blk_exit_queue, including the call of
blkcg_exit_queue. So, adjust the documenation according.
Signed-off-by: Marcos Paulo de Souza
---
block/blk-cgroup.c | 2 +-
1 file changed, 1 insertion
HI Jeans,
On 1/15/19 1:54 AM, Jens Axboe wrote:
> On 1/14/19 8:06 PM, Marcos Paulo de Souza wrote:
>> blk_init_queue was removed in a1ce35fa4985.
>
> Honestly, most of that comment is wrong anyway. Since this isn't
> a visible API, I'd just kill the comment complete
blk_init_queue was removed in a1ce35fa4985.
Signed-off-by: Marcos Paulo de Souza
---
There are more two references in Documentation/block/biodoc.txt, but maybe that
file needs a rewrite in rst anyway?
block/blk-sysfs.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
This argument was removed in 5f0ed774ed29.
Signed-off-by: Marcos Paulo de Souza
---
block/blk-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index c78042975737..eba494f528cb 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -661,7 +661,6
Instead of calling blk_trace_bio_get_cgid(q, bio)) seven times, call it directly
inside blk_add_trace_bio.
Signed-off-by: Marcos Paulo de Souza
---
Discovered when checking the missing documentation of cgid in blk_add_trace_bio
function when running make pdfdocs.
kernel/trace/blktrace.c | 26
instead of passing cgid as a parameter.
Signed-off-by: Marcos Paulo de Souza
---
Discovered when checking the missing documentation of cgid in blk_add_trace_bio
function when running make pdfdocs.
kernel/trace/blktrace.c | 26 ++
1 file changed, 10 insertions(+), 16
50 matches
Mail list logo
