Re: [PATCH 2/5] [v2] acpi: disable -Wstringop-truncation

2024-04-09 Thread Rafael J. Wysocki
On Tue, Apr 9, 2024 at 4:01 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > gcc -Wstringop-truncation warns about copying a string that results in a > missing nul termination: > > drivers/acpi/acpica/tbfind.c: In function 'acpi_tb_find_table': > drivers/acpi/acpica/tbfind.c:60:9: error: 'strn

Re: [PATCH v6 10/18] x86/power/64: Remove VLA usage

2018-07-25 Thread Rafael J. Wysocki
On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to > shash directly and allocating the descriptor in heap memory (which should > be fine: the tfm has already

Re: [PATCH V3 0/4] genirq/affinity: irq vector spread among online CPUs as far as possible

2018-03-13 Thread Rafael J. Wysocki
On Tue, Mar 13, 2018 at 9:39 AM, Artem Bityutskiy wrote: > On Tue, 2018-03-13 at 16:35 +0800, Ming Lei wrote: >> Then looks this issue need to fix by making possible CPU count >> accurate >> because there are other resources allocated according to >> num_possible_cpus(), >> such as percpu variable

Re: [PATCH V3 0/4] genirq/affinity: irq vector spread among online CPUs as far as possible

2018-03-13 Thread Rafael J. Wysocki
On Tue, Mar 13, 2018 at 4:11 AM, Dou Liyang wrote: > Hi Thomas, > > At 03/09/2018 11:08 PM, Thomas Gleixner wrote: > [...] >> >> >> I'm not sure if there is a clear indicator whether physcial hotplug is >> supported or not, but the ACPI folks (x86) and architecture maintainers > > +cc Rafael > >>

Re: [PATCH 00/11] fs: use freeze_fs on suspend/hibernate

2017-12-12 Thread Rafael J. Wysocki
On Thursday, November 30, 2017 12:23:45 AM CET Luis R. Rodriguez wrote: > This is a followup from the original RFC which proposed to start > to kill kthread freezing all together [0]. Instead of going straight > out to the jugular for kthread freezing this series only addresses > killing freezer ca

Re: [PATCH 07/11] xfs: remove not needed freezing calls

2017-11-30 Thread Rafael J. Wysocki
On Friday, December 1, 2017 12:30:33 AM CET Dave Chinner wrote: > On Thu, Nov 30, 2017 at 09:32:53PM +0100, Rafael J. Wysocki wrote: > > On Thu, Nov 30, 2017 at 5:21 PM, Jan Kara wrote: > > > On Wed 29-11-17 15:23:52, Luis R. Rodriguez wrote: > > >> This removes su

Re: [PATCH 07/11] xfs: remove not needed freezing calls

2017-11-30 Thread Rafael J. Wysocki
On Thu, Nov 30, 2017 at 5:21 PM, Jan Kara wrote: > On Wed 29-11-17 15:23:52, Luis R. Rodriguez wrote: >> This removes superflous freezer calls as they are no longer needed >> as the VFS now performs filesystem freezing/thaw if the filesystem has >> support for it. >> >> The following Coccinelle ru

Re: [PATCH 05/11] fs: add iterate_supers_excl() and iterate_supers_reverse_excl()

2017-11-29 Thread Rafael J. Wysocki
On Thu, Nov 30, 2017 at 2:34 AM, Dave Chinner wrote: > On Thu, Nov 30, 2017 at 12:48:15AM +0100, Rafael J. Wysocki wrote: >> On Thu, Nov 30, 2017 at 12:23 AM, Luis R. Rodriguez >> wrote: >> > There are use cases where we wish to traverse the superblock list >> >

Re: [PATCH 05/11] fs: add iterate_supers_excl() and iterate_supers_reverse_excl()

2017-11-29 Thread Rafael J. Wysocki
On Thu, Nov 30, 2017 at 12:23 AM, Luis R. Rodriguez wrote: > There are use cases where we wish to traverse the superblock list > but also capture errors, and in which case we want to avoid having > our callers issue a lock themselves since we can do the locking for > the callers. Provide a iterate

Re: [RFC 5/5] pm: remove kernel thread freezing

2017-10-03 Thread Rafael J. Wysocki
On Tuesday, October 3, 2017 8:59:00 PM CEST Rafael J. Wysocki wrote: > On Tuesday, October 3, 2017 8:53:13 PM CEST Luis R. Rodriguez wrote: > > Now that all filesystems which used to rely on kthread > > freezing have been converted to filesystem freeze/thawing > > we can remo

Re: [RFC 5/5] pm: remove kernel thread freezing

2017-10-03 Thread Rafael J. Wysocki
On Tue, Oct 3, 2017 at 10:38 PM, Jiri Kosina wrote: > On Tue, 3 Oct 2017, Pavel Machek wrote: > >> > This point I don't understand. What exactly do you mean? >> >> Hibernation: >> >> We freeze, do system snapshot, unfreeze, and write image to >> disk. > > Where/why do you unfreeze between creating

Re: [RFC 5/5] pm: remove kernel thread freezing

2017-10-03 Thread Rafael J. Wysocki
On Tuesday, October 3, 2017 8:53:13 PM CEST Luis R. Rodriguez wrote: > Now that all filesystems which used to rely on kthread > freezing have been converted to filesystem freeze/thawing > we can remove the kernel kthread freezer. > > Signed-off-by: Luis R. Rodriguez I like this one. :-) Thanks,

Re: [PATCH 1/6] ACPI: make device_attribute const

2017-08-28 Thread Rafael J. Wysocki
On Monday, August 21, 2017 1:43:07 PM CEST Bhumika Goyal wrote: > Make these const as they are only passed as an argument to the function > device_create_file and device_remove_file and the corresponding > arguments are of type const. > Done using Coccinelle > > Signed-off-by: Bhumika Goyal > ---

Re: [PATCH 0/6] drivers: make device_attribute const

2017-08-21 Thread Rafael J. Wysocki
On Mon, Aug 21, 2017 at 1:43 PM, Bhumika Goyal wrote: > Make these const. Done using Coccinelle. > > @match disable optional_qualifier@ > identifier s; > @@ > static struct device_attribute s = {...}; > > @ref@ > position p; > identifier match.s; > @@ > s@p > > @good1@ > identifier match.s; > expr