Re: [PATCH] block: set rq->cmd_flags with bio->opf instead of data->cmd_flags when bio is not Null

2019-01-28 Thread chenxiang (M)
在 2019/1/28 23:57, Christoph Hellwig 写道: On Mon, Jan 28, 2019 at 03:36:58PM +, John Garry wrote: As I understood, the problem is the scenario of calling blk_mq_make_request()->bio_integrity_prep() where we then allocate a bio integrity payload in calling bio_integrity_alloc(). In this ca

Re: [PATCH] block: set rq->cmd_flags with bio->opf instead of data->cmd_flags when bio is not Null

2019-01-24 Thread chenxiang (M)
+cc Jens + linux-block 在 2019/1/24 21:43, chenxiang 写道: In function blk_mq_make_request(), though data->cmd_flags will be initialized with bio->opf, later bio->opf may be set as REQ_INTEGRITY if enabled DIX. So need to use bio->opf instead of data->cmd_flags in function blk_mq_rq_ctx_init(), or

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-27 Thread chenxiang (M)
Hi Lei Ming, 在 2018/11/27 21:08, Ming Lei 写道: On Tue, Nov 27, 2018 at 05:55:45PM +0800, chenxiang (M) wrote: Hi all, There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before we developed DIF/DIX feature on kernel 4.18 (disable CONFIG_SCSI_MQ_DEFAULT default), and it works well

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-27 Thread chenxiang (M)
Hi, 在 2018/11/28 4:22, Ewan D. Milne 写道: On Tue, 2018-11-27 at 17:55 +0800, chenxiang (M) wrote: [ 629.210506] Unable to handle kernel paging request at virtual address 8027e048 [ 629.210506] Unable to handle kernel paging request at virtual address 8027e048 ... [ 629.380218

DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-27 Thread chenxiang (M)
Hi all, There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before we developed DIF/DIX feature on kernel 4.18 (disable CONFIG_SCSI_MQ_DEFAULT default), and it works well. But when we switch to kernel 4.19-rc1 and 4.20-rc1, Call trace as follow occurs when running fio and if disab

Re: [bug report] Don't enter SCSI error handler on kernel 4.16-rc1

2018-02-27 Thread chenxiang (M)
在 2018/2/27 22:57, Bart Van Assche 写道: On Tue, 2018-02-27 at 15:09 +0800, chenxiang (M) wrote: 在 2018/2/26 23:25, Bart Van Assche 写道: On Mon, 2018-02-26 at 17:37 +0800, chenxiang (M) wrote: When i have a test on kernel 4.16-rc1, find a issue: running IO on SATA disk, then disable the disk

Re: [PATCH V2 8/8] scsi: hpsa: use blk_mq to solve irq affinity issue

2018-02-05 Thread chenxiang (M)
在 2018/2/5 23:20, Ming Lei 写道: This patch uses .force_blk_mq to drive HPSA via SCSI_MQ, meantime maps each reply queue to blk_mq's hw queue, then .queuecommand can always choose the hw queue as the reply queue. And if no any online CPU is mapped to one hw queue, request can't be submitted to this

Re: [PATCH V2 0/2] block: fix queue freeze and cleanup

2017-12-15 Thread chenxiang (M)
在 2017/12/14 5:53, Bart Van Assche 写道: On Wed, 2017-11-29 at 10:57 +0800, chenxiang (M) wrote: I applied this v2 patchset to kernel 4.15-rc1, running fio on a SATA disk, then disable the disk with sysfs interface (echo 0 > /sys/class/sas_phy/phy-1:0:1/enable), and find system is hung. But w

Re: [PATCH V2 0/2] block: fix queue freeze and cleanup

2017-11-28 Thread chenxiang (M)
在 2017/11/29 12:54, Ming Lei 写道: Hi Chenxiang, On Wed, Nov 29, 2017 at 10:57:06AM +0800, chenxiang (M) wrote: 在 2017/11/27 20:41, Ming Lei 写道: On Thu, Nov 23, 2017 at 12:47:58PM +0800, Ming Lei wrote: Hi Jens, The 1st patch runs queue in blk_freeze_queue_start() for fixing one regression by

Re: [PATCH V2 0/2] block: fix queue freeze and cleanup

2017-11-28 Thread chenxiang (M)
在 2017/11/27 20:41, Ming Lei 写道: On Thu, Nov 23, 2017 at 12:47:58PM +0800, Ming Lei wrote: Hi Jens, The 1st patch runs queue in blk_freeze_queue_start() for fixing one regression by 055f6e18e08f("block: Make q_usage_counter also track legacy requests"). The 2nd patch drians blkcg part of reque

Re: [bug report after v4.5-rc1]block: When the scsi device has a timeout IO, the scsi device is stuck when it is deleted

2017-11-02 Thread chenxiang (M)
在 2017/11/2 20:16, Zouming (IT) 写道: 1.Repeat steps: (1) send IO on the device /dev/sdx. (2) Simulate an IO lost (3) Use the command before to delete scsi device before IO timeout ehco 1 > /sys/class/sdx/device/delete 2.The stack of delete thead is before: [] msleep+0x2f/0x40 [] __blk_dr

Re: [bug report] A race between blk_cleanup_queue and blk_timeout_work

2017-10-19 Thread chenxiang (M)
在 2017/10/19 2:09, Bart Van Assche 写道: On Wed, 2017-10-18 at 09:39 -0700, Bart Van Assche wrote: On Tue, 2017-10-17 at 09:55 +0800, chenxiang (M) wrote: I find there is a race between blk_cleanup_queue and blk_timeout_work Thanks for the detailed report. Would it be possible to test the patch

[bug report] A race between blk_cleanup_queue and blk_timeout_work

2017-10-16 Thread chenxiang (M)
Hi Jens, Christoph, There is a scenario: unplug this disks when running IO in disk, we will find IO is blocked all the times as follows: .. Jobs: 3 (f=3): [M_MM__] [89.7% done] [0K/0K /s] [0 /0 iops] [eta 00m:36s] .. I find there is a race between blk_cleanup_queue and blk_timeout_work