Re: [PATCH] blk-throttle: fix null pointer dereference while throttling writeback IOs

2017-10-10 Thread Jens Axboe
On 10/10/2017 01:05 PM, Shaohua Li wrote: > On Tue, Oct 10, 2017 at 12:48:38PM -0600, Jens Axboe wrote: >> On 10/10/2017 12:13 PM, Shaohua Li wrote: >>> On Tue, Oct 10, 2017 at 11:13:32AM +0800, xuejiufei wrote: From: Jiufei Xue A null pointer dereference can occur when blkcg is rem

Re: [PATCH] blk-throttle: fix null pointer dereference while throttling writeback IOs

2017-10-10 Thread Shaohua Li
On Tue, Oct 10, 2017 at 12:48:38PM -0600, Jens Axboe wrote: > On 10/10/2017 12:13 PM, Shaohua Li wrote: > > On Tue, Oct 10, 2017 at 11:13:32AM +0800, xuejiufei wrote: > >> From: Jiufei Xue > >> > >> A null pointer dereference can occur when blkcg is removed manually > >> with writeback IOs infligh

Re: [PATCH] blk-throttle: fix null pointer dereference while throttling writeback IOs

2017-10-10 Thread Jens Axboe
On 10/10/2017 12:13 PM, Shaohua Li wrote: > On Tue, Oct 10, 2017 at 11:13:32AM +0800, xuejiufei wrote: >> From: Jiufei Xue >> >> A null pointer dereference can occur when blkcg is removed manually >> with writeback IOs inflight. This is caused by the following case: >> >> Writeback kworker submit

Re: [PATCH] blk-throttle: fix null pointer dereference while throttling writeback IOs

2017-10-10 Thread Shaohua Li
On Tue, Oct 10, 2017 at 11:13:32AM +0800, xuejiufei wrote: > From: Jiufei Xue > > A null pointer dereference can occur when blkcg is removed manually > with writeback IOs inflight. This is caused by the following case: > > Writeback kworker submit the bio and set bio->bi_cg_private to tg > in bl

[PATCH] blk-throttle: fix null pointer dereference while throttling writeback IOs

2017-10-09 Thread xuejiufei
From: Jiufei Xue A null pointer dereference can occur when blkcg is removed manually with writeback IOs inflight. This is caused by the following case: Writeback kworker submit the bio and set bio->bi_cg_private to tg in blk_throtl_assoc_bio. Then we remove the block cgroup manually, the blkg an