Re: [PATCH] block: null_blk: fix 'Invalid parameters' failure when loading module

2018-03-05 Thread Ming Lei
On Mon, Mar 05, 2018 at 03:57:07PM +, Bart Van Assche wrote: > On Sat, 2018-03-03 at 10:24 +0800, Ming Lei wrote: > > struct nullb_page { > > struct page *page; > > - unsigned long bitmap; > > + unsigned long bitmap[DIV_ROUND_UP(MAP_SZ, sizeof(unsigned long) * 8)]; > > }; > > Could

Re: [PATCH] block: null_blk: fix 'Invalid parameters' failure when loading module

2018-03-05 Thread Bart Van Assche
On Sat, 2018-03-03 at 10:24 +0800, Ming Lei wrote: > struct nullb_page { > struct page *page; > - unsigned long bitmap; > + unsigned long bitmap[DIV_ROUND_UP(MAP_SZ, sizeof(unsigned long) * 8)]; > }; Could DECLARE_BITMAP() have been used here? Thanks, Bart.