On 1/4/19 1:37 PM, John Pittman wrote:
> Thanks Bart; I made the changes and sent them in as a v2, I'm sure you
> already saw. I have a quick, unrelated question if you have a moment.
> In testing the null_blk driver, I found that trim commands sent by fio
> were rejected due to lack of support.
Thanks Bart, I appreciate it.
On Fri, Jan 4, 2019 at 3:49 PM Bart Van Assche wrote:
>
> On Fri, 2019-01-04 at 15:37 -0500, John Pittman wrote:
> > Thanks Bart; I made the changes and sent them in as a v2, I'm sure you
> > already saw. I have a quick, unrelated question if you have a moment.
> >
On Fri, 2019-01-04 at 15:37 -0500, John Pittman wrote:
> Thanks Bart; I made the changes and sent them in as a v2, I'm sure you
> already saw. I have a quick, unrelated question if you have a moment.
> In testing the null_blk driver, I found that trim commands sent by fio
> were rejected due to la
Thanks Bart; I made the changes and sent them in as a v2, I'm sure you
already saw. I have a quick, unrelated question if you have a moment.
In testing the null_blk driver, I found that trim commands sent by fio
were rejected due to lack of support. Tracking down Shaohua's commit
306eb6b4a ("null
On Fri, 2019-01-04 at 08:46 -0800, Bart Van Assche wrote:
> On Fri, 2019-01-04 at 10:42 -0500, John Pittman wrote:
> > static inline int null_zone_init(struct nullb_device *dev)
> > {
> > + pr_info("CONFIG_BLK_DEV_ZONED not enabled\n");
> > return -EINVAL;
> > }
>
> Have you considered to
On Fri, 2019-01-04 at 10:42 -0500, John Pittman wrote:
> static inline int null_zone_init(struct nullb_device *dev)
> {
> + pr_info("CONFIG_BLK_DEV_ZONED not enabled\n");
> return -EINVAL;
> }
Have you considered to use pr_err() instead of pr_info()?
Thanks,
Bart.
On Fri, 2019-01-04 at 10:42 -0500, John Pittman wrote:
> If the kernel is built without CONFIG_BLK_DEV_ZONED, a modprobe
> of the null_blk driver with zoned=1 fails with 'Invalid argument'.
> This can be confusing to users, prompting a search as to why the
> parameter is invalid. To assist in that
If the kernel is built without CONFIG_BLK_DEV_ZONED, a modprobe
of the null_blk driver with zoned=1 fails with 'Invalid argument'.
This can be confusing to users, prompting a search as to why the
parameter is invalid. To assist in that search, add a bit more
information to the failure, additionally