Re: [PATCH] null_blk: use SECTOR_SHIFT consistently

2019-07-08 Thread Chaitanya Kulkarni
Minwoo and Marcus reviewed this patch in the last week. Ping ? On 07/02/2019 01:29 PM, Chaitanya Kulkarni wrote: > This is a pure cleanup patch and doesn't change any functionality. > In null_blk_main.c we use mixed style of the code SECTOR_SHIFT and >>> 9. Get rid of the >> 9 and use SECTOR_SHIF

Re: [PATCH] null_blk: use SECTOR_SHIFT consistently

2019-07-02 Thread Minwoo Im
On 19-07-02 13:28:57, Chaitanya Kulkarni wrote: > This is a pure cleanup patch and doesn't change any functionality. > In null_blk_main.c we use mixed style of the code SECTOR_SHIFT and > >> 9. Get rid of the >> 9 and use SECTOR_SHIFT everywhere. > > Signed-off-by: Chaitanya Kulkarni This looks

Re: [PATCH] null_blk: use SECTOR_SHIFT consistently

2019-07-02 Thread Marcos Paulo de Souza
On Tue, Jul 02, 2019 at 01:28:57PM -0700, Chaitanya Kulkarni wrote: > This is a pure cleanup patch and doesn't change any functionality. > In null_blk_main.c we use mixed style of the code SECTOR_SHIFT and > >> 9. Get rid of the >> 9 and use SECTOR_SHIFT everywhere. > Agreed, much better than a m

[PATCH] null_blk: use SECTOR_SHIFT consistently

2019-07-02 Thread Chaitanya Kulkarni
This is a pure cleanup patch and doesn't change any functionality. In null_blk_main.c we use mixed style of the code SECTOR_SHIFT and >> 9. Get rid of the >> 9 and use SECTOR_SHIFT everywhere. Signed-off-by: Chaitanya Kulkarni --- drivers/block/null_blk_main.c | 6 +++--- 1 file changed, 3 inser