Re: [PATCH] nvme: remove pci device if no longer present

2017-07-05 Thread Keith Busch
[correcting linux-nvme in the CC] On Wed, Jul 05, 2017 at 12:03:35PM -0400, Keith Busch wrote: > On Sun, Jul 02, 2017 at 08:31:51AM -0700, Christoph Hellwig wrote: > > Please CC the linux-nvme list on any nvme issues. Also this > > code is getting a little too fancy for living in nvme, I think we

Re: [PATCH] nvme: remove pci device if no longer present

2017-07-05 Thread Keith Busch
On Sun, Jul 02, 2017 at 08:31:51AM -0700, Christoph Hellwig wrote: > Please CC the linux-nvme list on any nvme issues. Also this > code is getting a little too fancy for living in nvme, I think we > need to move it into the PCI core, ensure we properly take drv->lock > to synchronize it, and check

Re: [PATCH] nvme: remove pci device if no longer present

2017-07-02 Thread Christoph Hellwig
Please CC the linux-nvme list on any nvme issues. Also this code is getting a little too fancy for living in nvme, I think we need to move it into the PCI core, ensure we properly take drv->lock to synchronize it, and check for dev->drv instead of the private data which is a guestimate. On Fri, J

[PATCH] nvme: remove pci device if no longer present

2017-06-30 Thread Wei Zhang
This patch removes the PCI device from the kernel's topology tree if the device is no longer present. Commit ddf097ec1d44c9648c4738d7cf2819411b44253a (NVMe: Unbind driver on failure) left the PCI device in the kernel's topology upon device failure. However, this does not work well for the slot pow