Re: [PATCH 01/10] block: move existing elevator ops to union

2017-01-13 Thread Jens Axboe
On Fri, Jan 13 2017, Christoph Hellwig wrote: > On Wed, Jan 11, 2017 at 02:39:54PM -0700, Jens Axboe wrote: > > Prep patch for adding MQ ops as well, since doing anon unions with > > named initializers doesn't work on older compilers. > > My gut feeling tells me MQ schedulers shouldn't share

Re: [PATCH 01/10] block: move existing elevator ops to union

2017-01-13 Thread Christoph Hellwig
On Wed, Jan 11, 2017 at 02:39:54PM -0700, Jens Axboe wrote: > Prep patch for adding MQ ops as well, since doing anon unions with > named initializers doesn't work on older compilers. My gut feeling tells me MQ schedulers shouldn't share elevator_type. I'll play around a bit with the code later to

Re: [PATCH 01/10] block: move existing elevator ops to union

2017-01-12 Thread Johannes Thumshirn
On Wed, Jan 11, 2017 at 02:39:54PM -0700, Jens Axboe wrote: > Prep patch for adding MQ ops as well, since doing anon unions with > named initializers doesn't work on older compilers. > > Signed-off-by: Jens Axboe > --- Looks good, Reviewed-by: Johannes Thumshirn

[PATCH 01/10] block: move existing elevator ops to union

2017-01-11 Thread Jens Axboe
Prep patch for adding MQ ops as well, since doing anon unions with named initializers doesn't work on older compilers. Signed-off-by: Jens Axboe --- block/blk-ioc.c | 8 +++ block/blk-merge.c| 4 ++-- block/blk.h | 10