Re: [PATCH 01/28] ibtrs: add header shared between ibtrs_client and ibtrs_server

2017-03-24 Thread Jinpu Wang
On Fri, Mar 24, 2017 at 3:31 PM, Johannes Thumshirn wrote: > On Fri, Mar 24, 2017 at 01:54:04PM +0100, Jinpu Wang wrote: >> >> + >> >> +#define XX(a) case (a): return #a >> > >> > please no macros with retun in them and XX isn't quite too descriptive as >> > well. >> > >> >

Re: [PATCH 01/28] ibtrs: add header shared between ibtrs_client and ibtrs_server

2017-03-24 Thread Johannes Thumshirn
On Fri, Mar 24, 2017 at 01:54:04PM +0100, Jinpu Wang wrote: > >> + > >> +#define XX(a) case (a): return #a > > > > please no macros with retun in them and XX isn't quite too descriptive as > > well. > > > > [...] > > > >> +static inline const char *ib_wc_opcode_str(enum ib_wc_opcode opcode) > >>

Re: [PATCH 01/28] ibtrs: add header shared between ibtrs_client and ibtrs_server

2017-03-24 Thread Jinpu Wang
>> + >> +#define XX(a) case (a): return #a > > please no macros with retun in them and XX isn't quite too descriptive as > well. > > [...] > >> +static inline const char *ib_wc_opcode_str(enum ib_wc_opcode opcode) >> +{ >> + switch (opcode) { >> + XX(IB_WC_SEND); >> +

Re: [PATCH 01/28] ibtrs: add header shared between ibtrs_client and ibtrs_server

2017-03-24 Thread Johannes Thumshirn
On Fri, Mar 24, 2017 at 11:45:16AM +0100, Jack Wang wrote: > From: Jack Wang > > Signed-off-by: Jack Wang > Signed-off-by: Kleber Souza > Signed-off-by: Danil Kipnis >

[PATCH 01/28] ibtrs: add header shared between ibtrs_client and ibtrs_server

2017-03-24 Thread Jack Wang
From: Jack Wang Signed-off-by: Jack Wang Signed-off-by: Kleber Souza Signed-off-by: Danil Kipnis Signed-off-by: Roman Pen ---