Re: [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues

Reviewed-by: Sagi Grimberg

Re: [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues

On Sun, Dec 02, 2018 at 08:46:22AM -0800, Christoph Hellwig wrote: > This is the last place outside of nvme_irq that handles CQEs from > interrupt context, and thus is in the way of removing the cq_lock for > normal queues, and avoiding lockdep warnings on the poll queues, for > which we already

[PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues

This is the last place outside of nvme_irq that handles CQEs from interrupt context, and thus is in the way of removing the cq_lock for normal queues, and avoiding lockdep warnings on the poll queues, for which we already take it without IRQ disabling. Signed-off-by: Christoph Hellwig ---

Re: [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues

On Fri, Nov 30, 2018 at 12:08:09AM -0800, Christoph Hellwig wrote: > On Thu, Nov 29, 2018 at 01:36:32PM -0700, Keith Busch wrote: > > On Thu, Nov 29, 2018 at 08:13:04PM +0100, Christoph Hellwig wrote: > > > + > > > + /* handle any remaining CQEs */ > > > + if (opcode ==

Re: [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues

On Thu, Nov 29, 2018 at 01:36:32PM -0700, Keith Busch wrote: > On Thu, Nov 29, 2018 at 08:13:04PM +0100, Christoph Hellwig wrote: > > This is the last place outside of nvme_irq that handles CQEs from > > interrupt context, and thus is in the way of removing the cq_lock for > > normal queues, and

Re: [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues

On Thu, Nov 29, 2018 at 08:13:04PM +0100, Christoph Hellwig wrote: > This is the last place outside of nvme_irq that handles CQEs from > interrupt context, and thus is in the way of removing the cq_lock for > normal queues, and avoiding lockdep warnings on the poll queues, for > which we already

[PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues

This is the last place outside of nvme_irq that handles CQEs from interrupt context, and thus is in the way of removing the cq_lock for normal queues, and avoiding lockdep warnings on the poll queues, for which we already take it without IRQ disabling. Signed-off-by: Christoph Hellwig ---

[PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues

This is the last place outside of nvme_irq that handles CQEs from interrupt context, and thus is in the way of removing the cq_lock for normal queues, and avoiding lockdep warnings on the poll queues, for which we already take it without IRQ disabling. Signed-off-by: Christoph Hellwig ---