pblk_submit_read() uses bio_clone_bioset() but doesn't change the
io_vec, so bio_clone_fast() is a better choice.
It also uses fs_bio_set which is intended for filesystems. Using it
in a device driver can deadlock.
So allocate a new bioset, and and use bio_clone_fast().
Reviewed-by: Christoph
> On 2 May 2017, at 23.51, NeilBrown wrote:
>
>>
>> Hi Neil,
>>
>> Looks good. Thanks for fixing this. I did not know that bio_clone_bioset
>> was not supposed to be used on drivers.
>
> Prior to my patchset, using bio_clone_bioset() wasn't wrong in drivers,
> though it was a
On Tue, May 02 2017, Javier González wrote:
>> On 2 May 2017, at 05.42, NeilBrown wrote:
>>
>> pblk_submit_read() uses bio_clone_bioset() but doesn't change the
>> io_vec, so bio_clone_fast() is a better choice.
>>
>> It also uses fs_bio_set which is intended for filesystems.
> On 2 May 2017, at 05.42, NeilBrown wrote:
>
> pblk_submit_read() uses bio_clone_bioset() but doesn't change the
> io_vec, so bio_clone_fast() is a better choice.
>
> It also uses fs_bio_set which is intended for filesystems. Using it
> in a device driver can deadlock.
> So
Looks fine,
Reviewed-by: Christoph Hellwig
pblk_submit_read() uses bio_clone_bioset() but doesn't change the
io_vec, so bio_clone_fast() is a better choice.
It also uses fs_bio_set which is intended for filesystems. Using it
in a device driver can deadlock.
So allocate a new bioset, and and use bio_clone_fast().
Signed-off-by: NeilBrown