On Mon, Jan 08, 2018 at 04:34:36PM +0100, Christoph Hellwig wrote:
> It's basically a kernel bug as it tries to access lbas that do not
> exist. BLK_STS_TARGET should be fine.
Okay, I'll fix this and address your other comments, and resend. Thanks
for the feedback.
On Mon, Jan 08, 2018 at 10:29:33AM -0500, Mike Snitzer wrote:
> No argument needed. Definitely needs fixing. Too many upper layers
> consider BLK_STS_NOSPC retryable (XFS, ext4, dm-thinp, etc). Which
> NVME_SC_LBA_RANGE absolutely isn't.
>
> When I backfilled NVME_SC_LBA_RANGE handling I catego
On Mon, Jan 08 2018 at 5:19am -0500,
Christoph Hellwig wrote:
> On Mon, Jan 08, 2018 at 11:09:03AM +0100, Hannes Reinecke wrote:
> > >> case NVME_SC_SUCCESS:
> > >> return BLK_STS_OK;
> > >> case NVME_SC_CAP_EXCEEDED:
> > >> +case NVME_SC_LBA_RANGE:
> >
On Mon, Jan 08, 2018 at 11:09:03AM +0100, Hannes Reinecke wrote:
> >>case NVME_SC_SUCCESS:
> >>return BLK_STS_OK;
> >>case NVME_SC_CAP_EXCEEDED:
> >> + case NVME_SC_LBA_RANGE:
> >>return BLK_STS_NOSPC;
> >
> > lba range isn't really enospc. It is returned when the
On 01/08/2018 10:55 AM, Christoph Hellwig wrote:
> On Thu, Jan 04, 2018 at 03:46:19PM -0700, Keith Busch wrote:
>> This adds more NVMe status code translations to blk_status_t values,
>> and captures all the current status codes NVMe multipath uses.
>>
>> Signed-off-by: Keith Busch
>> ---
>> driv
On Thu, Jan 04, 2018 at 03:46:19PM -0700, Keith Busch wrote:
> This adds more NVMe status code translations to blk_status_t values,
> and captures all the current status codes NVMe multipath uses.
>
> Signed-off-by: Keith Busch
> ---
> drivers/nvme/host/core.c | 6 ++
> 1 file changed, 6 ins
On 01/04/2018 11:46 PM, Keith Busch wrote:
> This adds more NVMe status code translations to blk_status_t values,
> and captures all the current status codes NVMe multipath uses.
>
> Signed-off-by: Keith Busch
> ---
> drivers/nvme/host/core.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> di
On Thu, Jan 04 2018 at 5:46pm -0500,
Keith Busch wrote:
> This adds more NVMe status code translations to blk_status_t values,
> and captures all the current status codes NVMe multipath uses.
>
> Signed-off-by: Keith Busch
Acked-by: Mike Snitzer
This adds more NVMe status code translations to blk_status_t values,
and captures all the current status codes NVMe multipath uses.
Signed-off-by: Keith Busch
---
drivers/nvme/host/core.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.
