Re: [PATCH 1/6] genhd: Fix leaked module reference for NVME devices

2018-02-26 Thread Christoph Hellwig
On Mon, Feb 26, 2018 at 01:01:37PM +0100, Jan Kara wrote: > Commit 8ddcd653257c "block: introduce GENHD_FL_HIDDEN" added handling of > hidden devices to get_gendisk() but forgot to drop module reference > which is also acquired by get_disk(). Drop the reference as necessary. > > Arguably the

[PATCH 1/6] genhd: Fix leaked module reference for NVME devices

2018-02-26 Thread Jan Kara
Commit 8ddcd653257c "block: introduce GENHD_FL_HIDDEN" added handling of hidden devices to get_gendisk() but forgot to drop module reference which is also acquired by get_disk(). Drop the reference as necessary. Arguably the function naming here is misleading as put_disk() is *not* the

[PATCH 1/6] genhd: Fix leaked module reference for NVME devices

2018-02-06 Thread Jan Kara
Commit 8ddcd653257c "block: introduce GENHD_FL_HIDDEN" added handling of hidden devices to get_gendisk() but forgot to drop module reference which is also acquired by get_disk(). Drop the reference as necessary. Arguably the function naming here is misleading as put_disk() is *not* the