Re: [PATCH 11/17] nvme: get rid of nvme_ctrl_list

2017-10-24 Thread Hannes Reinecke
On 10/23/2017 04:51 PM, Christoph Hellwig wrote: > Use the core chrdev code to set up the link between the character device > and the nvme controller. This allows us to get rid of the global list > of all controllers, and also ensures that we have both a reference to > the controller and the

[PATCH 11/17] nvme: get rid of nvme_ctrl_list

2017-10-23 Thread Christoph Hellwig
Use the core chrdev code to set up the link between the character device and the nvme controller. This allows us to get rid of the global list of all controllers, and also ensures that we have both a reference to the controller and the transport module before the open method of the character

Re: [PATCH 11/17] nvme: get rid of nvme_ctrl_list

2017-10-19 Thread Christoph Hellwig
On Thu, Oct 19, 2017 at 09:22:09AM +0200, Johannes Thumshirn wrote: > I'm not sure if the removel of the major number module_param is good > from an ABI POV. This could lead to some unexpected results for those > poor souls that used it. It's a completely broken interface, so I have no pity for

Re: [PATCH 11/17] nvme: get rid of nvme_ctrl_list

2017-10-19 Thread Johannes Thumshirn
I'm not sure if the removel of the major number module_param is good from an ABI POV. This could lead to some unexpected results for those poor souls that used it. Apart from that, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH 11/17] nvme: get rid of nvme_ctrl_list

2017-10-19 Thread Sagi Grimberg
Looks good! Reviewed-by: Sagi Grimberg

[PATCH 11/17] nvme: get rid of nvme_ctrl_list

2017-10-18 Thread Christoph Hellwig
Use the core chrdev code to set up the link between the character device and the nvme controller. This allows us to get rid of the global list of all controllers, and also ensures that we have both a reference to the controller and the transport module before the open method of the character