Re: [PATCH 12/15] virtio_blk: pass queue_limits to blk_mq_alloc_disk

2024-06-30 Thread Christoph Hellwig
On Sun, Jun 30, 2024 at 10:55:12AM +0100, John Garry wrote: > According to the comment on virtio_cread_feature, it is conditional (which > I read as optional) and that function can only fail with -ENOENT. So I > don't think that the probe should fail. virtio people? Oh well.. > I think that it

Re: [PATCH 12/15] virtio_blk: pass queue_limits to blk_mq_alloc_disk

2024-06-30 Thread John Garry
On 29/06/2024 06:19, Christoph Hellwig wrote: On Fri, Jun 28, 2024 at 03:25:02PM +0100, John Garry wrote: I think that we might need a change like the following change after this: 8< [PATCH] virtio_blk: Fix default logical block size If we fail to read a logical block size in virtblk_r

Re: [PATCH 12/15] virtio_blk: pass queue_limits to blk_mq_alloc_disk

2024-06-28 Thread Christoph Hellwig
On Fri, Jun 28, 2024 at 03:25:02PM +0100, John Garry wrote: > I think that we might need a change like the following change after this: > > 8< > [PATCH] virtio_blk: Fix default logical block size > > If we fail to read a logical block size in virtblk_read_limits() -> > virtio_cread_feature(

Re: [PATCH 12/15] virtio_blk: pass queue_limits to blk_mq_alloc_disk

2024-06-28 Thread John Garry
On 22/01/2024 17:36, Christoph Hellwig wrote:> max_dma_size = virtio_max_dma_size(vdev); max_size = max_dma_size > U32_MAX ? U32_MAX : max_dma_size; @@ -1288,7 +1283,7 @@ static int virtblk_read_limits(struct virtio_blk *vblk) if (!err) max_size = min(max_size,

[PATCH 12/15] virtio_blk: pass queue_limits to blk_mq_alloc_disk

2024-02-12 Thread Christoph Hellwig
Call virtblk_read_limits and most of virtblk_probe_zoned_device before allocating the gendisk and thus request_queue and make them read into a queue_limits structure instead. Pass this initialized queue_limits to blk_mq_alloc_disk to set the queue up with the right parameters from the start and on

[PATCH 12/15] virtio_blk: pass queue_limits to blk_mq_alloc_disk

2024-02-11 Thread Christoph Hellwig
Call virtblk_read_limits and most of virtblk_probe_zoned_device before allocating the gendisk and thus request_queue and make them read into a queue_limits structure instead. Pass this initialized queue_limits to blk_mq_alloc_disk to set the queue up with the right parameters from the start and on

Re: [PATCH 12/15] virtio_blk: pass queue_limits to blk_mq_alloc_disk

2024-01-23 Thread Hannes Reinecke
On 1/22/24 18:36, Christoph Hellwig wrote: Call virtblk_read_limits and most of virtblk_probe_zoned_device before allocating the gendisk and thus request_queue and make them read into a queue_limits structure instead. Pass this initialized queue_limits to blk_mq_alloc_disk to set the queue up wi

Re: [PATCH 12/15] virtio_blk: pass queue_limits to blk_mq_alloc_disk

2024-01-23 Thread Stefan Hajnoczi
On Mon, Jan 22, 2024 at 06:36:42PM +0100, Christoph Hellwig wrote: > Call virtblk_read_limits and most of virtblk_probe_zoned_device before > allocating the gendisk and thus request_queue and make them read into > a queue_limits structure instead. Pass this initialized queue_limits > to blk_mq_all

Re: [PATCH 12/15] virtio_blk: pass queue_limits to blk_mq_alloc_disk

2024-01-22 Thread Damien Le Moal
On 1/23/24 02:36, Christoph Hellwig wrote: > Call virtblk_read_limits and most of virtblk_probe_zoned_device before > allocating the gendisk and thus request_queue and make them read into > a queue_limits structure instead. Pass this initialized queue_limits > to blk_mq_alloc_disk to set the queue

[PATCH 12/15] virtio_blk: pass queue_limits to blk_mq_alloc_disk

2024-01-22 Thread Christoph Hellwig
Call virtblk_read_limits and most of virtblk_probe_zoned_device before allocating the gendisk and thus request_queue and make them read into a queue_limits structure instead. Pass this initialized queue_limits to blk_mq_alloc_disk to set the queue up with the right parameters from the start and on