Re: [PATCH 16/22] aio: add support for submission/completion rings

2019-01-02 Thread Jens Axboe
On 1/2/19 9:28 AM, Jens Axboe wrote: >> We'd much rather allocate a file descriptor using anon_inode_getfd >> and operate on that. That also means we can just close that fd >> instead of needing the magic io_destroy, and save all the checks for >> which kind of FD we operate on. > > I'm not again

Re: [PATCH 16/22] aio: add support for submission/completion rings

2019-01-02 Thread Jeff Moyer
Jens Axboe writes: > The submission queue (SQ) and completion queue (CQ) rings are shared > between the application and the kernel. This eliminates the need to > copy data back and forth to submit and complete IO. We use the same > structures as the old aio interface. The SQ rings are indexes int

Re: [PATCH 16/22] aio: add support for submission/completion rings

2019-01-02 Thread Jens Axboe
On 12/27/18 6:47 AM, Christoph Hellwig wrote: > On Fri, Dec 21, 2018 at 12:22:30PM -0700, Jens Axboe wrote: >> The submission queue (SQ) and completion queue (CQ) rings are shared >> between the application and the kernel. This eliminates the need to >> copy data back and forth to submit and comple

Re: [PATCH 16/22] aio: add support for submission/completion rings

2018-12-27 Thread Christoph Hellwig
On Fri, Dec 21, 2018 at 12:22:30PM -0700, Jens Axboe wrote: > The submission queue (SQ) and completion queue (CQ) rings are shared > between the application and the kernel. This eliminates the need to > copy data back and forth to submit and complete IO. We use the same > structures as the old aio

[PATCH 16/22] aio: add support for submission/completion rings

2018-12-21 Thread Jens Axboe
The submission queue (SQ) and completion queue (CQ) rings are shared between the application and the kernel. This eliminates the need to copy data back and forth to submit and complete IO. We use the same structures as the old aio interface. The SQ rings are indexes into a struct iocb array, like w