Re: [PATCH 2/2] nvme: use device_add_disk_with_groups()

2017-09-29 Thread Keith Busch
On Thu, Sep 28, 2017 at 09:36:37PM +0200, Martin Wilck wrote: > By using device_add_disk_with_groups(), we can avoid the race > condition with udev rule processing, because no udev event will > be triggered before all attributes are available. > > Signed-off-by: Martin Wilck Looks good. Reviewe

RE: [PATCH 2/2] nvme: use device_add_disk_with_groups()

2017-09-29 Thread Schremmer, Steven
r.kernel.org; linux-n...@lists.infradead.org; > Hannes Reinecke > Subject: [PATCH 2/2] nvme: use device_add_disk_with_groups() > Tested-by: Steve Schremmer

[PATCH 2/2] nvme: use device_add_disk_with_groups()

2017-09-28 Thread Martin Wilck
By using device_add_disk_with_groups(), we can avoid the race condition with udev rule processing, because no udev event will be triggered before all attributes are available. Signed-off-by: Martin Wilck --- drivers/nvme/host/core.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions