Re: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups

2018-09-28 Thread Christoph Hellwig
On Fri, Sep 28, 2018 at 08:17:20AM +0200, Hannes Reinecke wrote: > We should be registering the ns_id attribute as default sysfs > attribute groups, otherwise we have a race condition between > the uevent and the attributes appearing in sysfs. Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups

2018-09-28 Thread Keith Busch
On Fri, Sep 28, 2018 at 08:17:20AM +0200, Hannes Reinecke wrote: > We should be registering the ns_id attribute as default sysfs > attribute groups, otherwise we have a race condition between > the uevent and the attributes appearing in sysfs. > > Suggested-by: Bart van Assche > Signed-off-by:

[PATCH 2/5] nvme: register ns_id attributes as default sysfs groups

2018-09-28 Thread Hannes Reinecke
We should be registering the ns_id attribute as default sysfs attribute groups, otherwise we have a race condition between the uevent and the attributes appearing in sysfs. Suggested-by: Bart van Assche Signed-off-by: Hannes Reinecke --- drivers/nvme/host/core.c | 21 -

Re: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups

2018-09-06 Thread Hannes Reinecke
On 09/05/2018 03:45 PM, Christoph Hellwig wrote: > On Wed, Sep 05, 2018 at 03:32:03PM +0200, Hannes Reinecke wrote: >> On 09/05/2018 03:18 PM, Christoph Hellwig wrote: >>> On Wed, Sep 05, 2018 at 09:00:50AM +0200, Hannes Reinecke wrote: We should be registering the ns_id attribute as default

Re: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups

2018-09-05 Thread Christoph Hellwig
On Wed, Sep 05, 2018 at 03:32:03PM +0200, Hannes Reinecke wrote: > On 09/05/2018 03:18 PM, Christoph Hellwig wrote: > > On Wed, Sep 05, 2018 at 09:00:50AM +0200, Hannes Reinecke wrote: > >> We should be registering the ns_id attribute as default sysfs > >> attribute groups, otherwise we have a

Re: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups

2018-09-05 Thread Hannes Reinecke
On 09/05/2018 03:18 PM, Christoph Hellwig wrote: > On Wed, Sep 05, 2018 at 09:00:50AM +0200, Hannes Reinecke wrote: >> We should be registering the ns_id attribute as default sysfs >> attribute groups, otherwise we have a race condition between >> the uevent and the attributes appearing in sysfs.

Re: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups

2018-09-05 Thread Christoph Hellwig
On Wed, Sep 05, 2018 at 09:00:50AM +0200, Hannes Reinecke wrote: > We should be registering the ns_id attribute as default sysfs > attribute groups, otherwise we have a race condition between > the uevent and the attributes appearing in sysfs. Please give Bart credit for his work, as the lightnvm

[PATCH 2/5] nvme: register ns_id attributes as default sysfs groups

2018-09-05 Thread Hannes Reinecke
We should be registering the ns_id attribute as default sysfs attribute groups, otherwise we have a race condition between the uevent and the attributes appearing in sysfs. Signed-off-by: Hannes Reinecke --- drivers/nvme/host/core.c | 21 - drivers/nvme/host/lightnvm.c | 106