Re: [PATCH 23/28] block: kill lld busy

2018-10-29 Thread Jens Axboe
On 10/29/18 9:51 AM, Mike Snitzer wrote: > On Mon, Oct 29 2018 at 10:25am -0400, > Jens Axboe wrote: > >> On 10/29/18 1:10 AM, Hannes Reinecke wrote: >>> On 10/25/18 11:10 PM, Jens Axboe wrote: Nobody sets the helper, so we always return 0. Kill it. Signed-off-by: Jens Axboe

Re: [PATCH 23/28] block: kill lld busy

2018-10-29 Thread Mike Snitzer
On Mon, Oct 29 2018 at 10:25am -0400, Jens Axboe wrote: > On 10/29/18 1:10 AM, Hannes Reinecke wrote: > > On 10/25/18 11:10 PM, Jens Axboe wrote: > >> Nobody sets the helper, so we always return 0. Kill it. > >> > >> Signed-off-by: Jens Axboe > >> --- > >> block/blk-core.c | 28 -

Re: [PATCH 23/28] block: kill lld busy

2018-10-29 Thread Jens Axboe
On 10/29/18 1:10 AM, Hannes Reinecke wrote: > On 10/25/18 11:10 PM, Jens Axboe wrote: >> Nobody sets the helper, so we always return 0. Kill it. >> >> Signed-off-by: Jens Axboe >> --- >> block/blk-core.c | 28 >> block/blk-settings.c | 6 -- >> drivers

Re: [PATCH 23/28] block: kill lld busy

2018-10-29 Thread Hannes Reinecke
On 10/25/18 11:10 PM, Jens Axboe wrote: Nobody sets the helper, so we always return 0. Kill it. Signed-off-by: Jens Axboe --- block/blk-core.c | 28 block/blk-settings.c | 6 -- drivers/md/dm-mpath.c | 4 +--- include/linux/blkdev.h | 4 4

Re: [PATCH 23/28] block: kill lld busy

2018-10-25 Thread Jens Axboe
On 10/25/18 3:42 PM, Bart Van Assche wrote: > On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: >> Nobody sets the helper, so we always return 0. Kill it. > > How about changing the description of this patch into something > like "Now that the blk_lld_busy() and blk_queue_lld_busy() callers > h

Re: [PATCH 23/28] block: kill lld busy

2018-10-25 Thread Bart Van Assche
On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: > Nobody sets the helper, so we always return 0. Kill it. How about changing the description of this patch into something like "Now that the blk_lld_busy() and blk_queue_lld_busy() callers have been removed, also remove the implementations of th

[PATCH 23/28] block: kill lld busy

2018-10-25 Thread Jens Axboe
Nobody sets the helper, so we always return 0. Kill it. Signed-off-by: Jens Axboe --- block/blk-core.c | 28 block/blk-settings.c | 6 -- drivers/md/dm-mpath.c | 4 +--- include/linux/blkdev.h | 4 4 files changed, 1 insertion(+), 41 deletions(-)