Re: [PATCH 3/5] block: Micro-optimize bvec_split_segs()

2019-07-23 Thread Bart Van Assche
On 7/23/19 1:20 AM, Johannes Thumshirn wrote: Although I'm always interested in performance numbers when a patch claims to (micro) optimize something. Maybe I should have used the word "Simplify" in the patch subject. Anyway, thanks for the review. Bart.

Re: [PATCH 3/5] block: Micro-optimize bvec_split_segs()

2019-07-23 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn Although I'm always interested in performance numbers when a patch claims to (micro) optimize something. -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LIN

[PATCH 3/5] block: Micro-optimize bvec_split_segs()

2019-07-22 Thread Bart Van Assche
Since bvec_split_segs() is in the hot path, optimize this function by removing two if-tests. Other than requiring that the @sectors pointer is not NULL, this patch does not change the behavior of bvec_split_segs(). Cc: Christoph Hellwig Cc: Ming Lei Cc: Hannes Reinecke Signed-off-by: Bart Van A