Reviewed-by: Sagi Grimberg
On 11/29/18 8:49 AM, Christoph Hellwig wrote:
>> +/*
>> + * Use plugging if we have a ->commit_rqs() hook as well,
>> + * as we know the driver uses bd->last in a smart
>> + * fashion.
>> + */
>
> Nipick: this could flow on just two lines
On Thu, Nov 29, 2018 at 07:49:59AM -0800, Christoph Hellwig wrote:
> > + /*
> > +* Use plugging if we have a ->commit_rqs() hook as well,
> > +* as we know the driver uses bd->last in a smart
> > +* fashion.
> > +*/
>
> Nipick: this could f
> + /*
> + * Use plugging if we have a ->commit_rqs() hook as well,
> + * as we know the driver uses bd->last in a smart
> + * fashion.
> + */
Nipick: this could flow on just two lines:
/*
* Use plugg
On Wed, Nov 28, 2018 at 06:35:38AM -0700, Jens Axboe wrote:
> If we have that hook, we know the driver handles bd->last == true in
> a smart fashion. If it does, even for multiple hardware queues, it's
> a good idea to flush batches of requests to the device, if we have
> batches of requests from t
If we have that hook, we know the driver handles bd->last == true in
a smart fashion. If it does, even for multiple hardware queues, it's
a good idea to flush batches of requests to the device, if we have
batches of requests from the submitter.
Signed-off-by: Jens Axboe
---
block/blk-mq.c | 7 ++
