Re: [PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight I/O in dispatch plugging

2019-07-15 Thread Paolo Valente
Ops, my fault of course. I submitted the patch I made on top of the dev version of bfq. Preparing a V2. Sorry. > Il giorno 15 lug 2019, alle ore 12:49, Holger Hoffstätte > ha scritto: > > On 7/15/19 12:18 PM, Paolo Valente wrote: >> Didn't I simply move it forward in that commit? >>> Il giorno

Re: [PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight I/O in dispatch plugging

2019-07-15 Thread Holger Hoffstätte
On 7/15/19 12:18 PM, Paolo Valente wrote: Didn't I simply move it forward in that commit? Il giorno 15 lug 2019, alle ore 12:16, Holger Hoffstätte ha scritto: Paolo, The function idling_needed_for_service_guarantees() was just removed in 5.3-commit 3726112ec731 ("block, bfq: re-schedule emp

Re: [PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight I/O in dispatch plugging

2019-07-15 Thread Holger Hoffstätte
Paolo, The function idling_needed_for_service_guarantees() was just removed in 5.3-commit 3726112ec731 ("block, bfq: re-schedule empty queues if they deserve I/O plugging"). See [1]. cheers Holger [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/block/bfq-iosch

Re: [PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight I/O in dispatch plugging

2019-07-15 Thread Paolo Valente
Didn't I simply move it forward in that commit? > Il giorno 15 lug 2019, alle ore 12:16, Holger Hoffstätte > ha scritto: > > > Paolo, > > The function idling_needed_for_service_guarantees() was just removed in > 5.3-commit > 3726112ec731 ("block, bfq: re-schedule empty queues if they deserve

[PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight I/O in dispatch plugging

2019-07-15 Thread Paolo Valente
Consider a sync bfq_queue Q that remains empty while in service, and suppose that, when this happens, there is a fair amount of already in-flight I/O not belonging to Q. This situation is not considered when deciding whether to plug I/O dispatching (until new I/O arrives for Q). But it has to be ch