Re: [PATCH V4 09/15] blk-throttle: make bandwidth change smooth

2016-11-23 Thread Shaohua Li
On Wed, Nov 23, 2016 at 04:23:35PM -0500, Tejun Heo wrote: > Hello, > > On Mon, Nov 14, 2016 at 02:22:16PM -0800, Shaohua Li wrote: > > cg1/cg2 bps: 10/80 -> 15/105 -> 20/100 -> 25/95 -> 30/90 -> 35/85 -> 40/80 > > -> 45/75 -> 10/80 > > I wonder whether it'd make sense to make the clamping down g

Re: [PATCH V4 09/15] blk-throttle: make bandwidth change smooth

2016-11-23 Thread Tejun Heo
Hello, On Mon, Nov 14, 2016 at 02:22:16PM -0800, Shaohua Li wrote: > cg1/cg2 bps: 10/80 -> 15/105 -> 20/100 -> 25/95 -> 30/90 -> 35/85 -> 40/80 > -> 45/75 -> 10/80 I wonder whether it'd make sense to make the clamping down gradual too (way faster than the ramping up but still gradual). The contr

[PATCH V4 09/15] blk-throttle: make bandwidth change smooth

2016-11-14 Thread Shaohua Li
When cgroups all reach high limit, cgroups can dispatch more IO. This could make some cgroups dispatch more IO but others not, and even some cgroups could dispatch less IO than their high limit. For example, cg1 high limit 10MB/s, cg2 limit 80MB/s, assume disk maximum bandwidth is 120M/s for the wo