Re: [PATCH V4 1/7] block: introduce blk_quiesce_timeout() and blk_unquiesce_timeout()

2018-05-10 Thread Ming Lei
On Thu, May 10, 2018 at 03:01:04PM +, Bart Van Assche wrote: > On Sat, 2018-05-05 at 21:58 +0800, Ming Lei wrote: > > Turns out the current way can't drain timout completely because mod_timer() > > can be triggered in the work func, which can be just run inside the synced > > timeout work: > >

Re: [PATCH V4 1/7] block: introduce blk_quiesce_timeout() and blk_unquiesce_timeout()

2018-05-10 Thread Bart Van Assche
On Sat, 2018-05-05 at 21:58 +0800, Ming Lei wrote: > Turns out the current way can't drain timout completely because mod_timer() > can be triggered in the work func, which can be just run inside the synced > timeout work: > > del_timer_sync(&q->timeout); > cancel_work_sync(&q->time

[PATCH V4 1/7] block: introduce blk_quiesce_timeout() and blk_unquiesce_timeout()

2018-05-05 Thread Ming Lei
Turns out the current way can't drain timout completely because mod_timer() can be triggered in the work func, which can be just run inside the synced timeout work: del_timer_sync(&q->timeout); cancel_work_sync(&q->timeout_work); This patch introduces one flag of 'timeout_off' for