Re: [PATCH V4 6/7] nvme: pci: prepare for supporting error recovery from resetting context

2018-05-10 Thread Ming Lei
On Mon, May 07, 2018 at 08:04:18AM -0700, James Smart wrote: > > > On 5/5/2018 6:59 AM, Ming Lei wrote: > > --- a/drivers/nvme/host/pci.c > > +++ b/drivers/nvme/host/pci.c > > @@ -2365,14 +2365,14 @@ static void nvme_remove_dead_ctrl(struct nvme_dev > > *dev, int status) > >

Re: [PATCH V4 6/7] nvme: pci: prepare for supporting error recovery from resetting context

2018-05-07 Thread James Smart
On 5/5/2018 6:59 AM, Ming Lei wrote: --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2365,14 +2365,14 @@ static void nvme_remove_dead_ctrl(struct nvme_dev *dev, int status) nvme_put_ctrl(>ctrl); } -static void nvme_reset_work(struct work_struct *work)

[PATCH V4 6/7] nvme: pci: prepare for supporting error recovery from resetting context

2018-05-05 Thread Ming Lei
Either the admin or normal IO in reset context may be timed out because controller error happens. When this timeout happens, we may have to start controller recovery again. This patch holds the introduced reset lock when running reset, so that we may support nested reset in the following patches.