Re: [PATCH blktests] Fix block/011 to not use sysfs for device disabling

2018-06-04 Thread Keith Busch
On Tue, May 29, 2018 at 12:54:28PM -0700, Omar Sandoval wrote: > What's the plan for this test? Do you have a v2 coming? Sorry for the delay. I've been out on holiday, but I'm catching up quickly and will send a v2 shortly. Thanks, Keith

Re: [PATCH blktests] Fix block/011 to not use sysfs for device disabling

2018-05-29 Thread Omar Sandoval
On Mon, May 21, 2018 at 08:08:21AM -0600, Keith Busch wrote: > On Mon, May 21, 2018 at 02:37:56AM -0400, Yi Zhang wrote: > > Hi Keith > > I tried this patch on my R730 Server, but it lead to system hang after > > setpci, could you help check it, thanks. > > > > Console log: > > storageqe-62 login

Re: [PATCH blktests] Fix block/011 to not use sysfs for device disabling

2018-05-21 Thread Keith Busch
On Mon, May 21, 2018 at 02:37:56AM -0400, Yi Zhang wrote: > Hi Keith > I tried this patch on my R730 Server, but it lead to system hang after > setpci, could you help check it, thanks. > > Console log: > storageqe-62 login: > Kernel 4.17.0-rc5 on an x86_64 > > storageqe-62 login: [ 1058.118258]

Re: [PATCH blktests] Fix block/011 to not use sysfs for device disabling

2018-05-20 Thread Yi Zhang
- Original Message - From: "Keith Busch" To: "Omar Sandoval" , linux-block@vger.kernel.org, linux-n...@lists.infradead.org Cc: "Johannes Thumshirn" , "Christoph Hellwig" , "Jens Axboe" , "Ming Lei" , "Keith Busch" Sent: Saturd

Re: [PATCH blktests] Fix block/011 to not use sysfs for device disabling

2018-05-19 Thread Ming Lei
On Sat, May 19, 2018 at 1:42 AM, Keith Busch wrote: > The PCI sysfs interface may not be a dependable method for toggling the > PCI device state to trigger the timeouts. This patch goes directly to > the config space to make device failure occur. > > The success of this test is still senstive to t

[PATCH blktests] Fix block/011 to not use sysfs for device disabling

2018-05-18 Thread Keith Busch
The PCI sysfs interface may not be a dependable method for toggling the PCI device state to trigger the timeouts. This patch goes directly to the config space to make device failure occur. The success of this test is still senstive to timing, as it may disable IO memory when a driver is trying to