On Sat, 2017-04-29 at 07:38 +0200, Markus Trippelsdorf wrote:
> Trying to switch to a non-existing elevator currently results in garbled
> dmesg output, e.g.:
>
> # echo "foo" > /sys/block/sda/queue/scheduler
>
> elevator: type foo not found
> elevator: switch to foo
> failed
>
> (note the un
On Mon, 2017-05-01 at 17:49 +0200, mar...@trippelsdorf.de wrote:
> On 2017.05.01 at 15:18 +, Bart Van Assche wrote:
> > Your patch duplicates the code to remove trailing whitespace which is not
> > very elegant. Please move the code that removes trailing whitespace from
> > __elevator_change()
On 2017.05.01 at 15:18 +, Bart Van Assche wrote:
> On Sat, 2017-04-29 at 07:38 +0200, Markus Trippelsdorf wrote:
> > Trying to switch to a non-existing elevator currently results in garbled
> > dmesg output, e.g.:
> >
> > # echo "foo" > /sys/block/sda/queue/scheduler
> >
> > elevator: type
Trying to switch to a non-existing elevator currently results in garbled
dmesg output, e.g.:
# echo "foo" > /sys/block/sda/queue/scheduler
elevator: type foo not found
elevator: switch to foo
failed
(note the unintended line break.)
Fix by stripping the trailing newline.
diff --git a/block/
