Re: [PATCH v1 2/7] lib: Add Sed-opal library

2016-11-17 Thread Christoph Hellwig
I'm trying to understand the logic for how the OPAL state machine and how it interacts with the Security Send / Receive commands. It seems like it's implemented as an asynchronous state machine, but all the callers and up waiting synchronously for the result. How about making ->send and ->recv (o

Re: [PATCH v1 2/7] lib: Add Sed-opal library

2016-11-16 Thread Keith Busch
On Wed, Nov 16, 2016 at 04:17:27PM -0700, Scott Bauer wrote: > +int opal_unlock_from_suspend(struct opal_suspend_unlk *data) > +{ > + const char *diskname = data->name; > + struct opal_dev *iter, *dev = NULL; > + struct opal_completion *completion; > + void *func_data[3] = { NULL };