Re: [PATCH v2] xfs: fix incorrect log_flushed on fsync

2017-09-06 Thread Brian Foster
On Wed, Sep 06, 2017 at 03:19:37PM +0200, Christoph Hellwig wrote: > > You could also say that flush sequence counting code doesn't belong > > to xfs code at all. There is nothing xfs specific about it. > > > > If we had an API: > > > > flush_seq = blkdev_get_flush_seq(bdev, flush_seq); > > blkde

Re: [PATCH v2] xfs: fix incorrect log_flushed on fsync

2017-09-06 Thread Christoph Hellwig
> You could also say that flush sequence counting code doesn't belong > to xfs code at all. There is nothing xfs specific about it. > > If we had an API: > > flush_seq = blkdev_get_flush_seq(bdev, flush_seq); > blkdev_issue_flush_after(bdev, flush_seq); > > I am sure it would have been useful to

Re: [PATCH v2] xfs: fix incorrect log_flushed on fsync

2017-09-06 Thread Amir Goldstein
[-stable] On Tue, Sep 5, 2017 at 5:40 PM, Brian Foster wrote: > On Sat, Sep 02, 2017 at 06:47:03PM +0300, Amir Goldstein wrote: >> On Sat, Sep 2, 2017 at 4:19 PM, Brian Foster wrote: >> > On Fri, Sep 01, 2017 at 06:39:25PM +0300, Amir Goldstein wrote: >> >> When calling into _xfs_log_force{,_lsn