Re: [PATCH v2 1/2] blk-mq: Reduce the number of if-statements in blk_mq_mark_tag_wait()

On 01/10/2018 08:39 PM, Bart Van Assche wrote: > This patch does not change any functionality but makes the > blk_mq_mark_tag_wait() code slightly easier to read. > > Signed-off-by: Bart Van Assche > Cc: Christoph Hellwig > Cc: Omar Sandoval

Re: [PATCH v2 1/2] blk-mq: Reduce the number of if-statements in blk_mq_mark_tag_wait()

On Wed, 2018-01-10 at 13:30 -0700, Jens Axboe wrote: > On 1/10/18 12:39 PM, Bart Van Assche wrote: > > This patch does not change any functionality but makes the > > blk_mq_mark_tag_wait() code slightly easier to read. > > I agree it could do with a cleanup, but how about something like the >

Re: [PATCH v2 1/2] blk-mq: Reduce the number of if-statements in blk_mq_mark_tag_wait()

On 1/10/18 12:39 PM, Bart Van Assche wrote: > This patch does not change any functionality but makes the > blk_mq_mark_tag_wait() code slightly easier to read. I agree it could do with a cleanup, but how about something like the below? I think that's easier to read. diff --git a/block/blk-mq.c

[PATCH v2 1/2] blk-mq: Reduce the number of if-statements in blk_mq_mark_tag_wait()

This patch does not change any functionality but makes the blk_mq_mark_tag_wait() code slightly easier to read. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Omar Sandoval Cc: Hannes Reinecke Cc: Johannes Thumshirn