Re: [PATCH v2 1/6] block: Avoid that blk_exit_rl() triggers a use-after-free

2017-06-14 Thread Bart Van Assche
On 06/14/17 12:28, Jens Axboe wrote: > I added this, but the above is really a horrible changelog. It doesn't > say how the problem is fixed. I added some verbiage to that effect. Hello Jens, Thanks for having fixed up the changelog and for already having picked up this patch. I was going to repo

Re: [PATCH v2 1/6] block: Avoid that blk_exit_rl() triggers a use-after-free

2017-06-14 Thread Jens Axboe
On 06/14/2017 09:19 AM, Bart Van Assche wrote: > Subject: [PATCH] block: Fix a blk_exit_rl() regression > > Avoid that the following complaint is reported: > > BUG: sleeping function called from invalid context at kernel/workqueue.c:2790 > in_atomic(): 1, irqs_disabled(): 0, pid: 41, name: rcuo

Re: [PATCH v2 1/6] block: Avoid that blk_exit_rl() triggers a use-after-free

2017-06-14 Thread Ross Zwisler
On Wed, Jun 14, 2017 at 9:19 AM, Bart Van Assche wrote: > On 06/13/17 10:54, Ross Zwisler wrote: >> This commit is causing the following kernel BUG for me when I shut >> down my systems: >> >> BUG: sleeping function called from invalid context at >> kernel/workqueue.c:2790 >> in_atomic(): 1,

Re: [PATCH v2 1/6] block: Avoid that blk_exit_rl() triggers a use-after-free

2017-06-14 Thread Bart Van Assche
On 06/13/17 10:54, Ross Zwisler wrote: > This commit is causing the following kernel BUG for me when I shut > down my systems: > > BUG: sleeping function called from invalid context at > kernel/workqueue.c:2790 > in_atomic(): 1, irqs_disabled(): 0, pid: 41, name: rcuop/3 Thanks Ross for the

Re: [PATCH v2 1/6] block: Avoid that blk_exit_rl() triggers a use-after-free

2017-06-13 Thread Ross Zwisler
On Wed, May 31, 2017 at 3:43 PM, Bart Van Assche wrote: > Since the introduction of .init_rq_fn() and .exit_rq_fn() it is > essential that the memory allocated for struct request_queue > stays around until all blk_exit_rl() calls have finished. Hence > make blk_init_rl() take a reference on struct

Re: [PATCH v2 1/6] block: Avoid that blk_exit_rl() triggers a use-after-free

2017-06-01 Thread Jens Axboe
On 05/31/2017 02:43 PM, Bart Van Assche wrote: > Since the introduction of .init_rq_fn() and .exit_rq_fn() it is > essential that the memory allocated for struct request_queue > stays around until all blk_exit_rl() calls have finished. Hence > make blk_init_rl() take a reference on struct request_q

[PATCH v2 1/6] block: Avoid that blk_exit_rl() triggers a use-after-free

2017-05-31 Thread Bart Van Assche
Since the introduction of .init_rq_fn() and .exit_rq_fn() it is essential that the memory allocated for struct request_queue stays around until all blk_exit_rl() calls have finished. Hence make blk_init_rl() take a reference on struct request_queue. This patch fixes the following crash: general p