Re: [PATCH v2 3/7] block: Introduce elevator features

2019-09-03 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v2 3/7] block: Introduce elevator features

2019-08-28 Thread Johannes Thumshirn
On 28/08/2019 13:08, Damien Le Moal wrote: > I changed from unsigned long to unsigned int, which is always 32bits on any > arch, no ? I preferred the use of unsigned int over u32/u64 as these look more > like low level driver stuff... Did I miss something ? Ah no OK then, my mistake. My brain auto

Re: [PATCH v2 3/7] block: Introduce elevator features

2019-08-28 Thread Damien Le Moal
On 2019/08/28 19:43, Johannes Thumshirn wrote: > On 28/08/2019 12:41, Damien Le Moal wrote: >> On 2019/08/28 17:16, Johannes Thumshirn wrote: >>> What happened to my review comment for v1 of this patch? >>> >> >> I merged the renamed ELEVATOR_F_ZBD_SEQ_WRITE feature into this patch >> instead of >

Re: [PATCH v2 3/7] block: Introduce elevator features

2019-08-28 Thread Johannes Thumshirn
On 28/08/2019 12:41, Damien Le Moal wrote: > On 2019/08/28 17:16, Johannes Thumshirn wrote: >> What happened to my review comment for v1 of this patch? >> > > I merged the renamed ELEVATOR_F_ZBD_SEQ_WRITE feature into this patch instead > of > following patch and separated the nullblk and sd_zbc

Re: [PATCH v2 3/7] block: Introduce elevator features

2019-08-28 Thread Damien Le Moal
On 2019/08/28 17:16, Johannes Thumshirn wrote: > What happened to my review comment for v1 of this patch? > I merged the renamed ELEVATOR_F_ZBD_SEQ_WRITE feature into this patch instead of following patch and separated the nullblk and sd_zbc changes into other patches. Well, at least that is what

Re: [PATCH v2 3/7] block: Introduce elevator features

2019-08-28 Thread Johannes Thumshirn
What happened to my review comment for v1 of this patch? -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nürnberg Germany (HRB 247165, AG München) Ke

[PATCH v2 3/7] block: Introduce elevator features

2019-08-27 Thread Damien Le Moal
Introduce the definition of elevator features through the elevator_features flags in the elevator_type structure. Each flag can represent a feature supported by an elevator. The first feature defined by this patch is support for zoned block device sequential write constraint with the flag ELEVATOR_