Re: [PATCH v2 4/4] block: block new I/O just after queue is set as dying

2017-03-24 Thread Bart Van Assche
On Fri, 2017-03-24 at 20:36 +0800, Ming Lei wrote: > + /* block new I/O coming */ > + blk_freeze_queue_start(q); As I have already mentioned two times, the comment above blk_freeze_queue_start() should be made more clear. It should mention that without that call blk_queue_enter() won't

[PATCH v2 4/4] block: block new I/O just after queue is set as dying

2017-03-24 Thread Ming Lei
Before commit 780db2071a(blk-mq: decouble blk-mq freezing from generic bypassing), the dying flag is checked before entering queue, and Tejun converts the checking into .mq_freeze_depth, and assumes the counter is increased just after dying flag is set. Unfortunately we doesn't do that in