Re: [PATCH v3] block: make sure big bio is splitted into at most 256 bvecs

2016-08-22 Thread Ming Lei
On Mon, Aug 22, 2016 at 1:58 AM, Kent Overstreet wrote: > On Sun, Aug 21, 2016 at 05:31:33PM +0800, Ming Lei wrote: >> This patch is definitely correct, and I don't see dealing with 'no_merge' >> should be removed. >> >> In this case, the bio is still possible to merge with others because >> it do

Re: [PATCH v3] block: make sure big bio is splitted into at most 256 bvecs

2016-08-21 Thread Kent Overstreet
On Sun, Aug 21, 2016 at 05:31:33PM +0800, Ming Lei wrote: > This patch is definitely correct, and I don't see dealing with 'no_merge' > should be removed. > > In this case, the bio is still possible to merge with others because > it doesn't violate any limit of the queue because it just can't be h

Re: [PATCH v3] block: make sure big bio is splitted into at most 256 bvecs

2016-08-21 Thread Ming Lei
On Fri, Aug 19, 2016 at 8:41 AM, Eric Wheeler wrote: >> On Mon, Aug 15, 2016 at 11:23:28AM -0700, Christoph Hellwig wrote: >> > On Mon, Aug 15, 2016 at 11:11:22PM +0800, Ming Lei wrote: >> > > After arbitrary bio size is supported, the incoming bio may >> > > be very big. We have to split the bio

Re: [PATCH v3] block: make sure big bio is splitted into at most 256 bvecs

2016-08-18 Thread Eric Wheeler
> On Mon, Aug 15, 2016 at 11:23:28AM -0700, Christoph Hellwig wrote: > > On Mon, Aug 15, 2016 at 11:11:22PM +0800, Ming Lei wrote: > > > After arbitrary bio size is supported, the incoming bio may > > > be very big. We have to split the bio into small bios so that > > > each holds at most BIO_MAX_P

Re: [PATCH v3] block: make sure big bio is splitted into at most 256 bvecs

2016-08-15 Thread Kent Overstreet
On Mon, Aug 15, 2016 at 11:23:28AM -0700, Christoph Hellwig wrote: > On Mon, Aug 15, 2016 at 11:11:22PM +0800, Ming Lei wrote: > > After arbitrary bio size is supported, the incoming bio may > > be very big. We have to split the bio into small bios so that > > each holds at most BIO_MAX_PAGES bvecs

Re: [PATCH v3] block: make sure big bio is splitted into at most 256 bvecs

2016-08-15 Thread Christoph Hellwig
On Mon, Aug 15, 2016 at 11:11:22PM +0800, Ming Lei wrote: > After arbitrary bio size is supported, the incoming bio may > be very big. We have to split the bio into small bios so that > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > as bio_clone(). I still think working around a

[PATCH v3] block: make sure big bio is splitted into at most 256 bvecs

2016-08-15 Thread Ming Lei
After arbitrary bio size is supported, the incoming bio may be very big. We have to split the bio into small bios so that each holds at most BIO_MAX_PAGES bvecs for safety reason, such as bio_clone(). This patch fixes the following kernel crash: > [ 172.660142] BUG: unable to handle kernel NULL