Re: [PATCH v3 2/2] arm64: crypto: add NEON accelerated XOR implementation

2018-11-29 Thread JackieLiu
> 在 2018年11月30日，02:20，Dave Martin 写道： > > On Thu, Nov 29, 2018 at 07:09:10PM +0100, Ard Biesheuvel wrote: >> On Thu, 29 Nov 2018 at 18:00, Dave Martin wrote: >>> >>> On Tue, Nov 27, 2018 at 06:08:58PM +0800, Jackie Liu wrote: > > [...] > +static struct xor_block_template xor_block_arm

Re: [PATCH v3 2/2] arm64: crypto: add NEON accelerated XOR implementation

2018-11-29 Thread Dave Martin
On Thu, Nov 29, 2018 at 07:09:10PM +0100, Ard Biesheuvel wrote: > On Thu, 29 Nov 2018 at 18:00, Dave Martin wrote: > > > > On Tue, Nov 27, 2018 at 06:08:58PM +0800, Jackie Liu wrote: [...] > > > +static struct xor_block_template xor_block_arm64 = { > > > + .name = "arm64_neon", > > > +

Re: [PATCH v3 2/2] arm64: crypto: add NEON accelerated XOR implementation

2018-11-29 Thread Ard Biesheuvel
On Thu, 29 Nov 2018 at 18:00, Dave Martin wrote: > > On Tue, Nov 27, 2018 at 06:08:58PM +0800, Jackie Liu wrote: > > This is a NEON acceleration method that can improve > > performance by approximately 20%. I got the following > > data from the centos 7.5 on Huawei's HISI1616 chip: > > > > [ 93.83

Re: [PATCH v3 2/2] arm64: crypto: add NEON accelerated XOR implementation

2018-11-29 Thread Dave Martin
On Tue, Nov 27, 2018 at 06:08:58PM +0800, Jackie Liu wrote: > This is a NEON acceleration method that can improve > performance by approximately 20%. I got the following > data from the centos 7.5 on Huawei's HISI1616 chip: > > [ 93.837726] xor: measuring software checksum speed > [ 93.874039] 8

Re: [PATCH v3 2/2] arm64: crypto: add NEON accelerated XOR implementation

2018-11-27 Thread Will Deacon
On Tue, Nov 27, 2018 at 01:46:48PM +0100, Ard Biesheuvel wrote: > (add maintainers back to cc) > > On Tue, 27 Nov 2018 at 12:49, Ard Biesheuvel > wrote: > > > > On Tue, 27 Nov 2018 at 11:10, Jackie Liu wrote: > > > > > > This is a NEON acceleration method that can improve > > > performance by a

Re: [PATCH v3 2/2] arm64: crypto: add NEON accelerated XOR implementation

2018-11-27 Thread JackieLiu
Yes, I got it. Thanks for review these patch. BR. Jackie > 在 2018年11月27日，20:46，Ard Biesheuvel 写道： > > (add maintainers back to cc) > > On Tue, 27 Nov 2018 at 12:49, Ard Biesheuvel > wrote: >> >> On Tue, 27 Nov 2018 at 11:10, Jackie Liu wrote: >>> >>> This is a NEON acceleration method tha

Re: [PATCH v3 2/2] arm64: crypto: add NEON accelerated XOR implementation

2018-11-27 Thread Ard Biesheuvel
(add maintainers back to cc) On Tue, 27 Nov 2018 at 12:49, Ard Biesheuvel wrote: > > On Tue, 27 Nov 2018 at 11:10, Jackie Liu wrote: > > > > This is a NEON acceleration method that can improve > > performance by approximately 20%. I got the following > > data from the centos 7.5 on Huawei's HISI

Re: [PATCH v3 2/2] arm64: crypto: add NEON accelerated XOR implementation

2018-11-27 Thread JackieLiu
> 在 2018年11月27日，19:49，Ard Biesheuvel 写道： > > On Tue, 27 Nov 2018 at 11:10, Jackie Liu wrote: >> >> This is a NEON acceleration method that can improve >> performance by approximately 20%. I got the following >> data from the centos 7.5 on Huawei's HISI1616 chip: >> >> [ 93.837726] xor: meas

Re: [PATCH v3 2/2] arm64: crypto: add NEON accelerated XOR implementation

2018-11-27 Thread Ard Biesheuvel
On Tue, 27 Nov 2018 at 11:10, Jackie Liu wrote: > > This is a NEON acceleration method that can improve > performance by approximately 20%. I got the following > data from the centos 7.5 on Huawei's HISI1616 chip: > > [ 93.837726] xor: measuring software checksum speed > [ 93.874039] 8regs : 71

[PATCH v3 2/2] arm64: crypto: add NEON accelerated XOR implementation

2018-11-27 Thread Jackie Liu
This is a NEON acceleration method that can improve performance by approximately 20%. I got the following data from the centos 7.5 on Huawei's HISI1616 chip: [ 93.837726] xor: measuring software checksum speed [ 93.874039] 8regs : 7123.200 MB/sec [ 93.914038] 32regs : 7180.300 MB/sec [ 93.954