Re: [PATCH v4 11/13] nvmet-tcp: add NVMe over TCP target driver

2018-11-29 Thread Sagi Grimberg
+static inline void nvmet_tcp_put_cmd(struct nvmet_tcp_cmd *cmd) +{ +    if (unlikely(cmd == &cmd->queue->connect)) +    return; if you don't return connect cmd to the list please don't add it to it in the first place (during alloc_cmd). and if you use it once, we might think of a clean

Re: [PATCH v4 11/13] nvmet-tcp: add NVMe over TCP target driver

2018-11-28 Thread Max Gurtovoy
hi Sagi, +static inline void nvmet_tcp_put_cmd(struct nvmet_tcp_cmd *cmd) +{ + if (unlikely(cmd == &cmd->queue->connect)) + return; if you don't return connect cmd to the list please don't add it to it in the first place (during alloc_cmd). and if you use it once, we migh

[PATCH v4 11/13] nvmet-tcp: add NVMe over TCP target driver

2018-11-27 Thread Sagi Grimberg
From: Sagi Grimberg This patch implements the TCP transport driver for the NVMe over Fabrics target stack. This allows exporting NVMe over Fabrics functionality over good old TCP/IP. The driver implements the TP 8000 of how nvme over fabrics capsules and data are encapsulated in nvme-tcp pdus an