Re: [PATCHv2] blk-mq: Allow blocking queue tag iter callbacks

2018-09-25 Thread Jens Axboe
On 9/25/18 10:36 AM, Keith Busch wrote: > A recent commit runs tag iterator callbacks under the rcu read lock, > but existing callbacks do not satisfy the non-blocking requirement. > The commit intended to prevent an iterator from accessing a queue that's > being modified. This patch fixes the

Re: [PATCHv2] blk-mq: Allow blocking queue tag iter callbacks

2018-09-25 Thread jianchao.wang
Hi Keith On 09/26/2018 12:36 AM, Keith Busch wrote: > A recent commit runs tag iterator callbacks under the rcu read lock, > but existing callbacks do not satisfy the non-blocking requirement. > The commit intended to prevent an iterator from accessing a queue that's > being modified. This patch

[PATCHv2] blk-mq: Allow blocking queue tag iter callbacks

2018-09-25 Thread Keith Busch
A recent commit runs tag iterator callbacks under the rcu read lock, but existing callbacks do not satisfy the non-blocking requirement. The commit intended to prevent an iterator from accessing a queue that's being modified. This patch fixes the original issue by taking a queue reference instead