Re: [RFC] cleanup bcache bio handling

2018-06-14 Thread Christoph Hellwig
On Thu, Jun 14, 2018 at 09:55:32AM +0800, Ming Lei wrote: > > Agreed about bio_for_each_chunk_all(), but I just looked at the patch that > > introduces them and it looks to me like there's no need, they should just be > > bio_for_each_segment_all(). > > Now we can't change the vector with bio_for_

Re: [RFC] cleanup bcache bio handling

2018-06-13 Thread Ming Lei
On Wed, Jun 13, 2018 at 10:54:09AM -0400, Kent Overstreet wrote: > On Wed, Jun 13, 2018 at 03:56:32PM +0200, Christoph Hellwig wrote: > > On Wed, Jun 13, 2018 at 07:06:41PM +0800, Ming Lei wrote: > > > > before bio_alloc_pages) that can be switched to something that just > > > > creates a > > > >

Re: [RFC] cleanup bcache bio handling

2018-06-13 Thread Kent Overstreet
On Wed, Jun 13, 2018 at 03:56:32PM +0200, Christoph Hellwig wrote: > On Wed, Jun 13, 2018 at 07:06:41PM +0800, Ming Lei wrote: > > > before bio_alloc_pages) that can be switched to something that just > > > creates a > > > single bvec. > > > > Yes, multipage bvec shouldn't break any driver or fs.

[RFC] cleanup bcache bio handling v2

2018-06-13 Thread Christoph Hellwig
Hi all, this series cleans up various places where bcache is way too intimate with bio internals. This is intended as a baseline for the multi-page biovec work, which requires some nasty workarounds for the existing code. Note that I do not have a bcache test setup, so this will require some car

Re: [RFC] cleanup bcache bio handling

2018-06-13 Thread Christoph Hellwig
On Wed, Jun 13, 2018 at 07:06:41PM +0800, Ming Lei wrote: > > before bio_alloc_pages) that can be switched to something that just creates > > a > > single bvec. > > Yes, multipage bvec shouldn't break any driver or fs. It probably isn't broken, at least I didn't see assumptions of the same numbe

Re: [RFC] cleanup bcache bio handling

2018-06-13 Thread Ming Lei
On Wed, Jun 13, 2018 at 05:58:01AM -0400, Kent Overstreet wrote: > On Mon, Jun 11, 2018 at 09:48:00PM +0200, Christoph Hellwig wrote: > > Hi all, > > > > this series cleans up various places where bcache is way too intimate > > with bio internals. This is intended as a baseline for the multi-page

Re: [RFC] cleanup bcache bio handling

2018-06-13 Thread Kent Overstreet
On Mon, Jun 11, 2018 at 09:48:00PM +0200, Christoph Hellwig wrote: > Hi all, > > this series cleans up various places where bcache is way too intimate > with bio internals. This is intended as a baseline for the multi-page > biovec work, which requires some nasty workarounds for the existing > co

Re: [RFC] cleanup bcache bio handling

2018-06-11 Thread Coly Li
On 2018/6/12 3:48 AM, Christoph Hellwig wrote: > Hi all, > > this series cleans up various places where bcache is way too intimate > with bio internals. This is intended as a baseline for the multi-page > biovec work, which requires some nasty workarounds for the existing > code. > > Note that I

[RFC] cleanup bcache bio handling

2018-06-11 Thread Christoph Hellwig
Hi all, this series cleans up various places where bcache is way too intimate with bio internals. This is intended as a baseline for the multi-page biovec work, which requires some nasty workarounds for the existing code. Note that I do not have a bcache test setup, so this will require some car