Re: [RFC PATCH] blk-throttle: dispatch more sync writes in block throttle layer

2018-01-09 Thread xuejiufei
Hi Tejun, On 2018/1/9 下午10:56, Tejun Heo wrote: > Hello, > > On Tue, Jan 09, 2018 at 12:45:13PM +0800, xuejiufei wrote: >> 1. A bio is charged according to the direction, if we put the reads >> and sync writes together, we need to search the queue to pick a >> certain number of read and write IOs

Re: [RFC PATCH] blk-throttle: dispatch more sync writes in block throttle layer

2018-01-09 Thread Tejun Heo
Hello, On Tue, Jan 09, 2018 at 12:45:13PM +0800, xuejiufei wrote: > 1. A bio is charged according to the direction, if we put the reads > and sync writes together, we need to search the queue to pick a > certain number of read and write IOs when the limit is not reached. Ah, you're right. > 2. I

Re: [RFC PATCH] blk-throttle: dispatch more sync writes in block throttle layer

2018-01-08 Thread xuejiufei
Hi Tejun, Thanks for your reply. On 2018/1/8 下午8:07, Tejun Heo wrote: > Hello, > > On Fri, Jan 05, 2018 at 01:16:26PM +0800, xuejiufei wrote: >> From: Jiufei Xue >> >> Cgroup writeback is supported since v4.2. But there exists a problem >> in the following case. >> >> A cgroup may send both buf

Re: [RFC PATCH] blk-throttle: dispatch more sync writes in block throttle layer

2018-01-08 Thread Tejun Heo
Hello, On Fri, Jan 05, 2018 at 01:16:26PM +0800, xuejiufei wrote: > From: Jiufei Xue > > Cgroup writeback is supported since v4.2. But there exists a problem > in the following case. > > A cgroup may send both buffer and direct/sync IOs. The foreground > thread will be stalled when periodic wri

[RFC PATCH] blk-throttle: dispatch more sync writes in block throttle layer

2018-01-04 Thread xuejiufei
From: Jiufei Xue Cgroup writeback is supported since v4.2. But there exists a problem in the following case. A cgroup may send both buffer and direct/sync IOs. The foreground thread will be stalled when periodic writeback IOs is flushed because the service queue in block throttle layer already h