Re: [for-4.16 PATCH v4 3/4] block: allow gendisk's request_queue registration to be deferred

2018-01-11 Thread Ming Lei
On Thu, Jan 11, 2018 at 03:14:16PM -0500, Mike Snitzer wrote: > Since I can remember DM has forced the block layer to allow the > allocation and initialization of the request_queue to be distinct > operations. Reason for this is block/genhd.c:add_disk() has requires > that the request_queue (and a

Re: [for-4.16 PATCH v4 3/4] block: allow gendisk's request_queue registration to be deferred

2018-01-11 Thread Mike Snitzer
On Thu, Jan 11 2018 at 7:37pm -0500, Bart Van Assche wrote: > On Thu, 2018-01-11 at 15:14 -0500, Mike Snitzer wrote: > > -void device_add_disk(struct device *parent, struct gendisk *disk) > > +void device_add_disk_no_queue_reg(struct device *parent, struct gendisk > > *disk) > > { > > dev_

Re: [for-4.16 PATCH v4 3/4] block: allow gendisk's request_queue registration to be deferred

2018-01-11 Thread Bart Van Assche
On Thu, 2018-01-11 at 15:14 -0500, Mike Snitzer wrote: > -void device_add_disk(struct device *parent, struct gendisk *disk) > +void device_add_disk_no_queue_reg(struct device *parent, struct gendisk > *disk) > { > dev_t devt; > int retval; > @@ -682,7 +682,6 @@ void device_add_disk(st

[for-4.16 PATCH v4 3/4] block: allow gendisk's request_queue registration to be deferred

2018-01-11 Thread Mike Snitzer
Since I can remember DM has forced the block layer to allow the allocation and initialization of the request_queue to be distinct operations. Reason for this is block/genhd.c:add_disk() has requires that the request_queue (and associated bdi) be tied to the gendisk before add_disk() is called -- b