Re: Centralize nvme controller reset, delete and fabrics periodic reconnects

2017-08-20 Thread Sagi Grimberg
You want to see it done before we merge? Or are you asking if I want to see it done? I designed it to be incremental and not break existing transports. Personally I think that pci conversion will have to be incremental and gradual as we need some preparations in place first. So if you are

Re: Centralize nvme controller reset, delete and fabrics periodic reconnects

2017-08-16 Thread Christoph Hellwig
On Wed, Aug 16, 2017 at 12:46:25PM +0300, Sagi Grimberg wrote: >>> Sure, should I have it on top of the affinity patches or not? >> >> For now get any tree you have out to take a look. In the longer >> run we'll need to decide how we want to deal with the merge >> of the two trees. In general

Centralize nvme controller reset, delete and fabrics periodic reconnects

2017-08-15 Thread Sagi Grimberg
This is the third part of the attempt to centralize controller reset, delete and fabrics error recovery in nvme core. As a reminder, the motivation is to get as much of the duplicate logic existing in the various nvme transports to coommon code as possible. We strive to have nvme core and fabrics