Re: [PATCH 2/7] mm: remove the swap_readpage return value

2023-01-25 Thread Christoph Hellwig
On Wed, Jan 25, 2023 at 08:58:31AM -0700, Keith Busch wrote: > On Wed, Jan 25, 2023 at 02:34:31PM +0100, Christoph Hellwig wrote: > > -static inline int swap_readpage(struct page *page, bool do_poll, > > - struct swap_iocb **plug) > > +static inline void swap_readpage(stru

RE: [PATCH 2/7] mm: remove the swap_readpage return value

2023-01-25 Thread Dan Williams
Christoph Hellwig wrote: > swap_readpage always returns 0, and no caller checks the return value. > > Signed-off-by: Christoph Hellwig > --- > mm/page_io.c | 16 +--- > mm/swap.h| 7 +++ > 2 files changed, 8 insertions(+), 15 deletions(-) > > diff --git a/mm/page_io.c b/mm/

Re: [PATCH 2/7] mm: remove the swap_readpage return value

2023-01-25 Thread Keith Busch
On Wed, Jan 25, 2023 at 02:34:31PM +0100, Christoph Hellwig wrote: > -static inline int swap_readpage(struct page *page, bool do_poll, > - struct swap_iocb **plug) > +static inline void swap_readpage(struct page *page, bool do_poll, > + struct swap_iocb **plu